All of lore.kernel.org
 help / color / mirror / Atom feed
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: mvebu: Add support for the network controller in Armada 375 SoC
Date: Fri, 4 Jul 2014 16:06:47 -0300	[thread overview]
Message-ID: <20140704190647.GA29955@arch.cereza> (raw)
In-Reply-To: <53B6F796.3090004@cogentembedded.com>

On 04 Jul 10:51 PM, Sergei Shtylyov wrote:
> >+			/* Network controller */
> >+			pp2 at f0000 {
> >+				compatible = "marvell,armada-375-pp2";
> >+				reg = <0xf0000 0xa000>, /* Packet Processor regs */
> >+				      <0xc0000 0x3060>, /* LMS regs */
> >+				      <0xc4000 0x100>,  /* eth0 regs */
> >+				      <0xc5000 0x100>;  /* eth1 regs */
> 
>    Hm, why are the above two ranges not listed under the "ethernet" subnodes?
> 

Because as far as I know, if we want to put reg = <...> properties in a sub-node,
then the parent node has to be a bus, but that's not the case.

I can't remember where have I read that, I'll take a look at the reference.
-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	David Miller <davem@davemloft.net>,
	Jason Cooper <jason@lakedaemon.net>,
	Marcin Wojtas <mw@semihalf.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	Lior Amsalem <alior@marvell.com>
Subject: Re: [PATCH 2/3] ARM: mvebu: Add support for the network controller in Armada 375 SoC
Date: Fri, 4 Jul 2014 16:06:47 -0300	[thread overview]
Message-ID: <20140704190647.GA29955@arch.cereza> (raw)
In-Reply-To: <53B6F796.3090004@cogentembedded.com>

On 04 Jul 10:51 PM, Sergei Shtylyov wrote:
> >+			/* Network controller */
> >+			pp2@f0000 {
> >+				compatible = "marvell,armada-375-pp2";
> >+				reg = <0xf0000 0xa000>, /* Packet Processor regs */
> >+				      <0xc0000 0x3060>, /* LMS regs */
> >+				      <0xc4000 0x100>,  /* eth0 regs */
> >+				      <0xc5000 0x100>;  /* eth1 regs */
> 
>    Hm, why are the above two ranges not listed under the "ethernet" subnodes?
> 

Because as far as I know, if we want to put reg = <...> properties in a sub-node,
then the parent node has to be a bus, but that's not the case.

I can't remember where have I read that, I'll take a look at the reference.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

  reply	other threads:[~2014-07-04 19:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04 18:31 [PATCH net-next 0/3] Network driver for Armada 375 SoC Ezequiel Garcia
2014-07-04 18:31 ` Ezequiel Garcia
2014-07-04 18:31 ` [PATCH 1/3] ethernet: Add new driver for Marvell Armada 375 network unit Ezequiel Garcia
2014-07-05 21:03   ` Francois Romieu
2014-07-05 21:03     ` Francois Romieu
2014-07-05 21:14     ` Joe Perches
2014-07-05 21:14       ` Joe Perches
2014-07-07 14:26     ` Ezequiel Garcia
2014-07-07 14:26       ` Ezequiel Garcia
2014-07-07 21:22       ` Francois Romieu
2014-07-07 21:22         ` Francois Romieu
2014-07-04 18:31 ` [PATCH 2/3] ARM: mvebu: Add support for the network controller in Armada 375 SoC Ezequiel Garcia
2014-07-04 18:31   ` Ezequiel Garcia
2014-07-04 18:51   ` Sergei Shtylyov
2014-07-04 18:51     ` Sergei Shtylyov
2014-07-04 19:06     ` Ezequiel Garcia [this message]
2014-07-04 19:06       ` Ezequiel Garcia
2014-07-04 18:31 ` [PATCH 3/3] ARM: mvebu: Enable the network controller in Armada 375 DB board Ezequiel Garcia
2014-07-04 18:31   ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140704190647.GA29955@arch.cereza \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.