All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	acme@ghostprotocols.net
Subject: Re: [PATCH] appletalk: Set skb with destructor
Date: Sat, 05 Jul 2014 20:28:21 +0000	[thread overview]
Message-ID: <20140705202821.GA25880@mwanda> (raw)
In-Reply-To: <1404534494-6253-1-git-send-email-andrey.krieger.utkin@gmail.com>

On Sat, Jul 05, 2014 at 07:28:14AM +0300, Andrey Utkin wrote:
> See https://bugzilla.kernel.org/show_bug.cgi?idy441
> ---8<---
> Made changes similar to 0ae89beb283a0db5980d1d4781c7d7be2f2810d6
> 

Thanks for fixing this bug but the patch description is just a URL and a
git hash.  Say something like:

The sock ref counting is off so there is a kernel panic when you run
`atalkd`.  See https://bugzilla.kernel.org/show_bug.cgi?idy441
This fix is similar to 0ae89beb283a ('can: add destructor for self
generated skbs')

--------------------------

Putting a little information directly in the changelog that it is about
refcounting and panics is a useful thing.

Also you need to send this to netdev@vger.kernel.org and CC
"David S. Miller" <davem@davemloft.net>.  Otherwise the patch looks good
to my non-expert eye.  Please resend to with the updated changelog and
CC list.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	acme@ghostprotocols.net
Subject: Re: [PATCH] appletalk: Set skb with destructor
Date: Sat, 5 Jul 2014 23:28:21 +0300	[thread overview]
Message-ID: <20140705202821.GA25880@mwanda> (raw)
In-Reply-To: <1404534494-6253-1-git-send-email-andrey.krieger.utkin@gmail.com>

On Sat, Jul 05, 2014 at 07:28:14AM +0300, Andrey Utkin wrote:
> See https://bugzilla.kernel.org/show_bug.cgi?id=79441
> ---8<---
> Made changes similar to 0ae89beb283a0db5980d1d4781c7d7be2f2810d6
> 

Thanks for fixing this bug but the patch description is just a URL and a
git hash.  Say something like:

The sock ref counting is off so there is a kernel panic when you run
`atalkd`.  See https://bugzilla.kernel.org/show_bug.cgi?id=79441
This fix is similar to 0ae89beb283a ('can: add destructor for self
generated skbs')

--------------------------

Putting a little information directly in the changelog that it is about
refcounting and panics is a useful thing.

Also you need to send this to netdev@vger.kernel.org and CC
"David S. Miller" <davem@davemloft.net>.  Otherwise the patch looks good
to my non-expert eye.  Please resend to with the updated changelog and
CC list.

regards,
dan carpenter


  reply	other threads:[~2014-07-05 20:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-05  4:28 [PATCH] appletalk: Set skb with destructor Andrey Utkin
2014-07-05  4:28 ` Andrey Utkin
2014-07-05 20:28 ` Dan Carpenter [this message]
2014-07-05 20:28   ` Dan Carpenter
2014-07-06 11:56   ` Andrey Utkin
2014-07-06 11:56     ` Andrey Utkin
2014-07-06 21:42     ` Eric Dumazet
2014-07-06 21:42       ` Eric Dumazet
2014-07-07  8:03       ` Andrey Utkin
2014-07-07  8:03         ` Andrey Utkin
2014-07-07  8:57         ` Eric Dumazet
2014-07-07  8:57           ` Eric Dumazet
2014-07-07  9:26           ` Eric Dumazet
2014-07-07  9:26             ` Eric Dumazet
2014-07-07 10:02             ` Andrey Utkin
2014-07-07 10:02               ` Andrey Utkin
2014-07-07 16:56               ` Eric Dumazet
2014-07-07 16:56                 ` Eric Dumazet
2014-07-07 18:57                 ` Andrey Utkin
2014-07-07 18:57                   ` Andrey Utkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140705202821.GA25880@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=acme@ghostprotocols.net \
    --cc=andrey.krieger.utkin@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.