All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sami Laine <laine.j.sami@gmail.com>
To: gregkh@linuxfoundation.org
Cc: gulsah.1004@gmail.com, Larry.Finger@lwfinger.net,
	linville@tuxdriver.com, paulmck@linux.vnet.ibm.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	trivial@kernel.org
Subject: [PATCH next-20140704]: staging/rtl8821ae/base.c: sparse warning corrections
Date: Sun, 6 Jul 2014 12:01:11 +0300	[thread overview]
Message-ID: <20140706090111.GA16760@acer> (raw)

From: Sami Laine <laine.j.sami@gmail.com>

Sparse warning corrections for:

drivers/staging/rtl8821ae/base.c:1370:16: warning: symbol 'rtl_make_smps_action' was not declared. Should it be static?
drivers/staging/rtl8821ae/base.c:1543:6: warning: symbol 'rtl_find_221_ie' was not declared. Should it be static?
drivers/staging/rtl8821ae/base.c:1804:5: warning: symbol 'rtl_core_module_init' was not declared. Should it be static?
drivers/staging/rtl8821ae/base.c:1820:6: warning: symbol 'rtl_core_module_exit' was not declared. Should it be static?

Signed-off-by: Sami Laine <laine.j.sami@gmail.com>
---
diff --git a/drivers/staging/rtl8821ae/base.c b/drivers/staging/rtl8821ae/base.c
index 4a36da0..c2d0b18 100644
--- a/drivers/staging/rtl8821ae/base.c
+++ b/drivers/staging/rtl8821ae/base.c
@@ -1367,7 +1367,7 @@ u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie)
 
 /* when we use 2 rx ants we send IEEE80211_SMPS_OFF */
 /* when we use 1 rx ant we send IEEE80211_SMPS_STATIC */
-struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
+static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
 				     enum ieee80211_smps_mode smps,
 				     u8 *da, u8 *bssid)
 {
@@ -1540,7 +1540,7 @@ static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw,
 	return matched;
 }
 
-bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
+static bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
 		unsigned int len)
 {
 	struct ieee80211_mgmt *mgmt = (void *)data;
@@ -1801,7 +1801,7 @@ MODULE_DESCRIPTION("Realtek 802.11n PCI wireless core");
 #endif
 struct rtl_global_var global_var = {};
 
-int rtl_core_module_init(void)
+static int rtl_core_module_init(void)
 {
 	if (rtl_rate_control_register())
 		printk(KERN_DEBUG "rtl: Unable to register rtl_rc, use default RC !!\n");
@@ -1815,8 +1815,9 @@ int rtl_core_module_init(void)
 
 	return 0;
 }
+EXPORT_SYMBOL(rtl_core_module_init);
 
-void rtl_core_module_exit(void)
+static void rtl_core_module_exit(void)
 {
 	/*RC*/
 	rtl_rate_control_unregister();
@@ -1824,6 +1825,7 @@ void rtl_core_module_exit(void)
 	/* add proc for debug */
 	rtl_proc_remove_topdir();
 }
+EXPORT_SYMBOL(rtl_core_module_exit);
 
 #if 0
 module_init(rtl_core_module_init);

             reply	other threads:[~2014-07-06  9:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-06  9:01 Sami Laine [this message]
2014-07-09 19:22 ` [PATCH next-20140704]: staging/rtl8821ae/base.c: sparse warning corrections Greg KH
2014-07-09 19:38 ` Andev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140706090111.GA16760@acer \
    --to=laine.j.sami@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gulsah.1004@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.