All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sami Laine <laine.j.sami@gmail.com>
Cc: devel@driverdev.osuosl.org, trivial@kernel.org,
	gulsah.1004@gmail.com, linville@tuxdriver.com,
	linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
	Larry.Finger@lwfinger.net
Subject: Re: [PATCH next-20140704]: staging/rtl8821ae/base.c: sparse warning corrections
Date: Wed, 9 Jul 2014 12:22:16 -0700	[thread overview]
Message-ID: <20140709192216.GA32205@kroah.com> (raw)
In-Reply-To: <20140706090111.GA16760@acer>

On Sun, Jul 06, 2014 at 12:01:11PM +0300, Sami Laine wrote:
> From: Sami Laine <laine.j.sami@gmail.com>
> 
> Sparse warning corrections for:
> 
> drivers/staging/rtl8821ae/base.c:1370:16: warning: symbol 'rtl_make_smps_action' was not declared. Should it be static?
> drivers/staging/rtl8821ae/base.c:1543:6: warning: symbol 'rtl_find_221_ie' was not declared. Should it be static?
> drivers/staging/rtl8821ae/base.c:1804:5: warning: symbol 'rtl_core_module_init' was not declared. Should it be static?
> drivers/staging/rtl8821ae/base.c:1820:6: warning: symbol 'rtl_core_module_exit' was not declared. Should it be static?
> 
> Signed-off-by: Sami Laine <laine.j.sami@gmail.com>

You obviously did not build the code with your patch applied, as it
breaks the build in bad ways :(

Please ALWAYS test your patches before sending them out...

greg k-h

  reply	other threads:[~2014-07-09 19:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-06  9:01 [PATCH next-20140704]: staging/rtl8821ae/base.c: sparse warning corrections Sami Laine
2014-07-09 19:22 ` Greg KH [this message]
2014-07-09 19:38 ` Andev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140709192216.GA32205@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gulsah.1004@gmail.com \
    --cc=laine.j.sami@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.