* [PATCH 0/2] staging: nvec: fix some coding style problems
@ 2014-07-05 20:30 ` Pawel Lebioda
0 siblings, 0 replies; 12+ messages in thread
From: Pawel Lebioda @ 2014-07-05 20:30 UTC (permalink / raw)
To: Julian Andres Klode, Marc Dietrich
Cc: Greg Kroah-Hartman, ac100, linux-tegra, devel, linux-kernel
The following patches fix some warnings reported by checkpatch.pl
Pawel Lebioda (2):
staging: nvec: remove unnecessary 'else' after 'return' statement
staging: nvec: remove unneccessary 'out of memory' message
drivers/staging/nvec/nvec.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
--
1.8.3.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] staging: nvec: remove unnecessary 'else' after 'return' statement
2014-07-05 20:30 ` Pawel Lebioda
@ 2014-07-05 20:30 ` Pawel Lebioda
-1 siblings, 0 replies; 12+ messages in thread
From: Pawel Lebioda @ 2014-07-05 20:30 UTC (permalink / raw)
To: Julian Andres Klode, Marc Dietrich
Cc: linux-tegra, Greg Kroah-Hartman, devel, linux-kernel, ac100
Fix the following warning reported by checkpatch.pl:
WARNING: else is not generally useful after a break or return
235: FILE: drivers/staging/nvec/nvec.c:235
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
---
drivers/staging/nvec/nvec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 90f1c4d..8a3dd47 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -232,8 +232,7 @@ static size_t nvec_msg_size(struct nvec_msg *msg)
return 2;
else if (event_length == NVEC_3BYTES)
return 3;
- else
- return 0;
+ return 0;
}
/**
--
1.8.3.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] staging: nvec: remove unnecessary 'else' after 'return' statement
@ 2014-07-05 20:30 ` Pawel Lebioda
0 siblings, 0 replies; 12+ messages in thread
From: Pawel Lebioda @ 2014-07-05 20:30 UTC (permalink / raw)
To: Julian Andres Klode, Marc Dietrich
Cc: Greg Kroah-Hartman, ac100, linux-tegra, devel, linux-kernel
Fix the following warning reported by checkpatch.pl:
WARNING: else is not generally useful after a break or return
235: FILE: drivers/staging/nvec/nvec.c:235
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
---
drivers/staging/nvec/nvec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 90f1c4d..8a3dd47 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -232,8 +232,7 @@ static size_t nvec_msg_size(struct nvec_msg *msg)
return 2;
else if (event_length == NVEC_3BYTES)
return 3;
- else
- return 0;
+ return 0;
}
/**
--
1.8.3.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] staging: nvec: remove unnecessary 'else' after 'return' statement
2014-07-05 20:30 ` Pawel Lebioda
@ 2014-07-07 5:53 ` Thierry Reding
-1 siblings, 0 replies; 12+ messages in thread
From: Thierry Reding @ 2014-07-07 5:53 UTC (permalink / raw)
To: Pawel Lebioda
Cc: devel, Julian Andres Klode, Greg Kroah-Hartman, linux-kernel,
linux-tegra, ac100
[-- Attachment #1.1: Type: text/plain, Size: 449 bytes --]
On Sat, Jul 05, 2014 at 10:30:55PM +0200, Pawel Lebioda wrote:
> Fix the following warning reported by checkpatch.pl:
>
> WARNING: else is not generally useful after a break or return
> 235: FILE: drivers/staging/nvec/nvec.c:235
>
> Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] staging: nvec: remove unnecessary 'else' after 'return' statement
@ 2014-07-07 5:53 ` Thierry Reding
0 siblings, 0 replies; 12+ messages in thread
From: Thierry Reding @ 2014-07-07 5:53 UTC (permalink / raw)
To: Pawel Lebioda
Cc: Julian Andres Klode, Marc Dietrich, Greg Kroah-Hartman, ac100,
linux-tegra, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
On Sat, Jul 05, 2014 at 10:30:55PM +0200, Pawel Lebioda wrote:
> Fix the following warning reported by checkpatch.pl:
>
> WARNING: else is not generally useful after a break or return
> 235: FILE: drivers/staging/nvec/nvec.c:235
>
> Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] staging: nvec: remove unneccessary 'out of memory' message
2014-07-05 20:30 ` Pawel Lebioda
@ 2014-07-05 20:30 ` Pawel Lebioda
-1 siblings, 0 replies; 12+ messages in thread
From: Pawel Lebioda @ 2014-07-05 20:30 UTC (permalink / raw)
To: Julian Andres Klode, Marc Dietrich
Cc: linux-tegra, Greg Kroah-Hartman, devel, linux-kernel, ac100
Fix the following warning reported by checkpatch.pl:
WARNING: Possible unnecessary 'out of memory' message
811: FILE: drivers/staging/nvec/nvec.c:811
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
---
drivers/staging/nvec/nvec.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 8a3dd47..d325048 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -806,10 +806,9 @@ static int tegra_nvec_probe(struct platform_device *pdev)
}
nvec = devm_kzalloc(&pdev->dev, sizeof(struct nvec_chip), GFP_KERNEL);
- if (nvec == NULL) {
- dev_err(&pdev->dev, "failed to reserve memory\n");
+ if (nvec == NULL)
return -ENOMEM;
- }
+
platform_set_drvdata(pdev, nvec);
nvec->dev = &pdev->dev;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] staging: nvec: remove unneccessary 'out of memory' message
@ 2014-07-05 20:30 ` Pawel Lebioda
0 siblings, 0 replies; 12+ messages in thread
From: Pawel Lebioda @ 2014-07-05 20:30 UTC (permalink / raw)
To: Julian Andres Klode, Marc Dietrich
Cc: Greg Kroah-Hartman, ac100, linux-tegra, devel, linux-kernel
Fix the following warning reported by checkpatch.pl:
WARNING: Possible unnecessary 'out of memory' message
811: FILE: drivers/staging/nvec/nvec.c:811
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
---
drivers/staging/nvec/nvec.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 8a3dd47..d325048 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -806,10 +806,9 @@ static int tegra_nvec_probe(struct platform_device *pdev)
}
nvec = devm_kzalloc(&pdev->dev, sizeof(struct nvec_chip), GFP_KERNEL);
- if (nvec == NULL) {
- dev_err(&pdev->dev, "failed to reserve memory\n");
+ if (nvec == NULL)
return -ENOMEM;
- }
+
platform_set_drvdata(pdev, nvec);
nvec->dev = &pdev->dev;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] staging: nvec: remove unneccessary 'out of memory' message
2014-07-05 20:30 ` Pawel Lebioda
@ 2014-07-07 5:53 ` Thierry Reding
-1 siblings, 0 replies; 12+ messages in thread
From: Thierry Reding @ 2014-07-07 5:53 UTC (permalink / raw)
To: Pawel Lebioda
Cc: devel, Julian Andres Klode, Greg Kroah-Hartman, linux-kernel,
linux-tegra, ac100
[-- Attachment #1.1: Type: text/plain, Size: 444 bytes --]
On Sat, Jul 05, 2014 at 10:30:56PM +0200, Pawel Lebioda wrote:
> Fix the following warning reported by checkpatch.pl:
>
> WARNING: Possible unnecessary 'out of memory' message
> 811: FILE: drivers/staging/nvec/nvec.c:811
>
> Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] staging: nvec: remove unneccessary 'out of memory' message
@ 2014-07-07 5:53 ` Thierry Reding
0 siblings, 0 replies; 12+ messages in thread
From: Thierry Reding @ 2014-07-07 5:53 UTC (permalink / raw)
To: Pawel Lebioda
Cc: Julian Andres Klode, Marc Dietrich, Greg Kroah-Hartman, ac100,
linux-tegra, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
On Sat, Jul 05, 2014 at 10:30:56PM +0200, Pawel Lebioda wrote:
> Fix the following warning reported by checkpatch.pl:
>
> WARNING: Possible unnecessary 'out of memory' message
> 811: FILE: drivers/staging/nvec/nvec.c:811
>
> Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] staging: nvec: fix some coding style problems
2014-07-05 20:30 ` Pawel Lebioda
@ 2014-07-06 8:26 ` Marc Dietrich
-1 siblings, 0 replies; 12+ messages in thread
From: Marc Dietrich @ 2014-07-06 8:26 UTC (permalink / raw)
To: Pawel Lebioda
Cc: devel, Julian Andres Klode, Greg Kroah-Hartman, linux-kernel,
linux-tegra, ac100
[-- Attachment #1.1: Type: text/plain, Size: 474 bytes --]
Hi Pawel,
Am Samstag, 5. Juli 2014, 22:30:54 schrieb Pawel Lebioda:
> The following patches fix some warnings reported by checkpatch.pl
>
> Pawel Lebioda (2):
> staging: nvec: remove unnecessary 'else' after 'return' statement
> staging: nvec: remove unneccessary 'out of memory' message
>
> drivers/staging/nvec/nvec.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
thanks for fixing, so for this series
Acked-by: Marc Dietrich <marvin24@gmx.de>
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] staging: nvec: fix some coding style problems
@ 2014-07-06 8:26 ` Marc Dietrich
0 siblings, 0 replies; 12+ messages in thread
From: Marc Dietrich @ 2014-07-06 8:26 UTC (permalink / raw)
To: Pawel Lebioda
Cc: Julian Andres Klode, Greg Kroah-Hartman, ac100, linux-tegra,
devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
Hi Pawel,
Am Samstag, 5. Juli 2014, 22:30:54 schrieb Pawel Lebioda:
> The following patches fix some warnings reported by checkpatch.pl
>
> Pawel Lebioda (2):
> staging: nvec: remove unnecessary 'else' after 'return' statement
> staging: nvec: remove unneccessary 'out of memory' message
>
> drivers/staging/nvec/nvec.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
thanks for fixing, so for this series
Acked-by: Marc Dietrich <marvin24@gmx.de>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread