From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mach-omap1: Fix call to omap_cfg_reg
Date: Mon, 7 Jul 2014 01:14:56 -0700 [thread overview]
Message-ID: <20140707081456.GH28884@atomide.com> (raw)
In-Reply-To: <1404493320-5606-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
* Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [140704 10:03]:
> This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
> that the cpu is a omap16xx and the nwires are not equal to 3.
This is most likely unsafe to do as the pin is probably
shared with some other device and we have to rely for
the bootloader to do the right thing for the board.
Regards,
Tony
> Signed-off-by: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/mach-omap1/usb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
> index 4118db5..17e3139 100644
> --- a/arch/arm/mach-omap1/usb.c
> +++ b/arch/arm/mach-omap1/usb.c
> @@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
> omap_cfg_reg(W9_USB2_TXEN);
> omap_cfg_reg(W5_USB2_SE0);
> if (nwires != 3)
> - omap_cfg_reg(Y5_USB2_RCV);
> - // FIXME omap_cfg_reg(USB2_SPEED);
> + omap_cfg_reg(USB2_SPEED)
> } else {
> pr_debug("usb%d cpu unrecognized\n", 1);
> return 0;
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-omap1: Fix call to omap_cfg_reg
Date: Mon, 7 Jul 2014 01:14:56 -0700 [thread overview]
Message-ID: <20140707081456.GH28884@atomide.com> (raw)
In-Reply-To: <1404493320-5606-1-git-send-email-xerofoify@gmail.com>
* Nicholas Krause <xerofoify@gmail.com> [140704 10:03]:
> This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
> that the cpu is a omap16xx and the nwires are not equal to 3.
This is most likely unsafe to do as the pin is probably
shared with some other device and we have to rely for
the bootloader to do the right thing for the board.
Regards,
Tony
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/arm/mach-omap1/usb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
> index 4118db5..17e3139 100644
> --- a/arch/arm/mach-omap1/usb.c
> +++ b/arch/arm/mach-omap1/usb.c
> @@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
> omap_cfg_reg(W9_USB2_TXEN);
> omap_cfg_reg(W5_USB2_SE0);
> if (nwires != 3)
> - omap_cfg_reg(Y5_USB2_RCV);
> - // FIXME omap_cfg_reg(USB2_SPEED);
> + omap_cfg_reg(USB2_SPEED)
> } else {
> pr_debug("usb%d cpu unrecognized\n", 1);
> return 0;
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: balbi@ti.com, linux@arm.linux.org.uk, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mach-omap1: Fix call to omap_cfg_reg
Date: Mon, 7 Jul 2014 01:14:56 -0700 [thread overview]
Message-ID: <20140707081456.GH28884@atomide.com> (raw)
In-Reply-To: <1404493320-5606-1-git-send-email-xerofoify@gmail.com>
* Nicholas Krause <xerofoify@gmail.com> [140704 10:03]:
> This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
> that the cpu is a omap16xx and the nwires are not equal to 3.
This is most likely unsafe to do as the pin is probably
shared with some other device and we have to rely for
the bootloader to do the right thing for the board.
Regards,
Tony
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/arm/mach-omap1/usb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
> index 4118db5..17e3139 100644
> --- a/arch/arm/mach-omap1/usb.c
> +++ b/arch/arm/mach-omap1/usb.c
> @@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
> omap_cfg_reg(W9_USB2_TXEN);
> omap_cfg_reg(W5_USB2_SE0);
> if (nwires != 3)
> - omap_cfg_reg(Y5_USB2_RCV);
> - // FIXME omap_cfg_reg(USB2_SPEED);
> + omap_cfg_reg(USB2_SPEED)
> } else {
> pr_debug("usb%d cpu unrecognized\n", 1);
> return 0;
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-07-07 8:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 17:02 [PATCH] mach-omap1: Fix call to omap_cfg_reg Nicholas Krause
2014-07-04 17:02 ` Nicholas Krause
[not found] ` <1404493320-5606-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-07 8:14 ` Tony Lindgren [this message]
2014-07-07 8:14 ` Tony Lindgren
2014-07-07 8:14 ` Tony Lindgren
2014-07-07 17:40 ` Nick Krause
2014-07-07 17:40 ` Nick Krause
2014-07-08 8:10 ` Tony Lindgren
2014-07-08 8:10 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707081456.GH28884@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.