* [PATCH] ARM: DRA7/AM43XX: fix header definition for omap44xx_restart
@ 2014-05-16 22:36 ` Nishanth Menon
0 siblings, 0 replies; 4+ messages in thread
From: Nishanth Menon @ 2014-05-16 22:36 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-arm-kernel, linux-omap, Nishanth Menon
omap44xx_restart is defined as a static void inline when DRA7/AM437X is
defined alone, which implies that the restart function is no longer
functional even though it is built in. So, fix the definition of the
same.
Unfortunately, the number of SoCs starting to use omap44xx_restart is
starting to grow and the definition looks a little ugly.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
based on v3.15-rc5
NOTE: this generates over 80 characters checkpatch warning.. I am not
sure other than introducing a definition for restart it could be simplified.
arch/arm/mach-omap2/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h
index d88aff7..46150f4 100644
--- a/arch/arm/mach-omap2/common.h
+++ b/arch/arm/mach-omap2/common.h
@@ -154,7 +154,7 @@ static inline void omap3xxx_restart(enum reboot_mode mode, const char *cmd)
}
#endif
-#if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5)
+#if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5) || defined(CONFIG_SOC_DRA7XX) || defined(CONFIG_SOC_AM43XX)
void omap44xx_restart(enum reboot_mode mode, const char *cmd);
#else
static inline void omap44xx_restart(enum reboot_mode mode, const char *cmd)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: DRA7/AM43XX: fix header definition for omap44xx_restart
@ 2014-05-16 22:36 ` Nishanth Menon
0 siblings, 0 replies; 4+ messages in thread
From: Nishanth Menon @ 2014-05-16 22:36 UTC (permalink / raw)
To: linux-arm-kernel
omap44xx_restart is defined as a static void inline when DRA7/AM437X is
defined alone, which implies that the restart function is no longer
functional even though it is built in. So, fix the definition of the
same.
Unfortunately, the number of SoCs starting to use omap44xx_restart is
starting to grow and the definition looks a little ugly.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
based on v3.15-rc5
NOTE: this generates over 80 characters checkpatch warning.. I am not
sure other than introducing a definition for restart it could be simplified.
arch/arm/mach-omap2/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h
index d88aff7..46150f4 100644
--- a/arch/arm/mach-omap2/common.h
+++ b/arch/arm/mach-omap2/common.h
@@ -154,7 +154,7 @@ static inline void omap3xxx_restart(enum reboot_mode mode, const char *cmd)
}
#endif
-#if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5)
+#if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5) || defined(CONFIG_SOC_DRA7XX) || defined(CONFIG_SOC_AM43XX)
void omap44xx_restart(enum reboot_mode mode, const char *cmd);
#else
static inline void omap44xx_restart(enum reboot_mode mode, const char *cmd)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: DRA7/AM43XX: fix header definition for omap44xx_restart
2014-05-16 22:36 ` Nishanth Menon
@ 2014-07-07 11:44 ` Tony Lindgren
-1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2014-07-07 11:44 UTC (permalink / raw)
To: Nishanth Menon; +Cc: linux-arm-kernel, linux-omap
* Nishanth Menon <nm@ti.com> [140516 15:37]:
> omap44xx_restart is defined as a static void inline when DRA7/AM437X is
> defined alone, which implies that the restart function is no longer
> functional even though it is built in. So, fix the definition of the
> same.
>
> Unfortunately, the number of SoCs starting to use omap44xx_restart is
> starting to grow and the definition looks a little ugly.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> based on v3.15-rc5
>
> NOTE: this generates over 80 characters checkpatch warning.. I am not
> sure other than introducing a definition for restart it could be simplified.
Sorry found this still pending so applying into omap-for-v3.16/fixes.
Regards,
Tony
> arch/arm/mach-omap2/common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h
> index d88aff7..46150f4 100644
> --- a/arch/arm/mach-omap2/common.h
> +++ b/arch/arm/mach-omap2/common.h
> @@ -154,7 +154,7 @@ static inline void omap3xxx_restart(enum reboot_mode mode, const char *cmd)
> }
> #endif
>
> -#if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5)
> +#if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5) || defined(CONFIG_SOC_DRA7XX) || defined(CONFIG_SOC_AM43XX)
> void omap44xx_restart(enum reboot_mode mode, const char *cmd);
> #else
> static inline void omap44xx_restart(enum reboot_mode mode, const char *cmd)
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: DRA7/AM43XX: fix header definition for omap44xx_restart
@ 2014-07-07 11:44 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2014-07-07 11:44 UTC (permalink / raw)
To: linux-arm-kernel
* Nishanth Menon <nm@ti.com> [140516 15:37]:
> omap44xx_restart is defined as a static void inline when DRA7/AM437X is
> defined alone, which implies that the restart function is no longer
> functional even though it is built in. So, fix the definition of the
> same.
>
> Unfortunately, the number of SoCs starting to use omap44xx_restart is
> starting to grow and the definition looks a little ugly.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> based on v3.15-rc5
>
> NOTE: this generates over 80 characters checkpatch warning.. I am not
> sure other than introducing a definition for restart it could be simplified.
Sorry found this still pending so applying into omap-for-v3.16/fixes.
Regards,
Tony
> arch/arm/mach-omap2/common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h
> index d88aff7..46150f4 100644
> --- a/arch/arm/mach-omap2/common.h
> +++ b/arch/arm/mach-omap2/common.h
> @@ -154,7 +154,7 @@ static inline void omap3xxx_restart(enum reboot_mode mode, const char *cmd)
> }
> #endif
>
> -#if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5)
> +#if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5) || defined(CONFIG_SOC_DRA7XX) || defined(CONFIG_SOC_AM43XX)
> void omap44xx_restart(enum reboot_mode mode, const char *cmd);
> #else
> static inline void omap44xx_restart(enum reboot_mode mode, const char *cmd)
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-07 11:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-16 22:36 [PATCH] ARM: DRA7/AM43XX: fix header definition for omap44xx_restart Nishanth Menon
2014-05-16 22:36 ` Nishanth Menon
2014-07-07 11:44 ` Tony Lindgren
2014-07-07 11:44 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.