* [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once
@ 2014-06-25 12:28 ` Rickard Strandqvist
0 siblings, 0 replies; 9+ messages in thread
From: Rickard Strandqvist @ 2014-06-25 12:28 UTC (permalink / raw)
To: Felipe Balbi, Tony Lindgren
Cc: Rickard Strandqvist, Russell King,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
A struct member variable is set to the same value more than once
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
---
arch/arm/mach-omap2/usb-tusb6010.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb-tusb6010.c
index e832bc7..8333400 100644
--- a/arch/arm/mach-omap2/usb-tusb6010.c
+++ b/arch/arm/mach-omap2/usb-tusb6010.c
@@ -95,7 +95,6 @@ static int tusb_set_sync_mode(unsigned sysclk_ps)
dev_t.t_avdp_w = t_scsnh_advnh;
dev_t.cyc_aavdh_we = 3;
dev_t.cyc_wpl = 6;
- dev_t.t_ce_rdyz = 7000;
gpmc_calc_timings(&t, &tusb_sync, &dev_t);
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once
@ 2014-06-25 12:28 ` Rickard Strandqvist
0 siblings, 0 replies; 9+ messages in thread
From: Rickard Strandqvist @ 2014-06-25 12:28 UTC (permalink / raw)
To: Felipe Balbi, Tony Lindgren
Cc: Rickard Strandqvist, Russell King, linux-usb, linux-omap,
linux-arm-kernel, linux-kernel
A struct member variable is set to the same value more than once
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/arm/mach-omap2/usb-tusb6010.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb-tusb6010.c
index e832bc7..8333400 100644
--- a/arch/arm/mach-omap2/usb-tusb6010.c
+++ b/arch/arm/mach-omap2/usb-tusb6010.c
@@ -95,7 +95,6 @@ static int tusb_set_sync_mode(unsigned sysclk_ps)
dev_t.t_avdp_w = t_scsnh_advnh;
dev_t.cyc_aavdh_we = 3;
dev_t.cyc_wpl = 6;
- dev_t.t_ce_rdyz = 7000;
gpmc_calc_timings(&t, &tusb_sync, &dev_t);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once
@ 2014-06-25 12:28 ` Rickard Strandqvist
0 siblings, 0 replies; 9+ messages in thread
From: Rickard Strandqvist @ 2014-06-25 12:28 UTC (permalink / raw)
To: linux-arm-kernel
A struct member variable is set to the same value more than once
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/arm/mach-omap2/usb-tusb6010.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb-tusb6010.c
index e832bc7..8333400 100644
--- a/arch/arm/mach-omap2/usb-tusb6010.c
+++ b/arch/arm/mach-omap2/usb-tusb6010.c
@@ -95,7 +95,6 @@ static int tusb_set_sync_mode(unsigned sysclk_ps)
dev_t.t_avdp_w = t_scsnh_advnh;
dev_t.cyc_aavdh_we = 3;
dev_t.cyc_wpl = 6;
- dev_t.t_ce_rdyz = 7000;
gpmc_calc_timings(&t, &tusb_sync, &dev_t);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once
2014-06-25 12:28 ` Rickard Strandqvist
(?)
@ 2014-06-27 15:57 ` Felipe Balbi
-1 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2014-06-27 15:57 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Felipe Balbi, Tony Lindgren, Russell King, linux-usb, linux-omap,
linux-arm-kernel, linux-kernel, Roger Quadros
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On Wed, Jun 25, 2014 at 02:28:30PM +0200, Rickard Strandqvist wrote:
> A struct member variable is set to the same value more than once
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
I think there was a bigger series from Roger rewriting most of this, but
if I'm mistaken:
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/mach-omap2/usb-tusb6010.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb-tusb6010.c
> index e832bc7..8333400 100644
> --- a/arch/arm/mach-omap2/usb-tusb6010.c
> +++ b/arch/arm/mach-omap2/usb-tusb6010.c
> @@ -95,7 +95,6 @@ static int tusb_set_sync_mode(unsigned sysclk_ps)
> dev_t.t_avdp_w = t_scsnh_advnh;
> dev_t.cyc_aavdh_we = 3;
> dev_t.cyc_wpl = 6;
> - dev_t.t_ce_rdyz = 7000;
>
> gpmc_calc_timings(&t, &tusb_sync, &dev_t);
>
> --
> 1.7.10.4
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once
@ 2014-06-27 15:57 ` Felipe Balbi
0 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2014-06-27 15:57 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Felipe Balbi, Tony Lindgren, Russell King, linux-usb, linux-omap,
linux-arm-kernel, linux-kernel, Roger Quadros
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On Wed, Jun 25, 2014 at 02:28:30PM +0200, Rickard Strandqvist wrote:
> A struct member variable is set to the same value more than once
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
I think there was a bigger series from Roger rewriting most of this, but
if I'm mistaken:
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/mach-omap2/usb-tusb6010.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb-tusb6010.c
> index e832bc7..8333400 100644
> --- a/arch/arm/mach-omap2/usb-tusb6010.c
> +++ b/arch/arm/mach-omap2/usb-tusb6010.c
> @@ -95,7 +95,6 @@ static int tusb_set_sync_mode(unsigned sysclk_ps)
> dev_t.t_avdp_w = t_scsnh_advnh;
> dev_t.cyc_aavdh_we = 3;
> dev_t.cyc_wpl = 6;
> - dev_t.t_ce_rdyz = 7000;
>
> gpmc_calc_timings(&t, &tusb_sync, &dev_t);
>
> --
> 1.7.10.4
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once
@ 2014-06-27 15:57 ` Felipe Balbi
0 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2014-06-27 15:57 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 25, 2014 at 02:28:30PM +0200, Rickard Strandqvist wrote:
> A struct member variable is set to the same value more than once
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
I think there was a bigger series from Roger rewriting most of this, but
if I'm mistaken:
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/mach-omap2/usb-tusb6010.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb-tusb6010.c
> index e832bc7..8333400 100644
> --- a/arch/arm/mach-omap2/usb-tusb6010.c
> +++ b/arch/arm/mach-omap2/usb-tusb6010.c
> @@ -95,7 +95,6 @@ static int tusb_set_sync_mode(unsigned sysclk_ps)
> dev_t.t_avdp_w = t_scsnh_advnh;
> dev_t.cyc_aavdh_we = 3;
> dev_t.cyc_wpl = 6;
> - dev_t.t_ce_rdyz = 7000;
>
> gpmc_calc_timings(&t, &tusb_sync, &dev_t);
>
> --
> 1.7.10.4
>
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140627/71396a49/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <1403699310-22960-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>]
* Re: [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once
2014-06-25 12:28 ` Rickard Strandqvist
(?)
@ 2014-07-07 11:53 ` Tony Lindgren
-1 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2014-07-07 11:53 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Felipe Balbi, Russell King, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
* Rickard Strandqvist <rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org> [140625 05:29]:
> A struct member variable is set to the same value more than once
>
> This was found using a static code analysis program called cppcheck.
Applying into omap-for-v3.17/fixes-not-urgent thanks.
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-07-07 11:53 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-25 12:28 [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once Rickard Strandqvist
2014-06-25 12:28 ` Rickard Strandqvist
2014-06-25 12:28 ` Rickard Strandqvist
2014-06-27 15:57 ` Felipe Balbi
2014-06-27 15:57 ` Felipe Balbi
2014-06-27 15:57 ` Felipe Balbi
[not found] ` <1403699310-22960-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
2014-07-07 11:53 ` Tony Lindgren
2014-07-07 11:53 ` Tony Lindgren
2014-07-07 11:53 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.