All of lore.kernel.org
 help / color / mirror / Atom feed
From: John W. Linville <linville@tuxdriver.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Arend van Spriel <arend@broadcom.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	b43-dev <b43-dev@lists.infradead.org>
Subject: [PATCH] bcma: support for PCIe Gen 2 as host platform
Date: Mon, 7 Jul 2014 16:48:46 -0400	[thread overview]
Message-ID: <20140707204846.GF29650@tuxdriver.com> (raw)
In-Reply-To: <CACna6rwQmW6AX3BwfE5Q_MkcJ1UWMeeJ1VXXqxATH1oX15Zgkg@mail.gmail.com>

On Mon, Jul 07, 2014 at 09:37:10PM +0200, Rafa? Mi?ecki wrote:
> On 7 July 2014 11:38, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> > On 6 July 2014 14:19, Arend van Spriel <arend@broadcom.com> wrote:
> >> On 06-07-14 13:11, Rafa? Mi?ecki wrote:
> >>> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> >>> ---
> >>> I got reply from Bjorn, that we should *not* depend on PCI_EXP_LNKCAP:
> >>> http://marc.info/?l=linux-pci&m=140457671930896&w=2
> >>>
> >>> So the change since RFC is adding a list of PCIe 1.0 and 2.0 devices.
> >>> Use PCI_EXP_LNKCAP only as a fallback, in case someone tries sth like:
> >>> echo "14e4 4360" > /sys/bus/pci/drivers/bcma-pci-bridge/new_id
> >>
> >> Do you have to know this before or after enumerating the cores? They
> >> have a different core id, right?
> >
> > Sure, having a list of cores would allow me to determine PCIe revision.
> >
> > Unfortunately right now we have only this single bcma_bus_register
> > call that does both: scanning and initialization. I'd need to first
> > scan cores, then determine PCIe revision and finally initialize cores.
> >
> > I wonder if I could try to use bcma_bus_scan_early that was developer
> > for SoC needs...
> 
> John: please kindly drop this patch for now. All other bcma/b43
> patches are unaffected.

OK

-- 
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.

WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Arend van Spriel <arend@broadcom.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	b43-dev <b43-dev@lists.infradead.org>
Subject: Re: [PATCH] bcma: support for PCIe Gen 2 as host platform
Date: Mon, 7 Jul 2014 16:48:46 -0400	[thread overview]
Message-ID: <20140707204846.GF29650@tuxdriver.com> (raw)
In-Reply-To: <CACna6rwQmW6AX3BwfE5Q_MkcJ1UWMeeJ1VXXqxATH1oX15Zgkg@mail.gmail.com>

On Mon, Jul 07, 2014 at 09:37:10PM +0200, Rafał Miłecki wrote:
> On 7 July 2014 11:38, Rafał Miłecki <zajec5@gmail.com> wrote:
> > On 6 July 2014 14:19, Arend van Spriel <arend@broadcom.com> wrote:
> >> On 06-07-14 13:11, Rafał Miłecki wrote:
> >>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> >>> ---
> >>> I got reply from Bjorn, that we should *not* depend on PCI_EXP_LNKCAP:
> >>> http://marc.info/?l=linux-pci&m=140457671930896&w=2
> >>>
> >>> So the change since RFC is adding a list of PCIe 1.0 and 2.0 devices.
> >>> Use PCI_EXP_LNKCAP only as a fallback, in case someone tries sth like:
> >>> echo "14e4 4360" > /sys/bus/pci/drivers/bcma-pci-bridge/new_id
> >>
> >> Do you have to know this before or after enumerating the cores? They
> >> have a different core id, right?
> >
> > Sure, having a list of cores would allow me to determine PCIe revision.
> >
> > Unfortunately right now we have only this single bcma_bus_register
> > call that does both: scanning and initialization. I'd need to first
> > scan cores, then determine PCIe revision and finally initialize cores.
> >
> > I wonder if I could try to use bcma_bus_scan_early that was developer
> > for SoC needs...
> 
> John: please kindly drop this patch for now. All other bcma/b43
> patches are unaffected.

OK

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2014-07-07 20:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-06 11:11 [PATCH] bcma: support for PCIe Gen 2 as host platform Rafał Miłecki
2014-07-06 11:11 ` Rafał Miłecki
2014-07-06 12:19 ` Arend van Spriel
2014-07-06 12:19   ` Arend van Spriel
2014-07-07  9:38   ` Rafał Miłecki
2014-07-07  9:38     ` Rafał Miłecki
2014-07-07 19:37     ` Rafał Miłecki
2014-07-07 19:37       ` Rafał Miłecki
2014-07-07 20:48       ` John W. Linville [this message]
2014-07-07 20:48         ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140707204846.GF29650@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=arend@broadcom.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.