Re: [PATCH] drm: Remove command line guard for render nodes

[Matt Roper <matthew.d.roper@intel.com>]

On Mon, Jul 07, 2014 at 05:25:05PM -0400, Alex Deucher wrote:
> Render nodes are ready to leave the experimental state so
> drop the kernel command line parameter which was hiding them
> by default.  I swore we had already enabled these by default,
> that appears to not be the case.
> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/drm_stub.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
> index 14d1646..0df920b 100644
> --- a/drivers/gpu/drm/drm_stub.c
> +++ b/drivers/gpu/drm/drm_stub.c
> @@ -37,9 +37,6 @@
>  unsigned int drm_debug = 0;	/* 1 to enable debug output */
>  EXPORT_SYMBOL(drm_debug);
>  
> -unsigned int drm_rnodes = 0;	/* 1 to enable experimental render nodes API */
> -EXPORT_SYMBOL(drm_rnodes);
> -
>  /* 1 to allow user space to request universal planes (experimental) */
>  unsigned int drm_universal_planes = 0;
>  EXPORT_SYMBOL(drm_universal_planes);
> @@ -66,7 +63,6 @@ MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]");

I believe there's a MODULE_PARM_DESC() line for rnodes a couple lines
above the context shown here that you'll also want to remove.


Matt

>  MODULE_PARM_DESC(timestamp_monotonic, "Use monotonic timestamps");
>  
>  module_param_named(debug, drm_debug, int, 0600);
> -module_param_named(rnodes, drm_rnodes, int, 0600);
>  module_param_named(universal_planes, drm_universal_planes, int, 0600);
>  module_param_named(vblankoffdelay, drm_vblank_offdelay, int, 0600);
>  module_param_named(timestamp_precision_usec, drm_timestamp_precision, int, 0600);
> @@ -588,7 +584,7 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver,
>  			goto err_minors;
>  	}
>  
> -	if (drm_core_check_feature(dev, DRIVER_RENDER) && drm_rnodes) {
> +	if (drm_core_check_feature(dev, DRIVER_RENDER)) {
>  		ret = drm_minor_alloc(dev, DRM_MINOR_RENDER);
>  		if (ret)
>  			goto err_minors;
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795