* [PATCH] drm: Remove command line guard for render nodes
@ 2014-07-07 21:25 Alex Deucher
2014-07-07 22:07 ` Matt Roper
2014-07-07 22:18 ` David Herrmann
0 siblings, 2 replies; 3+ messages in thread
From: Alex Deucher @ 2014-07-07 21:25 UTC (permalink / raw)
To: dri-devel; +Cc: Alex Deucher
Render nodes are ready to leave the experimental state so
drop the kernel command line parameter which was hiding them
by default. I swore we had already enabled these by default,
that appears to not be the case.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/drm_stub.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
index 14d1646..0df920b 100644
--- a/drivers/gpu/drm/drm_stub.c
+++ b/drivers/gpu/drm/drm_stub.c
@@ -37,9 +37,6 @@
unsigned int drm_debug = 0; /* 1 to enable debug output */
EXPORT_SYMBOL(drm_debug);
-unsigned int drm_rnodes = 0; /* 1 to enable experimental render nodes API */
-EXPORT_SYMBOL(drm_rnodes);
-
/* 1 to allow user space to request universal planes (experimental) */
unsigned int drm_universal_planes = 0;
EXPORT_SYMBOL(drm_universal_planes);
@@ -66,7 +63,6 @@ MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]");
MODULE_PARM_DESC(timestamp_monotonic, "Use monotonic timestamps");
module_param_named(debug, drm_debug, int, 0600);
-module_param_named(rnodes, drm_rnodes, int, 0600);
module_param_named(universal_planes, drm_universal_planes, int, 0600);
module_param_named(vblankoffdelay, drm_vblank_offdelay, int, 0600);
module_param_named(timestamp_precision_usec, drm_timestamp_precision, int, 0600);
@@ -588,7 +584,7 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver,
goto err_minors;
}
- if (drm_core_check_feature(dev, DRIVER_RENDER) && drm_rnodes) {
+ if (drm_core_check_feature(dev, DRIVER_RENDER)) {
ret = drm_minor_alloc(dev, DRM_MINOR_RENDER);
if (ret)
goto err_minors;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm: Remove command line guard for render nodes
2014-07-07 21:25 [PATCH] drm: Remove command line guard for render nodes Alex Deucher
@ 2014-07-07 22:07 ` Matt Roper
2014-07-07 22:18 ` David Herrmann
1 sibling, 0 replies; 3+ messages in thread
From: Matt Roper @ 2014-07-07 22:07 UTC (permalink / raw)
To: Alex Deucher; +Cc: Alex Deucher, dri-devel
On Mon, Jul 07, 2014 at 05:25:05PM -0400, Alex Deucher wrote:
> Render nodes are ready to leave the experimental state so
> drop the kernel command line parameter which was hiding them
> by default. I swore we had already enabled these by default,
> that appears to not be the case.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/drm_stub.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
> index 14d1646..0df920b 100644
> --- a/drivers/gpu/drm/drm_stub.c
> +++ b/drivers/gpu/drm/drm_stub.c
> @@ -37,9 +37,6 @@
> unsigned int drm_debug = 0; /* 1 to enable debug output */
> EXPORT_SYMBOL(drm_debug);
>
> -unsigned int drm_rnodes = 0; /* 1 to enable experimental render nodes API */
> -EXPORT_SYMBOL(drm_rnodes);
> -
> /* 1 to allow user space to request universal planes (experimental) */
> unsigned int drm_universal_planes = 0;
> EXPORT_SYMBOL(drm_universal_planes);
> @@ -66,7 +63,6 @@ MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]");
I believe there's a MODULE_PARM_DESC() line for rnodes a couple lines
above the context shown here that you'll also want to remove.
Matt
> MODULE_PARM_DESC(timestamp_monotonic, "Use monotonic timestamps");
>
> module_param_named(debug, drm_debug, int, 0600);
> -module_param_named(rnodes, drm_rnodes, int, 0600);
> module_param_named(universal_planes, drm_universal_planes, int, 0600);
> module_param_named(vblankoffdelay, drm_vblank_offdelay, int, 0600);
> module_param_named(timestamp_precision_usec, drm_timestamp_precision, int, 0600);
> @@ -588,7 +584,7 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver,
> goto err_minors;
> }
>
> - if (drm_core_check_feature(dev, DRIVER_RENDER) && drm_rnodes) {
> + if (drm_core_check_feature(dev, DRIVER_RENDER)) {
> ret = drm_minor_alloc(dev, DRM_MINOR_RENDER);
> if (ret)
> goto err_minors;
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: Remove command line guard for render nodes
2014-07-07 21:25 [PATCH] drm: Remove command line guard for render nodes Alex Deucher
2014-07-07 22:07 ` Matt Roper
@ 2014-07-07 22:18 ` David Herrmann
1 sibling, 0 replies; 3+ messages in thread
From: David Herrmann @ 2014-07-07 22:18 UTC (permalink / raw)
To: Alex Deucher, Dave Airlie; +Cc: Alex Deucher, dri-devel@lists.freedesktop.org
Hi
On Mon, Jul 7, 2014 at 11:25 PM, Alex Deucher <alexdeucher@gmail.com> wrote:
> Render nodes are ready to leave the experimental state so
> drop the kernel command line parameter which was hiding them
> by default. I swore we had already enabled these by default,
> that appears to not be the case.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
I did send this for 3.15 but it was never applied. I have it still
queued on my -next branch and Dave said he'll probably take it for the
next release. I will include it in my next pull request [1].
Thanks
David
[1] http://cgit.freedesktop.org/~dvdhrm/linux/log/?h=drm-next
> ---
> drivers/gpu/drm/drm_stub.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
> index 14d1646..0df920b 100644
> --- a/drivers/gpu/drm/drm_stub.c
> +++ b/drivers/gpu/drm/drm_stub.c
> @@ -37,9 +37,6 @@
> unsigned int drm_debug = 0; /* 1 to enable debug output */
> EXPORT_SYMBOL(drm_debug);
>
> -unsigned int drm_rnodes = 0; /* 1 to enable experimental render nodes API */
> -EXPORT_SYMBOL(drm_rnodes);
> -
> /* 1 to allow user space to request universal planes (experimental) */
> unsigned int drm_universal_planes = 0;
> EXPORT_SYMBOL(drm_universal_planes);
> @@ -66,7 +63,6 @@ MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]");
> MODULE_PARM_DESC(timestamp_monotonic, "Use monotonic timestamps");
>
> module_param_named(debug, drm_debug, int, 0600);
> -module_param_named(rnodes, drm_rnodes, int, 0600);
> module_param_named(universal_planes, drm_universal_planes, int, 0600);
> module_param_named(vblankoffdelay, drm_vblank_offdelay, int, 0600);
> module_param_named(timestamp_precision_usec, drm_timestamp_precision, int, 0600);
> @@ -588,7 +584,7 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver,
> goto err_minors;
> }
>
> - if (drm_core_check_feature(dev, DRIVER_RENDER) && drm_rnodes) {
> + if (drm_core_check_feature(dev, DRIVER_RENDER)) {
> ret = drm_minor_alloc(dev, DRM_MINOR_RENDER);
> if (ret)
> goto err_minors;
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-07 22:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-07 21:25 [PATCH] drm: Remove command line guard for render nodes Alex Deucher
2014-07-07 22:07 ` Matt Roper
2014-07-07 22:18 ` David Herrmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.