From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: topology: Use a clock if possible to get the CPU frequency
Date: Tue, 8 Jul 2014 09:39:40 +0200 [thread overview]
Message-ID: <20140708073940.GH13423@lukather> (raw)
In-Reply-To: <CAKfTPtBPR9QA9h4bF3EkCZufpF+X84N7JzjU88CptR1RtiNrdg@mail.gmail.com>
On Fri, Jul 04, 2014 at 11:22:33AM +0200, Vincent Guittot wrote:
> >> I still think that using the current rate with clk_get_rate is not a
> >> good solution.
> >
> > Well, it's just as good as using clock-frequency, really. If you want
> > the CPU max frequency, it's not the right property (plus, since the
> > changed behaviour is not documented in Linux anywhere, the only
> > reference we have is the ePAPR on this).
> >
> >> Could you give us more details about why you nee to use current clock ?
> >
> > Honestly, I just want to remove that big warning at boot on the
> > A7-based SoCs we have :)
>
> so Why not changing the log message ? It's clearly not an error to not
> have clock-frequency
Because the next SoCs we're going to support will be HMP, so we're
only delaying the issue by a few month if we're doing so.
It doesn't fix the underlying issue where you're using a standard
property for a (slightly) different usage.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140708/32eb41b8/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Vincent Guittot
<vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Russell King - ARM Linux
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
LAK
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Nicolas Pitre <nico-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2 1/2] ARM: topology: Use a clock if possible to get the CPU frequency
Date: Tue, 8 Jul 2014 09:39:40 +0200 [thread overview]
Message-ID: <20140708073940.GH13423@lukather> (raw)
In-Reply-To: <CAKfTPtBPR9QA9h4bF3EkCZufpF+X84N7JzjU88CptR1RtiNrdg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
On Fri, Jul 04, 2014 at 11:22:33AM +0200, Vincent Guittot wrote:
> >> I still think that using the current rate with clk_get_rate is not a
> >> good solution.
> >
> > Well, it's just as good as using clock-frequency, really. If you want
> > the CPU max frequency, it's not the right property (plus, since the
> > changed behaviour is not documented in Linux anywhere, the only
> > reference we have is the ePAPR on this).
> >
> >> Could you give us more details about why you nee to use current clock ?
> >
> > Honestly, I just want to remove that big warning at boot on the
> > A7-based SoCs we have :)
>
> so Why not changing the log message ? It's clearly not an error to not
> have clock-frequency
Because the next SoCs we're going to support will be HMP, so we're
only delaying the issue by a few month if we're doing so.
It doesn't fix the underlying issue where you're using a standard
property for a (slightly) different usage.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-08 7:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 10:12 [PATCH v2 0/2] ARM: topology: Allow to set the frequency through a clock Maxime Ripard
2014-06-30 10:12 ` Maxime Ripard
2014-06-30 10:12 ` [PATCH v2 1/2] ARM: topology: Use a clock if possible to get the CPU frequency Maxime Ripard
2014-06-30 10:12 ` Maxime Ripard
2014-06-30 10:29 ` Russell King - ARM Linux
2014-06-30 10:29 ` Russell King - ARM Linux
2014-06-30 10:39 ` Vincent Guittot
2014-06-30 10:39 ` Vincent Guittot
2014-06-30 12:49 ` Maxime Ripard
2014-06-30 12:49 ` Maxime Ripard
2014-06-30 13:27 ` Vincent Guittot
2014-06-30 13:27 ` Vincent Guittot
2014-06-30 14:01 ` Maxime Ripard
2014-06-30 14:01 ` Maxime Ripard
2014-06-30 14:48 ` Vincent Guittot
2014-06-30 14:48 ` Vincent Guittot
2014-06-30 14:58 ` Maxime Ripard
2014-06-30 14:58 ` Maxime Ripard
2014-06-30 15:06 ` Vincent Guittot
2014-06-30 15:06 ` Vincent Guittot
2014-07-03 7:10 ` Maxime Ripard
2014-07-03 7:10 ` Maxime Ripard
2014-07-03 7:51 ` Vincent Guittot
2014-07-03 7:51 ` Vincent Guittot
2014-07-04 8:02 ` Maxime Ripard
2014-07-04 8:02 ` Maxime Ripard
2014-07-04 9:22 ` Vincent Guittot
2014-07-04 9:22 ` Vincent Guittot
2014-07-08 7:39 ` Maxime Ripard [this message]
2014-07-08 7:39 ` Maxime Ripard
2014-06-30 10:12 ` [PATCH v2 2/2] ARM: sunxi: Add clocks node to the CPU nodes Maxime Ripard
2014-06-30 10:12 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708073940.GH13423@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.