From: Tony Lindgren <tony@atomide.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: linux@arm.linux.org.uk, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omap16xx: Removes fixme no longer needed in ocpi_enable()
Date: Tue, 8 Jul 2014 01:16:07 -0700 [thread overview]
Message-ID: <20140708081606.GC28884@atomide.com> (raw)
In-Reply-To: <1404351079-5117-1-git-send-email-xerofoify@gmail.com>
* Nicholas Krause <xerofoify@gmail.com> [140702 18:33]:
> This removes the FIXME message above ocpi_enable being declared
> for proper locking in this function. As of the current kernel
> verisons there is no need for locking as only one driver uses
> this function currently and therefore there is no need for real
> locking requirements.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Thanks applying into omap-for-v3.17/fixes-not-urgent.
Tony
> ---
> arch/arm/mach-omap1/ocpi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/ocpi.c b/arch/arm/mach-omap1/ocpi.c
> index 238170c..44a3d19 100644
> --- a/arch/arm/mach-omap1/ocpi.c
> +++ b/arch/arm/mach-omap1/ocpi.c
> @@ -55,7 +55,6 @@ static struct clk *ocpi_ck;
>
> /*
> * Enables device access to OMAP buses via the OCPI bridge
> - * FIXME: Add locking
> */
> int ocpi_enable(void)
> {
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap16xx: Removes fixme no longer needed in ocpi_enable()
Date: Tue, 8 Jul 2014 01:16:07 -0700 [thread overview]
Message-ID: <20140708081606.GC28884@atomide.com> (raw)
In-Reply-To: <1404351079-5117-1-git-send-email-xerofoify@gmail.com>
* Nicholas Krause <xerofoify@gmail.com> [140702 18:33]:
> This removes the FIXME message above ocpi_enable being declared
> for proper locking in this function. As of the current kernel
> verisons there is no need for locking as only one driver uses
> this function currently and therefore there is no need for real
> locking requirements.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Thanks applying into omap-for-v3.17/fixes-not-urgent.
Tony
> ---
> arch/arm/mach-omap1/ocpi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/ocpi.c b/arch/arm/mach-omap1/ocpi.c
> index 238170c..44a3d19 100644
> --- a/arch/arm/mach-omap1/ocpi.c
> +++ b/arch/arm/mach-omap1/ocpi.c
> @@ -55,7 +55,6 @@ static struct clk *ocpi_ck;
>
> /*
> * Enables device access to OMAP buses via the OCPI bridge
> - * FIXME: Add locking
> */
> int ocpi_enable(void)
> {
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-07-08 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 1:31 [PATCH] omap16xx: Removes fixme no longer needed in ocpi_enable() Nicholas Krause
2014-07-03 1:31 ` Nicholas Krause
2014-07-08 8:16 ` Tony Lindgren [this message]
2014-07-08 8:16 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708081606.GC28884@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.