From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michael Kerrisk <mtk.manpages@gmail.com>,
Linux API <linux-api@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>, Jason Evans <je@fb.com>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: Re: [PATCH v10 7/7] mm: Don't split THP page when syscall is called
Date: Tue, 8 Jul 2014 12:48:10 +0300 [thread overview]
Message-ID: <20140708094810.GB3490@node.dhcp.inet.fi> (raw)
In-Reply-To: <20140708013038.GD6076@bbox>
On Tue, Jul 08, 2014 at 10:30:38AM +0900, Minchan Kim wrote:
> Actually, I did but found no problem except CONFIG_DEBUG_VM but rollback
> after peeking [1].
> When I read the description in detail by your review, I think we can remove
> BUG_ON(PageTransHuge(page)) in try_to_unmap and go with no split for lazyfree
> page because they are not in swapcache any more so the assumption of [1] is
> not valid. Will do it in next revision.
No. try_to_unmap() knows nothing about PMDs, so page_check_address() will
always return NULL for THP and you will not unmap anything.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michael Kerrisk <mtk.manpages@gmail.com>,
Linux API <linux-api@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>, Jason Evans <je@fb.com>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: Re: [PATCH v10 7/7] mm: Don't split THP page when syscall is called
Date: Tue, 8 Jul 2014 12:48:10 +0300 [thread overview]
Message-ID: <20140708094810.GB3490@node.dhcp.inet.fi> (raw)
In-Reply-To: <20140708013038.GD6076@bbox>
On Tue, Jul 08, 2014 at 10:30:38AM +0900, Minchan Kim wrote:
> Actually, I did but found no problem except CONFIG_DEBUG_VM but rollback
> after peeking [1].
> When I read the description in detail by your review, I think we can remove
> BUG_ON(PageTransHuge(page)) in try_to_unmap and go with no split for lazyfree
> page because they are not in swapcache any more so the assumption of [1] is
> not valid. Will do it in next revision.
No. try_to_unmap() knows nothing about PMDs, so page_check_address() will
always return NULL for THP and you will not unmap anything.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2014-07-08 9:48 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 0:53 [PATCH v10 0/7] MADV_FREE support Minchan Kim
2014-07-07 0:53 ` Minchan Kim
2014-07-07 0:53 ` Minchan Kim
2014-07-07 0:53 ` [PATCH v10 1/7] mm: support madvise(MADV_FREE) Minchan Kim
2014-07-07 0:53 ` Minchan Kim
2014-07-07 10:41 ` Kirill A. Shutemov
2014-07-07 10:41 ` Kirill A. Shutemov
2014-07-08 0:36 ` Minchan Kim
2014-07-08 0:36 ` Minchan Kim
[not found] ` <1404694438-10272-2-git-send-email-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-07-08 3:54 ` Zhang Yanfei
2014-07-08 3:54 ` Zhang Yanfei
2014-07-08 3:54 ` Zhang Yanfei
[not found] ` <53BB6B64.1080807-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2014-07-08 4:45 ` Minchan Kim
2014-07-08 4:45 ` Minchan Kim
2014-07-08 4:45 ` Minchan Kim
2014-07-07 0:53 ` [PATCH v10 2/7] x86: add pmd_[dirty|mkclean] for THP Minchan Kim
2014-07-07 0:53 ` Minchan Kim
2014-07-07 10:44 ` Kirill A. Shutemov
2014-07-07 10:44 ` Kirill A. Shutemov
2014-07-07 0:53 ` [PATCH v10 3/7] sparc: " Minchan Kim
2014-07-07 0:53 ` Minchan Kim
2014-07-07 0:53 ` Minchan Kim
2014-07-07 0:53 ` [PATCH v10 4/7] powerpc: " Minchan Kim
2014-07-07 0:53 ` Minchan Kim
2014-07-07 0:53 ` Minchan Kim
2014-07-07 0:53 ` [PATCH v10 5/7] s390: " Minchan Kim
2014-07-07 0:53 ` Minchan Kim
[not found] ` <1404694438-10272-6-git-send-email-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-07-07 15:31 ` Gerald Schaefer
2014-07-07 15:31 ` Gerald Schaefer
2014-07-07 15:31 ` Gerald Schaefer
2014-07-07 0:53 ` [PATCH v10 6/7] ARM: " Minchan Kim
2014-07-07 0:53 ` Minchan Kim
2014-07-07 0:53 ` Minchan Kim
[not found] ` <1404694438-10272-7-git-send-email-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-07-07 9:12 ` Will Deacon
2014-07-07 9:12 ` Will Deacon
2014-07-07 9:12 ` Will Deacon
2014-07-07 9:12 ` Will Deacon
2014-07-07 9:22 ` Steve Capper
2014-07-07 9:22 ` Steve Capper
2014-07-07 9:22 ` Steve Capper
2014-07-07 9:22 ` Steve Capper
2014-07-08 1:09 ` Minchan Kim
2014-07-08 1:09 ` Minchan Kim
2014-07-07 0:53 ` [PATCH v10 7/7] mm: Don't split THP page when syscall is called Minchan Kim
2014-07-07 0:53 ` Minchan Kim
2014-07-07 11:13 ` Kirill A. Shutemov
2014-07-07 11:13 ` Kirill A. Shutemov
[not found] ` <20140707111303.GC23150-nhfs4B5ZimeFUdmeq17FyvUpdFzICT1y@public.gmane.org>
2014-07-08 1:30 ` Minchan Kim
2014-07-08 1:30 ` Minchan Kim
2014-07-08 1:30 ` Minchan Kim
2014-07-08 6:10 ` Minchan Kim
2014-07-08 6:10 ` Minchan Kim
2014-07-08 6:10 ` Minchan Kim
2014-07-08 9:48 ` Kirill A. Shutemov [this message]
2014-07-08 9:48 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708094810.GB3490@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=je@fb.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=riel@redhat.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.