From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Larry.Finger@lwfinger.net,
linux-kernel@vger.kernel.org,
drivers_staging@kernel-bugs.osdl.org
Subject: Re: [PATCH] staging: rtl8192ee: Correct bitmask in comparsion
Date: Tue, 08 Jul 2014 11:49:06 +0000 [thread overview]
Message-ID: <20140708114906.GN25880@mwanda> (raw)
In-Reply-To: <1404517213-4067-1-git-send-email-andrey.krieger.utkin@gmail.com>
On Sat, Jul 05, 2014 at 02:40:13AM +0300, Andrey Utkin wrote:
> See https://bugzilla.kernel.org/show_bug.cgi?idx041
> ---8<---
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Following the link to bugzilla, this is a static checker fix.
As far as I can see this patch is just based on guess work? Otherwise
put some kind of description why your fix is correct in the changelog.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Larry.Finger@lwfinger.net,
linux-kernel@vger.kernel.org,
drivers_staging@kernel-bugs.osdl.org
Subject: Re: [PATCH] staging: rtl8192ee: Correct bitmask in comparsion
Date: Tue, 8 Jul 2014 14:49:06 +0300 [thread overview]
Message-ID: <20140708114906.GN25880@mwanda> (raw)
In-Reply-To: <1404517213-4067-1-git-send-email-andrey.krieger.utkin@gmail.com>
On Sat, Jul 05, 2014 at 02:40:13AM +0300, Andrey Utkin wrote:
> See https://bugzilla.kernel.org/show_bug.cgi?id=78041
> ---8<---
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Following the link to bugzilla, this is a static checker fix.
As far as I can see this patch is just based on guess work? Otherwise
put some kind of description why your fix is correct in the changelog.
regards,
dan carpenter
next prev parent reply other threads:[~2014-07-08 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 23:40 [PATCH] staging: rtl8192ee: Correct bitmask in comparsion Andrey Utkin
2014-07-04 23:40 ` Andrey Utkin
2014-07-08 11:49 ` Dan Carpenter [this message]
2014-07-08 11:49 ` Dan Carpenter
2014-07-08 13:54 ` Andrey Utkin
2014-07-08 13:54 ` Andrey Utkin
2014-07-08 15:07 ` Dan Carpenter
2014-07-08 15:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708114906.GN25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andrey.krieger.utkin@gmail.com \
--cc=drivers_staging@kernel-bugs.osdl.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.