From: bp@alien8.de (Borislav Petkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7 3/3] edac: altera: Add EDAC support for Altera SoC SDRAM Controller.
Date: Tue, 8 Jul 2014 13:54:58 +0200 [thread overview]
Message-ID: <20140708115458.GC27659@pd.tnic> (raw)
In-Reply-To: <20140708115205.GA8628@amd.pavel.ucw.cz>
On Tue, Jul 08, 2014 at 01:52:05PM +0200, Pavel Machek wrote:
> I'm not joking. Try to understand and verify the code above. You
> can't. The "descriptive macro names" are useless; all the code does is
> split register in pieces. With the numbers it would be very obvious.
No, you need to fix the names not switch to naked numbers.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
To: Pavel Machek <pavel-ynQEQJNshbs@public.gmane.org>
Cc: tthayer-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org,
robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org,
dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv7 3/3] edac: altera: Add EDAC support for Altera SoC SDRAM Controller.
Date: Tue, 8 Jul 2014 13:54:58 +0200 [thread overview]
Message-ID: <20140708115458.GC27659@pd.tnic> (raw)
In-Reply-To: <20140708115205.GA8628-tWAi6jLit6GreWDznjuHag@public.gmane.org>
On Tue, Jul 08, 2014 at 01:52:05PM +0200, Pavel Machek wrote:
> I'm not joking. Try to understand and verify the code above. You
> can't. The "descriptive macro names" are useless; all the code does is
> split register in pieces. With the numbers it would be very obvious.
No, you need to fix the names not switch to naked numbers.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Pavel Machek <pavel@denx.de>
Cc: tthayer@altera.com, robherring2@gmail.com, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, rob@landley.net, linux@arm.linux.org.uk,
dinguyen@altera.com, dougthompson@xmission.com,
grant.likely@linaro.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
tthayer.linux@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCHv7 3/3] edac: altera: Add EDAC support for Altera SoC SDRAM Controller.
Date: Tue, 8 Jul 2014 13:54:58 +0200 [thread overview]
Message-ID: <20140708115458.GC27659@pd.tnic> (raw)
In-Reply-To: <20140708115205.GA8628@amd.pavel.ucw.cz>
On Tue, Jul 08, 2014 at 01:52:05PM +0200, Pavel Machek wrote:
> I'm not joking. Try to understand and verify the code above. You
> can't. The "descriptive macro names" are useless; all the code does is
> split register in pieces. With the numbers it would be very obvious.
No, you need to fix the names not switch to naked numbers.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-07-08 11:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 21:15 [PATCHv7 0/3] Addition of Altera SDRAM Controller Summary tthayer at altera.com
2014-06-25 21:15 ` tthayer
2014-06-25 21:15 ` tthayer
2014-06-25 21:15 ` [PATCHv7 1/3] devicetree: Addition of the Altera SDRAM Controller tthayer at altera.com
2014-06-25 21:15 ` tthayer
2014-06-25 21:15 ` tthayer
2014-06-25 21:15 ` [PATCHv7 2/3] devicetree: Addition of the Altera SDRAM EDAC tthayer at altera.com
2014-06-25 21:15 ` tthayer
2014-06-25 21:15 ` tthayer
2014-06-26 9:45 ` Mark Rutland
2014-06-26 9:45 ` Mark Rutland
2014-06-27 15:37 ` Thor Thayer
2014-06-27 15:37 ` Thor Thayer
2014-07-09 20:07 ` Thor Thayer
2014-07-09 20:07 ` Thor Thayer
2014-07-10 20:07 ` Alan Tull
2014-07-10 20:07 ` Alan Tull
2014-06-25 21:15 ` [PATCHv7 3/3] edac: altera: Add EDAC support for Altera SoC SDRAM Controller tthayer at altera.com
2014-06-25 21:15 ` tthayer
2014-06-25 21:15 ` tthayer
2014-06-25 21:12 ` Dinh Nguyen
2014-06-25 21:12 ` Dinh Nguyen
2014-06-25 21:22 ` Thor Thayer
2014-06-25 21:22 ` Thor Thayer
2014-07-08 11:31 ` Pavel Machek
2014-07-08 11:31 ` Pavel Machek
2014-07-08 11:42 ` Borislav Petkov
2014-07-08 11:42 ` Borislav Petkov
2014-07-08 11:52 ` Pavel Machek
2014-07-08 11:52 ` Pavel Machek
2014-07-08 11:54 ` Borislav Petkov [this message]
2014-07-08 11:54 ` Borislav Petkov
2014-07-08 11:54 ` Borislav Petkov
2014-07-08 12:04 ` Pavel Machek
2014-07-08 12:04 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708115458.GC27659@pd.tnic \
--to=bp@alien8.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.