From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jingoo Han <jg1.han@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter
Date: Tue, 08 Jul 2014 15:08:12 +0000 [thread overview]
Message-ID: <20140708150812.GC2863@laptop.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407071120310.27641@kaball.uk.xensource.com>
On Mon, Jul 07, 2014 at 11:20:39AM +0100, Stefano Stabellini wrote:
> On Sun, 6 Jul 2014, Rickard Strandqvist wrote:
> > Remove assignment of function parameter, that has no effect outside the function
> >
> > This was found using a static code analysis program called cppcheck
> >
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
and Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
>
> > drivers/video/fbdev/xen-fbfront.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> > index 901014b..e1207a1 100644
> > --- a/drivers/video/fbdev/xen-fbfront.c
> > +++ b/drivers/video/fbdev/xen-fbfront.c
> > @@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
> > red = CNVT_TOHW(red, info->var.red.length);
> > green = CNVT_TOHW(green, info->var.green.length);
> > blue = CNVT_TOHW(blue, info->var.blue.length);
> > - transp = CNVT_TOHW(transp, info->var.transp.length);
> > #undef CNVT_TOHW
> >
> > v = (red << info->var.red.offset) |
> > --
> > 1.7.10.4
> >
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jingoo Han <jg1.han@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter
Date: Tue, 8 Jul 2014 11:08:12 -0400 [thread overview]
Message-ID: <20140708150812.GC2863@laptop.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407071120310.27641@kaball.uk.xensource.com>
On Mon, Jul 07, 2014 at 11:20:39AM +0100, Stefano Stabellini wrote:
> On Sun, 6 Jul 2014, Rickard Strandqvist wrote:
> > Remove assignment of function parameter, that has no effect outside the function
> >
> > This was found using a static code analysis program called cppcheck
> >
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
and Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
>
> > drivers/video/fbdev/xen-fbfront.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> > index 901014b..e1207a1 100644
> > --- a/drivers/video/fbdev/xen-fbfront.c
> > +++ b/drivers/video/fbdev/xen-fbfront.c
> > @@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
> > red = CNVT_TOHW(red, info->var.red.length);
> > green = CNVT_TOHW(green, info->var.green.length);
> > blue = CNVT_TOHW(blue, info->var.blue.length);
> > - transp = CNVT_TOHW(transp, info->var.transp.length);
> > #undef CNVT_TOHW
> >
> > v = (red << info->var.red.offset) |
> > --
> > 1.7.10.4
> >
next prev parent reply other threads:[~2014-07-08 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 13:10 [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter Rickard Strandqvist
2014-07-05 13:10 ` Rickard Strandqvist
2014-07-06 17:27 ` Rickard Strandqvist
2014-07-06 17:27 ` Rickard Strandqvist
2014-07-07 10:20 ` Stefano Stabellini
2014-07-07 10:20 ` Stefano Stabellini
2014-07-08 15:08 ` Konrad Rzeszutek Wilk [this message]
2014-07-08 15:08 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708150812.GC2863@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=daniel.vetter@ffwll.ch \
--cc=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.