All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	balbi@ti.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	mika.westerberg@linux.intel.com
Subject: Re: [RFC PATCH 3/4] tty: serial: 8250 core: add runtime pm
Date: Wed, 9 Jul 2014 23:43:05 -0700	[thread overview]
Message-ID: <20140710064305.GG28884@atomide.com> (raw)
In-Reply-To: <53BD6EB3.4020305@linutronix.de>

* Sebastian Andrzej Siewior <bigeasy@linutronix.de> [140709 09:35]:
> On 07/09/2014 05:12 PM, Tony Lindgren wrote:
> > And also please note that for runtime PM the wake-up events need
> > to be always enabled, so the device_may_wakeup() checks should
> > be only implemented for suspend and resume. I think I got that
> > corrected for most part in omap-serial.c recently, but knowing
> > that might reduce the confusion a bit :)
> 
> Ehm. I also added it to omap_8250_pm() as it is done in omap-serial (in
> serial_omap_pm()). Should I get rid of it in the latter?

Yes, I commented on that patch also.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 3/4] tty: serial: 8250 core: add runtime pm
Date: Wed, 9 Jul 2014 23:43:05 -0700	[thread overview]
Message-ID: <20140710064305.GG28884@atomide.com> (raw)
In-Reply-To: <53BD6EB3.4020305@linutronix.de>

* Sebastian Andrzej Siewior <bigeasy@linutronix.de> [140709 09:35]:
> On 07/09/2014 05:12 PM, Tony Lindgren wrote:
> > And also please note that for runtime PM the wake-up events need
> > to be always enabled, so the device_may_wakeup() checks should
> > be only implemented for suspend and resume. I think I got that
> > corrected for most part in omap-serial.c recently, but knowing
> > that might reduce the confusion a bit :)
> 
> Ehm. I also added it to omap_8250_pm() as it is done in omap-serial (in
> serial_omap_pm()). Should I get rid of it in the latter?

Yes, I commented on that patch also.

Regards,

Tony

  reply	other threads:[~2014-07-10  6:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04 16:34 [RFC PATCH 1/4] tty: serial: 8250 core: provide a function to export uart_8250_port Sebastian Andrzej Siewior
2014-07-04 16:34 ` Sebastian Andrzej Siewior
2014-07-04 16:34 ` [RFC PATCH 2/4] tty: serial: 8250 core: allow to overwrite & export serial8250_startup() Sebastian Andrzej Siewior
2014-07-04 16:34   ` Sebastian Andrzej Siewior
2014-07-07 13:09   ` One Thousand Gnomes
2014-07-07 13:09     ` One Thousand Gnomes
2014-07-09 17:39     ` Sebastian Andrzej Siewior
2014-07-09 17:39       ` Sebastian Andrzej Siewior
2014-07-04 16:34 ` [RFC PATCH 3/4] tty: serial: 8250 core: add runtime pm Sebastian Andrzej Siewior
2014-07-04 16:34   ` Sebastian Andrzej Siewior
2014-07-07 13:20   ` One Thousand Gnomes
2014-07-07 13:20     ` One Thousand Gnomes
2014-07-09 11:17     ` Tony Lindgren
2014-07-09 11:17       ` Tony Lindgren
2014-07-09 11:35       ` Sebastian Andrzej Siewior
2014-07-09 11:35         ` Sebastian Andrzej Siewior
2014-07-09 11:48         ` Tony Lindgren
2014-07-09 11:48           ` Tony Lindgren
2014-07-09 12:42           ` Sebastian Andrzej Siewior
2014-07-09 12:42             ` Sebastian Andrzej Siewior
2014-07-09 15:12             ` Tony Lindgren
2014-07-09 15:12               ` Tony Lindgren
2014-07-09 16:32               ` Sebastian Andrzej Siewior
2014-07-09 16:32                 ` Sebastian Andrzej Siewior
2014-07-10  6:43                 ` Tony Lindgren [this message]
2014-07-10  6:43                   ` Tony Lindgren
2014-07-04 16:34 ` [RFC PATCH 4/4] tty: serial: Add 8250-core based omap driver v2 Sebastian Andrzej Siewior
2014-07-04 16:34   ` Sebastian Andrzej Siewior
2014-07-04 16:34   ` Sebastian Andrzej Siewior
2014-07-07 13:09 ` [RFC PATCH 1/4] tty: serial: 8250 core: provide a function to export uart_8250_port One Thousand Gnomes
2014-07-07 13:09   ` One Thousand Gnomes
2014-07-09 17:23   ` Sebastian Andrzej Siewior
2014-07-09 17:23     ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140710064305.GG28884@atomide.com \
    --to=tony@atomide.com \
    --cc=balbi@ti.com \
    --cc=bigeasy@linutronix.de \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.