All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: dts: Restructure imx6qdl-wandboard.dtsi for new rev C1 board.
Date: Thu, 10 Jul 2014 15:01:04 +0800	[thread overview]
Message-ID: <20140710070103.GA2542@dragon> (raw)
In-Reply-To: <1404845297-13751-1-git-send-email-george.joseph@fairview5.com>

On Tue, Jul 08, 2014 at 12:48:16PM -0600, George Joseph wrote:
> The rev C1 Wandboard uses the Broadcom 4330 for WiFi and Bluetooth instead of
> the 4329.  This changes the PADS assigned for the control lines.  Another
> side effect of the change is that on the rev C1 board, usdhc driver can't
> detect the chip presence correctly so usdhc2 now needs its 'non-removeable'
> property removed.
> 
> So that rev B1 and earlier can continue to work, this patch splits the
> board-specific definitions from imx6qdl-wandboard.dtsi into
> imx6qdl-wandboard-revb1.dtsi and imx6qdl-wandboard-revc1.dtsi.  The new files
> include the original base imx6qdl-wandboard.dtsi which retains the common
> definitions.
> 
> The existing imx6dl-wandboard.dts includes imx6qdl-wandboard-revc1.dtsi and
> imx6dl-wandboard-revb1.dts (new) includes imx6qdl-wandboard-revb1.dtsi.
> This makes the rev C1 board the new default.  The same pattern is used for
> imx6q-wandboard.dts.
> 
> So, from U-Boot on a WB-Quad you use imxq-wandboard-revb1.dtb for the older B1
> board and imxq-wandboard.dtb for the current rev C1 board.
> 
> Signed-off-by: George Joseph <george.joseph@fairview5.com>
> ---
>  arch/arm/boot/dts/imx6dl-wandboard-revb1.dts   | 22 ++++++++++++++
>  arch/arm/boot/dts/imx6dl-wandboard.dts         |  2 +-
>  arch/arm/boot/dts/imx6q-wandboard-revb1.dts    | 26 ++++++++++++++++
>  arch/arm/boot/dts/imx6q-wandboard.dts          |  2 +-
>  arch/arm/boot/dts/imx6qdl-wandboard-revb1.dtsi | 42 ++++++++++++++++++++++++++
>  arch/arm/boot/dts/imx6qdl-wandboard-revc1.dtsi | 41 +++++++++++++++++++++++++
>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi       | 21 -------------
>  7 files changed, 133 insertions(+), 23 deletions(-)
>  create mode 100644 arch/arm/boot/dts/imx6dl-wandboard-revb1.dts
>  create mode 100644 arch/arm/boot/dts/imx6q-wandboard-revb1.dts

These two should be added into arch/arm/boot/dts/Makefile as build
target.

I fixed it up and applied the patch.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: George Joseph <george.joseph-H+B1fhQ+CpcEVd8bySq3Wg@public.gmane.org>
Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2] ARM: dts: Restructure imx6qdl-wandboard.dtsi for new rev C1 board.
Date: Thu, 10 Jul 2014 15:01:04 +0800	[thread overview]
Message-ID: <20140710070103.GA2542@dragon> (raw)
In-Reply-To: <1404845297-13751-1-git-send-email-george.joseph-H+B1fhQ+CpcEVd8bySq3Wg@public.gmane.org>

On Tue, Jul 08, 2014 at 12:48:16PM -0600, George Joseph wrote:
> The rev C1 Wandboard uses the Broadcom 4330 for WiFi and Bluetooth instead of
> the 4329.  This changes the PADS assigned for the control lines.  Another
> side effect of the change is that on the rev C1 board, usdhc driver can't
> detect the chip presence correctly so usdhc2 now needs its 'non-removeable'
> property removed.
> 
> So that rev B1 and earlier can continue to work, this patch splits the
> board-specific definitions from imx6qdl-wandboard.dtsi into
> imx6qdl-wandboard-revb1.dtsi and imx6qdl-wandboard-revc1.dtsi.  The new files
> include the original base imx6qdl-wandboard.dtsi which retains the common
> definitions.
> 
> The existing imx6dl-wandboard.dts includes imx6qdl-wandboard-revc1.dtsi and
> imx6dl-wandboard-revb1.dts (new) includes imx6qdl-wandboard-revb1.dtsi.
> This makes the rev C1 board the new default.  The same pattern is used for
> imx6q-wandboard.dts.
> 
> So, from U-Boot on a WB-Quad you use imxq-wandboard-revb1.dtb for the older B1
> board and imxq-wandboard.dtb for the current rev C1 board.
> 
> Signed-off-by: George Joseph <george.joseph-H+B1fhQ+CpcEVd8bySq3Wg@public.gmane.org>
> ---
>  arch/arm/boot/dts/imx6dl-wandboard-revb1.dts   | 22 ++++++++++++++
>  arch/arm/boot/dts/imx6dl-wandboard.dts         |  2 +-
>  arch/arm/boot/dts/imx6q-wandboard-revb1.dts    | 26 ++++++++++++++++
>  arch/arm/boot/dts/imx6q-wandboard.dts          |  2 +-
>  arch/arm/boot/dts/imx6qdl-wandboard-revb1.dtsi | 42 ++++++++++++++++++++++++++
>  arch/arm/boot/dts/imx6qdl-wandboard-revc1.dtsi | 41 +++++++++++++++++++++++++
>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi       | 21 -------------
>  7 files changed, 133 insertions(+), 23 deletions(-)
>  create mode 100644 arch/arm/boot/dts/imx6dl-wandboard-revb1.dts
>  create mode 100644 arch/arm/boot/dts/imx6q-wandboard-revb1.dts

These two should be added into arch/arm/boot/dts/Makefile as build
target.

I fixed it up and applied the patch.

Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@freescale.com>
To: George Joseph <george.joseph@fairview5.com>
Cc: Sascha Hauer <kernel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] ARM: dts: Restructure imx6qdl-wandboard.dtsi for new rev C1 board.
Date: Thu, 10 Jul 2014 15:01:04 +0800	[thread overview]
Message-ID: <20140710070103.GA2542@dragon> (raw)
In-Reply-To: <1404845297-13751-1-git-send-email-george.joseph@fairview5.com>

On Tue, Jul 08, 2014 at 12:48:16PM -0600, George Joseph wrote:
> The rev C1 Wandboard uses the Broadcom 4330 for WiFi and Bluetooth instead of
> the 4329.  This changes the PADS assigned for the control lines.  Another
> side effect of the change is that on the rev C1 board, usdhc driver can't
> detect the chip presence correctly so usdhc2 now needs its 'non-removeable'
> property removed.
> 
> So that rev B1 and earlier can continue to work, this patch splits the
> board-specific definitions from imx6qdl-wandboard.dtsi into
> imx6qdl-wandboard-revb1.dtsi and imx6qdl-wandboard-revc1.dtsi.  The new files
> include the original base imx6qdl-wandboard.dtsi which retains the common
> definitions.
> 
> The existing imx6dl-wandboard.dts includes imx6qdl-wandboard-revc1.dtsi and
> imx6dl-wandboard-revb1.dts (new) includes imx6qdl-wandboard-revb1.dtsi.
> This makes the rev C1 board the new default.  The same pattern is used for
> imx6q-wandboard.dts.
> 
> So, from U-Boot on a WB-Quad you use imxq-wandboard-revb1.dtb for the older B1
> board and imxq-wandboard.dtb for the current rev C1 board.
> 
> Signed-off-by: George Joseph <george.joseph@fairview5.com>
> ---
>  arch/arm/boot/dts/imx6dl-wandboard-revb1.dts   | 22 ++++++++++++++
>  arch/arm/boot/dts/imx6dl-wandboard.dts         |  2 +-
>  arch/arm/boot/dts/imx6q-wandboard-revb1.dts    | 26 ++++++++++++++++
>  arch/arm/boot/dts/imx6q-wandboard.dts          |  2 +-
>  arch/arm/boot/dts/imx6qdl-wandboard-revb1.dtsi | 42 ++++++++++++++++++++++++++
>  arch/arm/boot/dts/imx6qdl-wandboard-revc1.dtsi | 41 +++++++++++++++++++++++++
>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi       | 21 -------------
>  7 files changed, 133 insertions(+), 23 deletions(-)
>  create mode 100644 arch/arm/boot/dts/imx6dl-wandboard-revb1.dts
>  create mode 100644 arch/arm/boot/dts/imx6q-wandboard-revb1.dts

These two should be added into arch/arm/boot/dts/Makefile as build
target.

I fixed it up and applied the patch.

Shawn

  reply	other threads:[~2014-07-10  7:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 18:48 [PATCH V2] ARM: dts: Restructure imx6qdl-wandboard.dtsi for new rev C1 board George Joseph
2014-07-08 18:48 ` George Joseph
2014-07-08 18:48 ` George Joseph
2014-07-10  7:01 ` Shawn Guo [this message]
2014-07-10  7:01   ` Shawn Guo
2014-07-10  7:01   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140710070103.GA2542@dragon \
    --to=shawn.guo@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.