From: Johannes Weiner <hannes@cmpxchg.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Linux-FSDevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 3/6] mm: Move zone->pages_scanned into a vmstat counter
Date: Thu, 10 Jul 2014 08:08:57 -0400 [thread overview]
Message-ID: <20140710120857.GK29639@cmpxchg.org> (raw)
In-Reply-To: <1404893588-21371-4-git-send-email-mgorman@suse.de>
On Wed, Jul 09, 2014 at 09:13:05AM +0100, Mel Gorman wrote:
> zone->pages_scanned is a write-intensive cache line during page reclaim
> and it's also updated during page free. Move the counter into vmstat to
> take advantage of the per-cpu updates and do not update it in the free
> paths unless necessary.
>
> On a small UMA machine running tiobench the difference is marginal. On a
> 4-node machine the overhead is more noticable. Note that automatic NUMA
> balancing was disabled for this test as otherwise the system CPU overhead
> is unpredictable.
>
> 3.16.0-rc3 3.16.0-rc3 3.16.0-rc3
> vanillarearrange-v5 vmstat-v5
> User 746.94 759.78 774.56
> System 65336.22 58350.98 32847.27
> Elapsed 27553.52 27282.02 27415.04
>
> Note that the overhead reduction will vary depending on where exactly
> pages are allocated and freed.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Linux-FSDevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 3/6] mm: Move zone->pages_scanned into a vmstat counter
Date: Thu, 10 Jul 2014 08:08:57 -0400 [thread overview]
Message-ID: <20140710120857.GK29639@cmpxchg.org> (raw)
In-Reply-To: <1404893588-21371-4-git-send-email-mgorman@suse.de>
On Wed, Jul 09, 2014 at 09:13:05AM +0100, Mel Gorman wrote:
> zone->pages_scanned is a write-intensive cache line during page reclaim
> and it's also updated during page free. Move the counter into vmstat to
> take advantage of the per-cpu updates and do not update it in the free
> paths unless necessary.
>
> On a small UMA machine running tiobench the difference is marginal. On a
> 4-node machine the overhead is more noticable. Note that automatic NUMA
> balancing was disabled for this test as otherwise the system CPU overhead
> is unpredictable.
>
> 3.16.0-rc3 3.16.0-rc3 3.16.0-rc3
> vanillarearrange-v5 vmstat-v5
> User 746.94 759.78 774.56
> System 65336.22 58350.98 32847.27
> Elapsed 27553.52 27282.02 27415.04
>
> Note that the overhead reduction will vary depending on where exactly
> pages are allocated and freed.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2014-07-10 12:08 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 8:13 [PATCH 0/5] Reduce sequential read overhead Mel Gorman
2014-07-09 8:13 ` Mel Gorman
2014-07-09 8:13 ` [PATCH 1/6] mm: pagemap: Avoid unnecessary overhead when tracepoints are deactivated Mel Gorman
2014-07-09 8:13 ` Mel Gorman
2014-07-10 12:01 ` Johannes Weiner
2014-07-10 12:01 ` Johannes Weiner
2014-07-09 8:13 ` [PATCH 2/6] mm: Rearrange zone fields into read-only, page alloc, statistics and page reclaim lines Mel Gorman
2014-07-09 8:13 ` Mel Gorman
2014-07-10 12:06 ` Johannes Weiner
2014-07-10 12:06 ` Johannes Weiner
2014-07-09 8:13 ` [PATCH 3/6] mm: Move zone->pages_scanned into a vmstat counter Mel Gorman
2014-07-09 8:13 ` Mel Gorman
2014-07-10 12:08 ` Johannes Weiner [this message]
2014-07-10 12:08 ` Johannes Weiner
2014-07-09 8:13 ` [PATCH 4/6] mm: vmscan: Only update per-cpu thresholds for online CPU Mel Gorman
2014-07-09 8:13 ` Mel Gorman
2014-07-10 12:09 ` Johannes Weiner
2014-07-10 12:09 ` Johannes Weiner
2014-07-09 8:13 ` [PATCH 5/6] mm: page_alloc: Abort fair zone allocation policy when remotes nodes are encountered Mel Gorman
2014-07-09 8:13 ` Mel Gorman
2014-07-10 12:14 ` Johannes Weiner
2014-07-10 12:14 ` Johannes Weiner
2014-07-10 12:44 ` Mel Gorman
2014-07-10 12:44 ` Mel Gorman
2014-07-09 8:13 ` [PATCH 6/6] mm: page_alloc: Reduce cost of the fair zone allocation policy Mel Gorman
2014-07-09 8:13 ` Mel Gorman
2014-07-10 12:18 ` Johannes Weiner
2014-07-10 12:18 ` Johannes Weiner
2014-08-08 15:27 ` Vlastimil Babka
2014-08-08 15:27 ` Vlastimil Babka
2014-08-11 12:12 ` Mel Gorman
2014-08-11 12:12 ` Mel Gorman
2014-08-11 12:34 ` Vlastimil Babka
2014-08-11 12:34 ` Vlastimil Babka
2014-09-02 14:01 ` Johannes Weiner
2014-09-02 14:01 ` Johannes Weiner
2014-09-05 10:14 ` [PATCH] mm: page_alloc: Fix setting of ZONE_FAIR_DEPLETED on UP Mel Gorman
2014-09-05 10:14 ` Mel Gorman
2014-09-07 6:32 ` Leon Romanovsky
2014-09-07 6:32 ` Leon Romanovsky
2014-09-08 11:57 ` [PATCH] mm: page_alloc: Fix setting of ZONE_FAIR_DEPLETED on UP v2 Mel Gorman
2014-09-08 11:57 ` Mel Gorman
2014-09-09 8:17 ` Leon Romanovsky
2014-09-09 19:53 ` Andrew Morton
2014-09-09 19:53 ` Andrew Morton
2014-09-10 9:16 ` Mel Gorman
2014-09-10 9:16 ` Mel Gorman
2014-09-10 20:32 ` Johannes Weiner
2014-09-10 20:32 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710120857.GK29639@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.