All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: Check fs consistency on TEST_DEV only when needed
Date: Fri, 11 Jul 2014 06:50:11 +1000	[thread overview]
Message-ID: <20140710205011.GL4453@dastard> (raw)
In-Reply-To: <alpine.LFD.2.00.1407101031150.2659@localhost.localdomain>

On Thu, Jul 10, 2014 at 10:38:45AM +0200, Lukáš Czerner wrote:
> On Thu, 10 Jul 2014, Dave Chinner wrote:
> I like the idea Eric proposed with the _require_test check for the
> test that actually require test device and then actually check the
> device only after such test. Will that be acceptable ? If so I'll
> rework the patches.

Works for me. Don't forget to add it to the "new" script as well
so the default is to check the test device. That will trigger us to
check if it is necessary during test development review, rather than
forgetting we need to add it. ;)

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: Check fs consistency on TEST_DEV only when needed
Date: Fri, 11 Jul 2014 06:50:11 +1000	[thread overview]
Message-ID: <20140710205011.GL4453@dastard> (raw)
In-Reply-To: <alpine.LFD.2.00.1407101031150.2659@localhost.localdomain>

On Thu, Jul 10, 2014 at 10:38:45AM +0200, Lukáš Czerner wrote:
> On Thu, 10 Jul 2014, Dave Chinner wrote:
> I like the idea Eric proposed with the _require_test check for the
> test that actually require test device and then actually check the
> device only after such test. Will that be acceptable ? If so I'll
> rework the patches.

Works for me. Don't forget to add it to the "new" script as well
so the default is to check the test device. That will trigger us to
check if it is necessary during test development review, rather than
forgetting we need to add it. ;)

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-07-10 20:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 13:36 [PATCH 1/2] xfstests: Check the file system consistency on SCRATCH_DEV Lukas Czerner
2014-06-24 13:36 ` Lukas Czerner
2014-06-24 13:36 ` [PATCH 2/2] xfstests: Check fs consistency on TEST_DEV only when needed Lukas Czerner
2014-06-24 13:36   ` Lukas Czerner
2014-07-10  1:07   ` Dave Chinner
2014-07-10  1:07     ` Dave Chinner
2014-07-10  1:52     ` Eric Sandeen
2014-07-10  1:52       ` Eric Sandeen
2014-07-10  8:38     ` Lukáš Czerner
2014-07-10  8:38       ` Lukáš Czerner
2014-07-10 20:50       ` Dave Chinner [this message]
2014-07-10 20:50         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140710205011.GL4453@dastard \
    --to=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    --cc=lczerner@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.