From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Thomas Hellström" <thellstrom@vmware.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: drm/vmwgfx: Fix compat shader namespace
Date: Fri, 11 Jul 2014 11:43:01 +0300 [thread overview]
Message-ID: <20140711084301.GM23001@mwanda> (raw)
In-Reply-To: <53BF1041.5000103@vmware.com>
On Fri, Jul 11, 2014 at 12:14:25AM +0200, Thomas Hellström wrote:
>
> I agree, however that readability may be more important than the
> fastpath execution speed gained from this. But in my case not so
> much that I spontaneously feel like removing all branch prediction
> hints from the vmwgfx driver.
I'm just saying, let's not add new ones.
>
> >
> >There are two rules of thumb for likely/unlikely:
> >
> > 1) Don't use it in the drivers/ directory.
> > 2) Or don't use it without benchmarking it.
>
> Could you point me to a document or some sort of reference?
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-March/025252.html
regards,
dan carpenter
prev parent reply other threads:[~2014-07-11 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 12:48 drm/vmwgfx: Fix compat shader namespace Dan Carpenter
2014-07-09 21:31 ` Thomas Hellström
2014-07-10 9:33 ` Dan Carpenter
2014-07-10 22:14 ` Thomas Hellström
2014-07-11 8:43 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711084301.GM23001@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.