From: Greg KH <gregkh@linuxfoundation.org>
To: kernelnewbies@lists.kernelnewbies.org
Subject: Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch
Date: Sat, 12 Jul 2014 02:34:21 +0000 [thread overview]
Message-ID: <20140712023421.GA20583@kroah.com> (raw)
In-Reply-To: <1405129216.6751.18.camel@joe-AO725>
On Fri, Jul 11, 2014 at 06:40:16PM -0700, Joe Perches wrote:
> On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote:
> > On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> > > A simple script to run checkpatch --fix for various types of
> > > of cleanups.
> > >
> > > This script is useful primarily for staging.
> > >
> > > This reformats code to a more CodingStyle conforming style,
> > > compiles it, verifies that the object code hasn't changed,
> > > and git commits it too.
> >
> > And 'git commits' it?
>
> The thought I had was to made it easier to
> submit "my first kernel patch" correctly.
> like that tuxradar article you wrote a few
> years ago.
>
> http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
Yeah, but it's good for people to actually understand the change they
are making, and edit it themselves. Or at least I think so, but I know
others don't, so I don't mind this script.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] reformat_with_checkpatch: Add automation to checkpatch
Date: Fri, 11 Jul 2014 19:34:21 -0700 [thread overview]
Message-ID: <20140712023421.GA20583@kroah.com> (raw)
In-Reply-To: <1405129216.6751.18.camel@joe-AO725>
On Fri, Jul 11, 2014 at 06:40:16PM -0700, Joe Perches wrote:
> On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote:
> > On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> > > A simple script to run checkpatch --fix for various types of
> > > of cleanups.
> > >
> > > This script is useful primarily for staging.
> > >
> > > This reformats code to a more CodingStyle conforming style,
> > > compiles it, verifies that the object code hasn't changed,
> > > and git commits it too.
> >
> > And 'git commits' it?
>
> The thought I had was to made it easier to
> submit "my first kernel patch" correctly.
> like that tuxradar article you wrote a few
> years ago.
>
> http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
Yeah, but it's good for people to actually understand the change they
are making, and edit it themselves. Or at least I think so, but I know
others don't, so I don't mind this script.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org,
kernel-janitors <kernel-janitors@vger.kernel.org>,
kernelnewbies@kernelnewbies.org,
LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch
Date: Fri, 11 Jul 2014 19:34:21 -0700 [thread overview]
Message-ID: <20140712023421.GA20583@kroah.com> (raw)
In-Reply-To: <1405129216.6751.18.camel@joe-AO725>
On Fri, Jul 11, 2014 at 06:40:16PM -0700, Joe Perches wrote:
> On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote:
> > On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> > > A simple script to run checkpatch --fix for various types of
> > > of cleanups.
> > >
> > > This script is useful primarily for staging.
> > >
> > > This reformats code to a more CodingStyle conforming style,
> > > compiles it, verifies that the object code hasn't changed,
> > > and git commits it too.
> >
> > And 'git commits' it?
>
> The thought I had was to made it easier to
> submit "my first kernel patch" correctly.
> like that tuxradar article you wrote a few
> years ago.
>
> http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
Yeah, but it's good for people to actually understand the change they
are making, and edit it themselves. Or at least I think so, but I know
others don't, so I don't mind this script.
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-12 2:34 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 1:21 [PATCH] reformat_with_checkpatch: Add automation to checkpatch Joe Perches
2014-07-12 1:21 ` Joe Perches
2014-07-12 1:21 ` Joe Perches
2014-07-12 1:34 ` Greg KH
2014-07-12 1:34 ` Greg KH
2014-07-12 1:34 ` Greg KH
2014-07-12 1:40 ` Joe Perches
2014-07-12 1:40 ` Joe Perches
2014-07-12 1:40 ` Joe Perches
2014-07-12 2:34 ` Greg KH [this message]
2014-07-12 2:34 ` Greg KH
2014-07-12 2:34 ` Greg KH
2014-07-12 9:30 ` Dan Carpenter
2014-07-12 9:30 ` Dan Carpenter
2014-07-12 9:30 ` Dan Carpenter
2014-07-12 17:55 ` Greg KH
2014-07-12 17:55 ` Greg KH
2014-07-12 17:55 ` Greg KH
2014-07-12 18:29 ` Joe Perches
2014-07-12 18:29 ` Joe Perches
2014-07-12 18:29 ` Joe Perches
2014-07-12 19:28 ` Greg KH
2014-07-12 19:28 ` Greg KH
2014-07-12 19:28 ` Greg KH
2014-07-13 3:06 ` Joe Perches
2014-07-13 3:06 ` Joe Perches
2014-07-13 3:06 ` Joe Perches
2014-07-12 1:39 ` Greg KH
2014-07-12 1:39 ` Greg KH
2014-07-12 1:39 ` Greg KH
2014-07-12 1:46 ` Joe Perches
2014-07-12 1:46 ` Joe Perches
2014-07-12 1:46 ` Joe Perches
2014-07-12 1:57 ` Greg KH
2014-07-12 2:01 ` Greg KH
2014-07-12 2:01 ` Greg KH
2014-07-12 2:05 ` Greg KH
2014-07-12 2:05 ` Greg KH
2014-07-12 2:05 ` Greg KH
2014-07-12 2:09 ` [PATCH] checkpatch: Remove unnecessary + after {8,8} Joe Perches
2014-07-12 2:09 ` Joe Perches
2014-07-12 2:09 ` Joe Perches
2014-07-12 2:23 ` Greg KH
2014-07-12 2:23 ` Greg KH
2014-07-12 2:23 ` Greg KH
2014-08-31 20:58 ` Sören Brinkmann
2014-08-31 20:58 ` Sören Brinkmann
2014-08-31 20:58 ` Sören Brinkmann
2014-09-01 16:55 ` [PATCH - resend] " Joe Perches
2014-09-01 16:55 ` Joe Perches
2014-09-01 16:55 ` Joe Perches
2014-10-30 11:12 ` Borislav Petkov
2014-10-30 11:12 ` Borislav Petkov
2014-10-30 11:12 ` Borislav Petkov
2014-10-30 11:15 ` Borislav Petkov
2014-10-30 11:15 ` Borislav Petkov
2014-10-30 11:15 ` Borislav Petkov
2014-07-12 1:43 ` [PATCH] reformat_with_checkpatch: Add automation to checkpatch Greg KH
2014-07-12 1:43 ` Greg KH
2014-07-12 1:43 ` Greg KH
2014-07-12 1:50 ` Joe Perches
2014-07-12 1:50 ` Joe Perches
2014-07-12 1:50 ` Joe Perches
2014-07-12 1:53 ` Greg KH
2014-07-12 1:53 ` Greg KH
2014-07-12 1:53 ` Greg KH
2014-07-12 1:57 ` Joe Perches
2014-07-12 1:57 ` Joe Perches
2014-07-12 1:57 ` Joe Perches
2014-07-12 2:15 ` Greg KH
2014-07-12 2:15 ` Greg KH
2014-07-12 2:15 ` Greg KH
2014-07-12 8:08 ` Greg KH
2014-07-12 8:08 ` Greg KH
2014-07-12 8:08 ` Greg KH
2014-07-12 8:18 ` Greg KH
2014-07-12 8:18 ` Greg KH
2014-07-12 8:18 ` Greg KH
2014-07-12 10:13 ` Joe Perches
2014-07-12 10:13 ` Joe Perches
2014-07-12 10:13 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140712023421.GA20583@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.