Re: [Powertop] [PATCH] powertop: update build instructions

Re: [Powertop] [PATCH] powertop: update build instructions

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

On (07/13/14 12:06), Mohammad Merajul Islam Molla wrote:
> update powertop build instuctions in README file.
> 
> Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma(a)gmail.com>
> ---
>  README | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/README b/README
> index cd38cc5..efe95c3 100644
> --- a/README
> +++ b/README
> @@ -2,9 +2,10 @@
>  ------------------------------
>  
>  To build and install PowerTOP type the following commands, 
> -	./configure 
> -	./make
> -	./make install
> +       autoreconf -sfi

we have autogen.sh to deal with autoreconf. let's recommend to use
it instead of direct autoreconf.

	-ss

> +       ./configure
> +       make
> +       sudo make install
>  
>  Note: For Android (running Intel Architecture ) there is a Android.mk 
>  that was provided by community members, and at this time is supported
> -- 
> 1.9.1
> 
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
> 

Re: [Powertop] [PATCH] powertop: update build instructions

[Alexandra Yates]

[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]


> On Sun, Jul 13, 2014 at 12:26 AM, Sergey Senozhatsky
> <sergey.senozhatsky(a)gmail.com> wrote:
>> On (07/13/14 12:06), Mohammad Merajul Islam Molla wrote:
>>> update powertop build instuctions in README file.
>>>
>>> Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma(a)gmail.com>
>>> ---
>>>  README | 7 ++++---
>>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/README b/README
>>> index cd38cc5..efe95c3 100644
>>> --- a/README
>>> +++ b/README
>>> @@ -2,9 +2,10 @@
>>>  ------------------------------
>>>
>>>  To build and install PowerTOP type the following commands,
>>> -     ./configure
>>> -     ./make
>>> -     ./make install
>>> +       autoreconf -sfi
>>
>> we have autogen.sh to deal with autoreconf. let's recommend to use
>> it instead of direct autoreconf.
>
> These instructions are currently correct when people download the
> published tarballs, and this change would make them incorrect, or
> unnecessarily make people rerun autoconf & friends at the least.
>
> I suggest you document both build cases, e.g. some text for people who
> build from git sources, vs. those folks who do distribution
> integration and never build from git.
>
> Cheers,
>
> Auke
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>

Hi  Mohammad,

Please send the updated readme patch to match Auke's feedback: "... I
suggest you document both build cases, e.g. some text for people who build
from git sources, vs. those folks who do distribution integration and
never build from git...".


Please create your patches editing your subject prefix and the version
number of this patch.  That facilitate accepting your patches.

 git format-patch --cover-letter --subject-prefix="PATCH Vn" ...

Thank you,
Alexandra.

Re: [Powertop] [PATCH] powertop: update build instructions

[Kok, Auke-jan H]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

On Sun, Jul 13, 2014 at 12:26 AM, Sergey Senozhatsky
<sergey.senozhatsky(a)gmail.com> wrote:
> On (07/13/14 12:06), Mohammad Merajul Islam Molla wrote:
>> update powertop build instuctions in README file.
>>
>> Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma(a)gmail.com>
>> ---
>>  README | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/README b/README
>> index cd38cc5..efe95c3 100644
>> --- a/README
>> +++ b/README
>> @@ -2,9 +2,10 @@
>>  ------------------------------
>>
>>  To build and install PowerTOP type the following commands,
>> -     ./configure
>> -     ./make
>> -     ./make install
>> +       autoreconf -sfi
>
> we have autogen.sh to deal with autoreconf. let's recommend to use
> it instead of direct autoreconf.

These instructions are currently correct when people download the
published tarballs, and this change would make them incorrect, or
unnecessarily make people rerun autoconf & friends at the least.

I suggest you document both build cases, e.g. some text for people who
build from git sources, vs. those folks who do distribution
integration and never build from git.

Cheers,

Auke

[Powertop] [PATCH] powertop: update build instructions

[Mohammad Merajul Islam Molla]

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

update powertop build instuctions in README file.

Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma(a)gmail.com>
---
 README | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/README b/README
index cd38cc5..efe95c3 100644
--- a/README
+++ b/README
@@ -2,9 +2,10 @@
 ------------------------------
 
 To build and install PowerTOP type the following commands, 
-	./configure 
-	./make
-	./make install
+       autoreconf -sfi
+       ./configure
+       make
+       sudo make install
 
 Note: For Android (running Intel Architecture ) there is a Android.mk 
 that was provided by community members, and at this time is supported
-- 
1.9.1