All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Terje Bergström" <tbergstrom@nvidia.com>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-tegra@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	"Grant Likely" <grant.likely@linaro.org>
Subject: Re: [patch] drm/tegra: sor - missing unlock on error
Date: Mon, 14 Jul 2014 06:53:48 +0000	[thread overview]
Message-ID: <20140714065346.GF2081@ulmo> (raw)
In-Reply-To: <20140611070608.GD16443@mwanda>

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

On Wed, Jun 11, 2014 at 10:06:09AM +0300, Dan Carpenter wrote:
> We should unlock before returning the error code.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
> index 27c979b..64f57fa 100644
> --- a/drivers/gpu/drm/tegra/sor.c
> +++ b/drivers/gpu/drm/tegra/sor.c
> @@ -516,7 +516,7 @@ static int tegra_output_sor_enable(struct tegra_output *output)
>  		if (err < 0) {
>  			dev_err(sor->dev, "failed to probe eDP link: %d\n",
>  				err);
> -			return err;
> +			goto unlock;
>  		}
>  	}
>  

Applied, thanks.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Terje Bergström" <tbergstrom@nvidia.com>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-tegra@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	"Grant Likely" <grant.likely@linaro.org>
Subject: Re: [patch] drm/tegra: sor - missing unlock on error
Date: Mon, 14 Jul 2014 08:53:48 +0200	[thread overview]
Message-ID: <20140714065346.GF2081@ulmo> (raw)
In-Reply-To: <20140611070608.GD16443@mwanda>


[-- Attachment #1.1: Type: text/plain, Size: 636 bytes --]

On Wed, Jun 11, 2014 at 10:06:09AM +0300, Dan Carpenter wrote:
> We should unlock before returning the error code.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
> index 27c979b..64f57fa 100644
> --- a/drivers/gpu/drm/tegra/sor.c
> +++ b/drivers/gpu/drm/tegra/sor.c
> @@ -516,7 +516,7 @@ static int tegra_output_sor_enable(struct tegra_output *output)
>  		if (err < 0) {
>  			dev_err(sor->dev, "failed to probe eDP link: %d\n",
>  				err);
> -			return err;
> +			goto unlock;
>  		}
>  	}
>  

Applied, thanks.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-07-14  6:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11  7:06 [patch] drm/tegra: sor - missing unlock on error Dan Carpenter
2014-06-11  7:06 ` Dan Carpenter
2014-07-14  6:53 ` Thierry Reding [this message]
2014-07-14  6:53   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714065346.GF2081@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=grant.likely@linaro.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tbergstrom@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.