From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lucas Tanure <tanure@linux.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: Clean up binder_send_failed_reply
Date: Mon, 14 Jul 2014 11:22:15 +0300 [thread overview]
Message-ID: <20140714082215.GI25880@mwanda> (raw)
In-Reply-To: <20140713140834.GA5387@archDesk>
On Sun, Jul 13, 2014 at 11:08:34AM -0300, Lucas Tanure wrote:
> Kernel coding style. Remove useless else statement after return.
>
You introduce a GCC warning.
drivers/staging/android/binder.c: In function ‘binder_send_failed_reply’:
drivers/staging/android/binder.c:1217:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
regards,
dan carpenter
prev parent reply other threads:[~2014-07-14 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 14:08 [PATCH] staging: android: Clean up binder_send_failed_reply Lucas Tanure
2014-07-14 8:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714082215.GI25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tanure@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.