* [PATCH] staging: android: Clean up binder_send_failed_reply
@ 2014-07-13 14:08 Lucas Tanure
2014-07-14 8:22 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Lucas Tanure @ 2014-07-13 14:08 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, devel, linux-kernel
Kernel coding style. Remove useless else statement after return.
Signed-off-by: Lucas Tanure <tanure@linux.com>
---
drivers/staging/android/binder.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 14714a6..eee80fb 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -1210,24 +1210,23 @@ static void binder_send_failed_reply(struct binder_transaction *t,
target_thread->return_error);
}
return;
- } else {
- struct binder_transaction *next = t->from_parent;
+ }
+ struct binder_transaction *next = t->from_parent;
- binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
- "send failed reply for transaction %d, target dead\n",
- t->debug_id);
+ binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
+ "send failed reply for transaction %d, target dead\n",
+ t->debug_id);
- binder_pop_transaction(target_thread, t);
- if (next == NULL) {
- binder_debug(BINDER_DEBUG_DEAD_BINDER,
- "reply failed, no target thread at root\n");
- return;
- }
- t = next;
+ binder_pop_transaction(target_thread, t);
+ if (next == NULL) {
binder_debug(BINDER_DEBUG_DEAD_BINDER,
- "reply failed, no target thread -- retry %d\n",
- t->debug_id);
+ "reply failed, no target thread at root\n");
+ return;
}
+ t = next;
+ binder_debug(BINDER_DEBUG_DEAD_BINDER,
+ "reply failed, no target thread -- retry %d\n",
+ t->debug_id);
}
}
--
2.0.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-14 8:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-13 14:08 [PATCH] staging: android: Clean up binder_send_failed_reply Lucas Tanure
2014-07-14 8:22 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.