All of lore.kernel.org
 help / color / mirror / Atom feed
From: b.galvani@gmail.com (Beniamino Galvani)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: rk3188-radxarock: add GPIO IR receiver node
Date: Mon, 14 Jul 2014 21:04:26 +0200	[thread overview]
Message-ID: <20140714190355.GA16904@gmail.com> (raw)
In-Reply-To: <2390327.HZxnbJmfOO@diego>

On Sun, Jul 13, 2014 at 02:37:40PM +0200, Heiko St?bner wrote:
> Am Sonntag, 13. Juli 2014, 14:10:01 schrieb Beniamino Galvani:
> > This adds a device tree node for the infrared receiver connected to a
> > GPIO pin on the Radxa Rock.
> > 
> > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> > ---
> >  arch/arm/boot/dts/rk3188-radxarock.dts |   13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts
> > b/arch/arm/boot/dts/rk3188-radxarock.dts index 19d45b4..1d87bcb 100644
> > --- a/arch/arm/boot/dts/rk3188-radxarock.dts
> > +++ b/arch/arm/boot/dts/rk3188-radxarock.dts
> > @@ -23,6 +23,13 @@
> >  		reg = <0x60000000 0x80000000>;
> >  	};
> > 
> > +	ir_recv: ir-receiver {
> > +		compatible = "gpio-ir-receiver";
> > +		gpios = <&gpio0 10 1>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&ir_recv_pin>;
> > +	};
> > +
> 
> hmm, on second glance, I'm actually not sure if this shouldn't belong in the 
> soc subnode, like the gpio-keys and leds.

(adding devicetree mailing list)

I placed the IR receiver under the root node after looking at what
other boards do, for example:

  imx6dl-hummingboard.dts
  imx6qdl-cubox-i.dtsi
  dove-cubox.dts

On the other hand, if gpio-keys and leds are under the soc node
probably it makes sense to follow the same rule also for the IR
receiver.

Beniamino

WARNING: multiple messages have this Message-ID (diff)
From: Beniamino Galvani <b.galvani@gmail.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: rk3188-radxarock: add GPIO IR receiver node
Date: Mon, 14 Jul 2014 21:04:26 +0200	[thread overview]
Message-ID: <20140714190355.GA16904@gmail.com> (raw)
In-Reply-To: <2390327.HZxnbJmfOO@diego>

On Sun, Jul 13, 2014 at 02:37:40PM +0200, Heiko Stübner wrote:
> Am Sonntag, 13. Juli 2014, 14:10:01 schrieb Beniamino Galvani:
> > This adds a device tree node for the infrared receiver connected to a
> > GPIO pin on the Radxa Rock.
> > 
> > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> > ---
> >  arch/arm/boot/dts/rk3188-radxarock.dts |   13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts
> > b/arch/arm/boot/dts/rk3188-radxarock.dts index 19d45b4..1d87bcb 100644
> > --- a/arch/arm/boot/dts/rk3188-radxarock.dts
> > +++ b/arch/arm/boot/dts/rk3188-radxarock.dts
> > @@ -23,6 +23,13 @@
> >  		reg = <0x60000000 0x80000000>;
> >  	};
> > 
> > +	ir_recv: ir-receiver {
> > +		compatible = "gpio-ir-receiver";
> > +		gpios = <&gpio0 10 1>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&ir_recv_pin>;
> > +	};
> > +
> 
> hmm, on second glance, I'm actually not sure if this shouldn't belong in the 
> soc subnode, like the gpio-keys and leds.

(adding devicetree mailing list)

I placed the IR receiver under the root node after looking at what
other boards do, for example:

  imx6dl-hummingboard.dts
  imx6qdl-cubox-i.dtsi
  dove-cubox.dts

On the other hand, if gpio-keys and leds are under the soc node
probably it makes sense to follow the same rule also for the IR
receiver.

Beniamino

  reply	other threads:[~2014-07-14 19:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-13 12:10 [PATCH] ARM: dts: rk3188-radxarock: add GPIO IR receiver node Beniamino Galvani
2014-07-13 12:10 ` Beniamino Galvani
2014-07-13 12:37 ` Heiko Stübner
2014-07-13 12:37   ` Heiko Stübner
2014-07-14 19:04   ` Beniamino Galvani [this message]
2014-07-14 19:04     ` Beniamino Galvani
2014-07-22 21:45     ` Heiko Stübner
2014-07-22 21:45       ` Heiko Stübner
2014-07-22 21:45       ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714190355.GA16904@gmail.com \
    --to=b.galvani@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.