All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
	clemens@ladisch.de, jdelvare@suse.de, rdunlap@infradead.org,
	bhelgaas@google.com, lm-sensors@lm-sensors.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH] hwmon, k10temp: Add support for AMD F15h M60h processor
Date: Mon, 14 Jul 2014 13:06:12 -0700	[thread overview]
Message-ID: <20140714200612.GA29123@roeck-us.net> (raw)
In-Reply-To: <53C4368E.9090103@amd.com>

On Mon, Jul 14, 2014 at 02:59:10PM -0500, Aravind Gopalakrishnan wrote:
> On 7/14/2014 2:51 PM, Borislav Petkov wrote:
> >On Mon, Jul 14, 2014 at 03:23:08PM -0500, Aravind Gopalakrishnan wrote:
> >>@@ -211,6 +228,7 @@ static const struct pci_device_id k10temp_id_table[] = {
> >>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_NB_F3) },
> >>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M10H_F3) },
> >>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M30H_NB_F3) },
> >>+	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M60H_NB_F3) },
> >>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_NB_F3) },
> >>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_M30H_NB_F3) },
> >>  	{}
> >>diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> >>index 7fa3173..3c8e328 100644
> >>--- a/include/linux/pci_ids.h
> >>+++ b/include/linux/pci_ids.h
> >>@@ -520,6 +520,7 @@
> >>  #define PCI_DEVICE_ID_AMD_15H_M10H_F3	0x1403
> >>  #define PCI_DEVICE_ID_AMD_15H_M30H_NB_F3 0x141d
> >>  #define PCI_DEVICE_ID_AMD_15H_M30H_NB_F4 0x141e
> >>+#define PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 0x1573
> >I'm assuming this is used somewhere else besides k10temp.c?
> >
> 
> Yeah, will most likely need to add EDAC bits. But that is something
> I can't test now.
> 
Sorry, I can not add this to a common file unless it is used elsewhere.
I would suggest to add it locally for now. It can be moved to the
common file once it is used elsewhere.

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
	clemens@ladisch.de, jdelvare@suse.de, rdunlap@infradead.org,
	bhelgaas@google.com, lm-sensors@lm-sensors.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon, k10temp: Add support for AMD F15h M60h processor
Date: Mon, 14 Jul 2014 20:06:12 +0000	[thread overview]
Message-ID: <20140714200612.GA29123@roeck-us.net> (raw)
In-Reply-To: <53C4368E.9090103@amd.com>

On Mon, Jul 14, 2014 at 02:59:10PM -0500, Aravind Gopalakrishnan wrote:
> On 7/14/2014 2:51 PM, Borislav Petkov wrote:
> >On Mon, Jul 14, 2014 at 03:23:08PM -0500, Aravind Gopalakrishnan wrote:
> >>@@ -211,6 +228,7 @@ static const struct pci_device_id k10temp_id_table[] = {
> >>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_NB_F3) },
> >>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M10H_F3) },
> >>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M30H_NB_F3) },
> >>+	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M60H_NB_F3) },
> >>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_NB_F3) },
> >>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_M30H_NB_F3) },
> >>  	{}
> >>diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> >>index 7fa3173..3c8e328 100644
> >>--- a/include/linux/pci_ids.h
> >>+++ b/include/linux/pci_ids.h
> >>@@ -520,6 +520,7 @@
> >>  #define PCI_DEVICE_ID_AMD_15H_M10H_F3	0x1403
> >>  #define PCI_DEVICE_ID_AMD_15H_M30H_NB_F3 0x141d
> >>  #define PCI_DEVICE_ID_AMD_15H_M30H_NB_F4 0x141e
> >>+#define PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 0x1573
> >I'm assuming this is used somewhere else besides k10temp.c?
> >
> 
> Yeah, will most likely need to add EDAC bits. But that is something
> I can't test now.
> 
Sorry, I can not add this to a common file unless it is used elsewhere.
I would suggest to add it locally for now. It can be moved to the
common file once it is used elsewhere.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2014-07-14 20:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 20:23 [PATCH] hwmon, k10temp: Add support for AMD F15h M60h processor Aravind Gopalakrishnan
2014-07-14 20:23 ` [lm-sensors] " Aravind Gopalakrishnan
2014-07-14 19:51 ` Borislav Petkov
2014-07-14 19:51   ` [lm-sensors] " Borislav Petkov
2014-07-14 19:59   ` Aravind Gopalakrishnan
2014-07-14 19:59     ` [lm-sensors] " Aravind Gopalakrishnan
2014-07-14 20:06     ` Guenter Roeck [this message]
2014-07-14 20:06       ` Guenter Roeck
2014-07-14 20:21   ` Clemens Ladisch
2014-07-14 20:21     ` [lm-sensors] " Clemens Ladisch
2014-07-14 20:33     ` Guenter Roeck
2014-07-14 20:33       ` [lm-sensors] " Guenter Roeck
2014-07-15  7:41       ` Clemens Ladisch
2014-07-15  7:41         ` [lm-sensors] " Clemens Ladisch
2014-07-15  9:03         ` Guenter Roeck
2014-07-15  9:03           ` [lm-sensors] " Guenter Roeck
2014-07-17 15:22           ` Aravind Gopalakrishnan
2014-07-17 15:22             ` [lm-sensors] " Aravind Gopalakrishnan
2014-07-17 16:02             ` Clemens Ladisch
2014-07-17 16:02               ` [lm-sensors] " Clemens Ladisch
  -- strict thread matches above, loose matches on Subject: below --
2014-03-11 21:25 [lm-sensors] [PATCH] hwmon, k10temp: Add support for AMD F16 M30h processor Aravind Gopalakrishnan
2014-03-11 21:25 ` Aravind Gopalakrishnan
2014-03-12  3:06 ` [lm-sensors] " Guenter Roeck
2014-03-12  3:06   ` Guenter Roeck
2014-03-12  9:25   ` [lm-sensors] " Jean Delvare
2014-03-12  9:25     ` Jean Delvare
2014-03-12 14:34     ` [lm-sensors] " Aravind Gopalakrishnan
2014-03-12 14:34       ` Aravind Gopalakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714200612.GA29123@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=aravind.gopalakrishnan@amd.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=clemens@ladisch.de \
    --cc=jdelvare@suse.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.