[meta-oe][PATCH] stop trying to remove folders that do not exist

[meta-oe][PATCH] stop trying to remove folders that do not exist

[Stephano Cetola]

From: Stephano Cetola <scetola@reachtech.com>

The directory ${D}/${TMPDIR} does not exist. This patch removes code
that was calling rm and rmdir on that location.

Signed-off-by: Stephano Cetola <scetola@reachtech.com>
---
 meta-oe/recipes-devtools/php/php.inc |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc
index b1bf79c..000316b 100644
--- a/meta-oe/recipes-devtools/php/php.inc
+++ b/meta-oe/recipes-devtools/php/php.inc
@@ -90,6 +90,12 @@ do_install_append_pn-php() {
     sed -i 's:=/var:=${localstatedir}:g' ${B}/sapi/fpm/init.d.php-fpm
     install -m 0755 ${B}/sapi/fpm/init.d.php-fpm ${D}${sysconfdir}/init.d/php-fpm
     TMP=`dirname ${D}/${TMPDIR}`
+    bbwarn "D"
+    bbwarn ${D}
+    bbwarn "TMPDIR"
+    bbwarn ${TMPDIR}
+    bbwarn "TMP"
+    bbwarn ${TMP}
     while test ${TMP} != ${D}; do
         rmdir ${TMP}
         TMP=`dirname ${TMP}`;
-- 
1.7.10.4

Re: [meta-oe][PATCH] stop trying to remove folders that do not exist

[Gary Thomas]

On 2014-07-15 12:01, Stephano Cetola wrote:
> From: Stephano Cetola <scetola@reachtech.com>
>
> The directory ${D}/${TMPDIR} does not exist. This patch removes code
> that was calling rm and rmdir on that location.
>
> Signed-off-by: Stephano Cetola <scetola@reachtech.com>
> ---
>   meta-oe/recipes-devtools/php/php.inc |    6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc
> index b1bf79c..000316b 100644
> --- a/meta-oe/recipes-devtools/php/php.inc
> +++ b/meta-oe/recipes-devtools/php/php.inc
> @@ -90,6 +90,12 @@ do_install_append_pn-php() {
>       sed -i 's:=/var:=${localstatedir}:g' ${B}/sapi/fpm/init.d.php-fpm
>       install -m 0755 ${B}/sapi/fpm/init.d.php-fpm ${D}${sysconfdir}/init.d/php-fpm
>       TMP=`dirname ${D}/${TMPDIR}`
> +    bbwarn "D"
> +    bbwarn ${D}
> +    bbwarn "TMPDIR"
> +    bbwarn ${TMPDIR}
> +    bbwarn "TMP"
> +    bbwarn ${TMP}
>       while test ${TMP} != ${D}; do
>           rmdir ${TMP}
>           TMP=`dirname ${TMP}`;
>

The actual patch does not do what the summary claims.  Are you
sure this is what you wanted to send/commit?

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-oe][PATCH] stop trying to remove folders that do not exist

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]

On Tue, Jul 15, 2014 at 11:01:55AM -0700, Stephano Cetola wrote:
> From: Stephano Cetola <scetola@reachtech.com>
> 
> The directory ${D}/${TMPDIR} does not exist. This patch removes code
> that was calling rm and rmdir on that location.

this doesn't match with the diff

> 
> Signed-off-by: Stephano Cetola <scetola@reachtech.com>
> ---
>  meta-oe/recipes-devtools/php/php.inc |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc
> index b1bf79c..000316b 100644
> --- a/meta-oe/recipes-devtools/php/php.inc
> +++ b/meta-oe/recipes-devtools/php/php.inc
> @@ -90,6 +90,12 @@ do_install_append_pn-php() {
>      sed -i 's:=/var:=${localstatedir}:g' ${B}/sapi/fpm/init.d.php-fpm
>      install -m 0755 ${B}/sapi/fpm/init.d.php-fpm ${D}${sysconfdir}/init.d/php-fpm
>      TMP=`dirname ${D}/${TMPDIR}`
> +    bbwarn "D"
> +    bbwarn ${D}
> +    bbwarn "TMPDIR"
> +    bbwarn ${TMPDIR}
> +    bbwarn "TMP"
> +    bbwarn ${TMP}
>      while test ${TMP} != ${D}; do
>          rmdir ${TMP}
>          TMP=`dirname ${TMP}`;
> -- 
> 1.7.10.4
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-oe][PATCH] stop trying to remove folders that do not exist

[Stephano Cetola]

Stephano Cetola <stephanoc <at> gmail.com> writes:

> 
> From: Stephano Cetola <scetola <at> reachtech.com>
> 
> The directory ${D}/${TMPDIR} does not exist. This patch removes code
> that was calling rm and rmdir on that location.
> 
> Signed-off-by: Stephano Cetola <scetola <at> reachtech.com>
> ---
>  meta-oe/recipes-devtools/php/php.inc |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-
devtools/php/php.inc
> index b1bf79c..000316b 100644
> --- a/meta-oe/recipes-devtools/php/php.inc
> +++ b/meta-oe/recipes-devtools/php/php.inc
>  <at>  <at>  -90,6 +90,12  <at>  <at>  do_install_append_pn-php() {
>      sed -i 's:=/var:=${localstatedir}:g' ${B}/sapi/fpm/init.d.php-fpm
>      install -m 0755 ${B}/sapi/fpm/init.d.php-fpm 
${D}${sysconfdir}/init.d/php-fpm
>      TMP=`dirname ${D}/${TMPDIR}`
> +    bbwarn "D"
> +    bbwarn ${D}
> +    bbwarn "TMPDIR"
> +    bbwarn ${TMPDIR}
> +    bbwarn "TMP"
> +    bbwarn ${TMP}
>      while test ${TMP} != ${D}; do
>          rmdir ${TMP}
>          TMP=`dirname ${TMP}`;

Sorry for the mixup. I was ssh'd into my testing machine at work and thought 
I was committing from my local machine. I have resubmitted. Sorry for the 
confusion.

-Stephano