From: Jeff King <peff@peff.net>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig
Date: Tue, 15 Jul 2014 19:42:40 -0400 [thread overview]
Message-ID: <20140715234240.GB5572@peff.net> (raw)
In-Reply-To: <1405467179-16064-4-git-send-email-jacob.e.keller@intel.com>
On Tue, Jul 15, 2014 at 04:32:59PM -0700, Jacob Keller wrote:
> +static void error_bad_sort_config(const char *err, va_list params)
> +{
> + vreportf("warning: tag.sort has ", err, params);
> +}
This feels a little like an abuse of the "prefix" field of vreportf, but
as you probably saw in my "for fun" patch, doing it right means
formatting into a buffer and then reformatting that (which we're
already doing again in vreportf, but less flexibly). I dunno.
At any rate, this should be marked for translation, no?
-Peff
next prev parent reply other threads:[~2014-07-15 23:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 23:32 [PATCH v9 1/4] usage: make error functions a stack Jacob Keller
2014-07-15 23:32 ` [PATCH v9 2/4] tag: fix --sort tests to use cat<<-\EOF format Jacob Keller
2014-07-15 23:32 ` [PATCH v9 3/4] tag: update parsing to be more precise regarding errors Jacob Keller
2014-07-15 23:32 ` [PATCH v9 4/4] tag: support configuring --sort via .gitconfig Jacob Keller
2014-07-15 23:42 ` Jeff King [this message]
2014-07-15 23:46 ` Keller, Jacob E
2014-07-16 17:59 ` Junio C Hamano
2014-07-16 19:51 ` Keller, Jacob E
2014-07-16 21:13 ` Keller, Jacob E
2014-07-16 21:40 ` Junio C Hamano
2014-07-16 21:42 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715234240.GB5572@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.