From: Junio C Hamano <gitster@pobox.com>
To: "Keller\, Jacob E" <jacob.e.keller@intel.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
"peff\@peff.net" <peff@peff.net>
Subject: Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig
Date: Wed, 16 Jul 2014 14:40:54 -0700 [thread overview]
Message-ID: <xmqq1ttlrnh5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1405545219.15392.17.camel@jekeller-desk1.amr.corp.intel.com> (Jacob E. Keller's message of "Wed, 16 Jul 2014 21:13:39 +0000")
"Keller, Jacob E" <jacob.e.keller@intel.com> writes:
>> After all, it seems to me that the one in
>>
>> http://thread.gmane.org/gmane.comp.version-control.git/253346
>>
>> struck the right balance among various abuses; let's use the error
>> reporter from that version, instead of going down this rabbit hole.
>>
>> Thanks.
>
> So is that patch series version acceptable then? Or should I spin one
> again that is in that vein?
I do not offhand know what other changes you had in v9 since
$gmane/253346, so I'll leave it up to you. If the only difference
is the error reporting codepath, and you are happy with what I have
in my tree
$ git log -p --reverse -3 a93d886b9
then we can proceed with that version. Have there been any issues
raised on that older version other than error reporting?
next prev parent reply other threads:[~2014-07-16 21:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 23:32 [PATCH v9 1/4] usage: make error functions a stack Jacob Keller
2014-07-15 23:32 ` [PATCH v9 2/4] tag: fix --sort tests to use cat<<-\EOF format Jacob Keller
2014-07-15 23:32 ` [PATCH v9 3/4] tag: update parsing to be more precise regarding errors Jacob Keller
2014-07-15 23:32 ` [PATCH v9 4/4] tag: support configuring --sort via .gitconfig Jacob Keller
2014-07-15 23:42 ` Jeff King
2014-07-15 23:46 ` Keller, Jacob E
2014-07-16 17:59 ` Junio C Hamano
2014-07-16 19:51 ` Keller, Jacob E
2014-07-16 21:13 ` Keller, Jacob E
2014-07-16 21:40 ` Junio C Hamano [this message]
2014-07-16 21:42 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1ttlrnh5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.