From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: forest@alittletooquiet.net, tvboxspy@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH V5 6/6] staging: vt6556: Replace printk by dev_warn
Date: Wed, 16 Jul 2014 04:54:33 +0000 [thread overview]
Message-ID: <20140716045433.GA32044@kroah.com> (raw)
In-Reply-To: <1405457209-6584-2-git-send-email-peter.senna@gmail.com>
On Tue, Jul 15, 2014 at 10:46:49PM +0200, Peter Senna Tschudin wrote:
> This patch fixes a checkpatch warning by replacing printk
> by dev_warn. Tested by compilation only.
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> Changes from V4:
> - use dev_warn instead of pr_warn
>
> drivers/staging/vt6656/main_usb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 7567646..6708e98 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -527,7 +527,8 @@ static void usb_device_reset(struct vnt_private *pDevice)
>
> status = usb_reset_device(pDevice->usb);
> if (status)
> - printk("usb_device_reset fail status=%d\n",status);
> + dev_warn(&pDevice->usb->dev,
> + "usb_device_reset fail status=%d\n", status);
> }
>
> static void device_free_int_bufs(struct vnt_private *priv)
This doesn't apply to my latest tree, can you please refresh it and
resend?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: forest@alittletooquiet.net, tvboxspy@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH V5 6/6] staging: vt6556: Replace printk by dev_warn
Date: Tue, 15 Jul 2014 21:54:33 -0700 [thread overview]
Message-ID: <20140716045433.GA32044@kroah.com> (raw)
In-Reply-To: <1405457209-6584-2-git-send-email-peter.senna@gmail.com>
On Tue, Jul 15, 2014 at 10:46:49PM +0200, Peter Senna Tschudin wrote:
> This patch fixes a checkpatch warning by replacing printk
> by dev_warn. Tested by compilation only.
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> Changes from V4:
> - use dev_warn instead of pr_warn
>
> drivers/staging/vt6656/main_usb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 7567646..6708e98 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -527,7 +527,8 @@ static void usb_device_reset(struct vnt_private *pDevice)
>
> status = usb_reset_device(pDevice->usb);
> if (status)
> - printk("usb_device_reset fail status=%d\n",status);
> + dev_warn(&pDevice->usb->dev,
> + "usb_device_reset fail status=%d\n", status);
> }
>
> static void device_free_int_bufs(struct vnt_private *priv)
This doesn't apply to my latest tree, can you please refresh it and
resend?
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-16 4:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 20:46 [PATCH V5 5/6] staging: vt6556: Cleanup indentation on statements Peter Senna Tschudin
2014-07-15 20:46 ` Peter Senna Tschudin
2014-07-15 20:46 ` [PATCH V5 6/6] staging: vt6556: Replace printk by dev_warn Peter Senna Tschudin
2014-07-15 20:46 ` Peter Senna Tschudin
2014-07-16 4:54 ` Greg KH [this message]
2014-07-16 4:54 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716045433.GA32044@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.