From: Wolfram Sang <wsa@the-dreams.de>
To: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
naveenkrishna.ch@gmail.com, linux-arm-kernel@lists.infradead.org,
sjg@chromium.org, linux-kernel@vger.kernel.org, cpgs@samsung.com,
broonie@kernel.org
Subject: Re: [PATCH 2/2 v2] i2c: exynos5: remove extra line and fix an assignment
Date: Thu, 17 Jul 2014 12:02:41 +0200 [thread overview]
Message-ID: <20140717100241.GC2740@katana> (raw)
In-Reply-To: <1403759698-15624-2-git-send-email-ch.naveen@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Thu, Jun 26, 2014 at 10:44:58AM +0530, Naveen Krishna Chatradhi wrote:
> This patch does the following in exynos5_i2c_message_start() function
> 1. Fixes an assignment
> As, "i2c_auto_conf" is initialized to '0' at the beginning of the
> function and HSI2C_READ_WRITE is defined as (1u << 16)
>
> Using "|=" for the first assignment is more readable.
>
> 2. Removes an extra line
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2 v2] i2c: exynos5: remove extra line and fix an assignment
Date: Thu, 17 Jul 2014 12:02:41 +0200 [thread overview]
Message-ID: <20140717100241.GC2740@katana> (raw)
In-Reply-To: <1403759698-15624-2-git-send-email-ch.naveen@samsung.com>
On Thu, Jun 26, 2014 at 10:44:58AM +0530, Naveen Krishna Chatradhi wrote:
> This patch does the following in exynos5_i2c_message_start() function
> 1. Fixes an assignment
> As, "i2c_auto_conf" is initialized to '0' at the beginning of the
> function and HSI2C_READ_WRITE is defined as (1u << 16)
>
> Using "|=" for the first assignment is more readable.
>
> 2. Removes an extra line
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Applied to for-next, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140717/b4f9cc30/attachment.sig>
next prev parent reply other threads:[~2014-07-17 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 5:14 [PATCH 1/2 v2] i2c: exynos5: remove an unnecessary read of FIFO_STATUS register Naveen Krishna Chatradhi
2014-06-26 5:14 ` Naveen Krishna Chatradhi
2014-06-26 5:14 ` Naveen Krishna Chatradhi
2014-06-26 5:14 ` [PATCH 2/2 v2] i2c: exynos5: remove extra line and fix an assignment Naveen Krishna Chatradhi
2014-06-26 5:14 ` Naveen Krishna Chatradhi
2014-07-17 10:02 ` Wolfram Sang [this message]
2014-07-17 10:02 ` Wolfram Sang
2014-07-17 10:02 ` [PATCH 1/2 v2] i2c: exynos5: remove an unnecessary read of FIFO_STATUS register Wolfram Sang
2014-07-17 10:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717100241.GC2740@katana \
--to=wsa@the-dreams.de \
--cc=broonie@kernel.org \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.