From: Theodore Ts'o <tytso@mit.edu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>, X86 ML <x86@kernel.org>,
Bandan Das <bsd@redhat.com>, Gleb Natapov <gleb@kernel.org>,
kvm list <kvm@vger.kernel.org>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Daniel Borkmann <dborkman@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v3 2/5] random,x86: Add arch_get_slow_rng_u64
Date: Thu, 17 Jul 2014 06:33:24 -0400 [thread overview]
Message-ID: <20140717103324.GJ1491@thunk.org> (raw)
In-Reply-To: <53C75733.8060507@zytor.com>
On Wed, Jul 16, 2014 at 09:55:15PM -0700, H. Peter Anvin wrote:
> On 07/16/2014 05:03 PM, Andy Lutomirski wrote:
> >>
> > I meant that prandom isn't using rdrand for early seeding.
> >
>
> We should probably fix that.
It wouldn't hurt to explicitly use arch_get_random_long() in prandom,
but it does use get_random_bytes() in early seed, and for CPU's with
RDRAND present, we do use it in init_std_data() in
drivers/char/random.c, so prandom is already getting initialized via
an RNG (which is effectively a DRBG even if it doesn't pass all of
NIST's rules) which is derived from RDRAND.
Cheers,
- Ted
next prev parent reply other threads:[~2014-07-17 10:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 21:45 [PATCH v3 0/5] random,x86,kvm: Add and use MSR_KVM_GET_RNG_SEED Andy Lutomirski
2014-07-16 21:45 ` [PATCH v3 1/5] x86,kvm: Add MSR_KVM_GET_RNG_SEED and a matching feature bit Andy Lutomirski
2014-07-17 17:43 ` Andrew Honig
2014-07-17 17:45 ` Andy Lutomirski
2014-07-16 21:45 ` [PATCH v3 2/5] random,x86: Add arch_get_slow_rng_u64 Andy Lutomirski
2014-07-16 21:59 ` H. Peter Anvin
2014-07-16 22:13 ` Andy Lutomirski
2014-07-16 22:40 ` Andy Lutomirski
2014-07-16 22:59 ` H. Peter Anvin
2014-07-17 0:03 ` Andy Lutomirski
2014-07-17 4:55 ` H. Peter Anvin
2014-07-17 10:33 ` Theodore Ts'o [this message]
2014-07-17 16:39 ` H. Peter Anvin
2014-07-17 17:12 ` Andy Lutomirski
2014-07-17 17:32 ` Theodore Ts'o
2014-07-17 17:34 ` Andy Lutomirski
2014-07-17 18:42 ` Hannes Frederic Sowa
2014-07-17 19:15 ` Andy Lutomirski
2014-07-17 12:39 ` Daniel Borkmann
2014-07-16 21:45 ` [PATCH v3 3/5] random: Seed pools from arch_get_slow_rng_u64 at startup Andy Lutomirski
2014-07-16 21:45 ` [PATCH v3 4/5] random: Log how many bits we managed to seed with in init_std_data Andy Lutomirski
2014-07-16 21:45 ` [PATCH v3 5/5] x86,kaslr: Use MSR_KVM_GET_RNG_SEED for KASLR if available Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717103324.GJ1491@thunk.org \
--to=tytso@mit.edu \
--cc=bsd@redhat.com \
--cc=dborkman@redhat.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=pbonzini@redhat.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=vatsa@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.