From: Andy Lutomirski <luto@amacapital.net>
To: kvm@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Theodore Ts'o <tytso@mit.edu>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
x86@kernel.org
Cc: Daniel Borkmann <dborkman@redhat.com>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
bsd@redhat.com, Andy Lutomirski <luto@amacapital.net>
Subject: [PATCH v3 0/5] random,x86,kvm: Add and use MSR_KVM_GET_RNG_SEED
Date: Wed, 16 Jul 2014 14:45:32 -0700 [thread overview]
Message-ID: <cover.1405546879.git.luto@amacapital.net> (raw)
This introduces and uses a very simple synchronous mechanism to get
/dev/urandom-style bits appropriate for initial KVM PV guest RNG
seeding.
virtio-rng is not suitable for this purpose. It's too difficult to
enumerate for use in early boot (e.g. KASLR, which runs before we
even have an IDT). It also provides /dev/random-style bits, which
means that making guest boot wait for virtio-rng is unacceptably
slow, and doing it asynchronously means that /dev/urandom might
still be predictable when userspace starts.
I sent the corresponding kvm-unit-tests and qemu changes separately.
There's room for bikeshedding on the same arch_get_slow_rng_u64. I
considered arch_get_rng_seed_u64, but that could be confused with
arch_get_random_seed_long, which is not interchangeable.
Changes from v2:
- Bisection fix (patch 2 had a misplaced brace). The final states is
identical to that of v2.
- Improve the 0/5 description a little bit.
Changes from v1:
- Split patches 2 and 3
- Log all arch sources in init_std_data
- Fix the 32-bit kaslr build
Andy Lutomirski (5):
x86,kvm: Add MSR_KVM_GET_RNG_SEED and a matching feature bit
random,x86: Add arch_get_slow_rng_u64
random: Seed pools from arch_get_slow_rng_u64 at startup
random: Log how many bits we managed to seed with in init_std_data
x86,kaslr: Use MSR_KVM_GET_RNG_SEED for KASLR if available
Documentation/virtual/kvm/cpuid.txt | 3 +++
arch/x86/Kconfig | 4 ++++
arch/x86/boot/compressed/aslr.c | 27 +++++++++++++++++++++++++++
arch/x86/include/asm/archslowrng.h | 30 ++++++++++++++++++++++++++++++
arch/x86/include/asm/processor.h | 21 ++++++++++++++++++---
arch/x86/include/uapi/asm/kvm_para.h | 2 ++
arch/x86/kernel/kvm.c | 22 ++++++++++++++++++++++
arch/x86/kvm/cpuid.c | 3 ++-
arch/x86/kvm/x86.c | 4 ++++
drivers/char/random.c | 20 ++++++++++++++++++--
include/linux/random.h | 9 +++++++++
11 files changed, 139 insertions(+), 6 deletions(-)
create mode 100644 arch/x86/include/asm/archslowrng.h
--
1.9.3
next reply other threads:[~2014-07-16 21:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 21:45 Andy Lutomirski [this message]
2014-07-16 21:45 ` [PATCH v3 1/5] x86,kvm: Add MSR_KVM_GET_RNG_SEED and a matching feature bit Andy Lutomirski
2014-07-17 17:43 ` Andrew Honig
2014-07-17 17:45 ` Andy Lutomirski
2014-07-16 21:45 ` [PATCH v3 2/5] random,x86: Add arch_get_slow_rng_u64 Andy Lutomirski
2014-07-16 21:59 ` H. Peter Anvin
2014-07-16 22:13 ` Andy Lutomirski
2014-07-16 22:40 ` Andy Lutomirski
2014-07-16 22:59 ` H. Peter Anvin
2014-07-17 0:03 ` Andy Lutomirski
2014-07-17 4:55 ` H. Peter Anvin
2014-07-17 10:33 ` Theodore Ts'o
2014-07-17 16:39 ` H. Peter Anvin
2014-07-17 17:12 ` Andy Lutomirski
2014-07-17 17:32 ` Theodore Ts'o
2014-07-17 17:34 ` Andy Lutomirski
2014-07-17 18:42 ` Hannes Frederic Sowa
2014-07-17 19:15 ` Andy Lutomirski
2014-07-17 12:39 ` Daniel Borkmann
2014-07-16 21:45 ` [PATCH v3 3/5] random: Seed pools from arch_get_slow_rng_u64 at startup Andy Lutomirski
2014-07-16 21:45 ` [PATCH v3 4/5] random: Log how many bits we managed to seed with in init_std_data Andy Lutomirski
2014-07-16 21:45 ` [PATCH v3 5/5] x86,kaslr: Use MSR_KVM_GET_RNG_SEED for KASLR if available Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1405546879.git.luto@amacapital.net \
--to=luto@amacapital.net \
--cc=bsd@redhat.com \
--cc=dborkman@redhat.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=tytso@mit.edu \
--cc=vatsa@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.