From: Andy Gross <agross@codeaurora.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] dmaengine: qcom_bam_dma: Add descriptor flags
Date: Thu, 17 Jul 2014 13:31:10 -0500 [thread overview]
Message-ID: <20140717183110.GB17951@qualcomm.com> (raw)
In-Reply-To: <20140714163616.GA4387@intel.com>
On Mon, Jul 14, 2014 at 10:06:16PM +0530, Vinod Koul wrote:
> On Fri, May 30, 2014 at 03:49:50PM -0500, Andy Gross wrote:
> > This patch adds support for end of transaction (EOT) and notify when done (NWD)
> > hardware descriptor flags.
> >
> > The EOT flag requests that the peripheral assert an end of transaction interrupt
> > when that descriptor is complete. It also results in special signaling protocol
> > that is used between the attached peripheral and the core using the DMA
> > controller. Clients will specify DMA_PREP_INTERRUPT to enable this flag.
> >
> > The NWD flag requests that the peripheral wait until the data has been fully
> > processed by the peripheral before moving on to the next descriptor. Clients
> > will specify DMA_PREP_FENCE to enable this flag.
>
> I am going to apply this, but pls send a follow up patch to add comments on the
> flags and their behaviour. I think it is required!
Will do.
<snip>
> > #define DESC_FLAG_EOT BIT(14)
> > #define DESC_FLAG_EOB BIT(13)
> > +#define DESC_FLAG_NWD BIT(12)
> explaining behvaiour will help..
In the followup, I'll put in a lengthy description of the INT/EOT/NWD and how
they are used in the signaling to/from the attached peripheral.
Thanks!
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: agross@codeaurora.org (Andy Gross)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: qcom_bam_dma: Add descriptor flags
Date: Thu, 17 Jul 2014 13:31:10 -0500 [thread overview]
Message-ID: <20140717183110.GB17951@qualcomm.com> (raw)
In-Reply-To: <20140714163616.GA4387@intel.com>
On Mon, Jul 14, 2014 at 10:06:16PM +0530, Vinod Koul wrote:
> On Fri, May 30, 2014 at 03:49:50PM -0500, Andy Gross wrote:
> > This patch adds support for end of transaction (EOT) and notify when done (NWD)
> > hardware descriptor flags.
> >
> > The EOT flag requests that the peripheral assert an end of transaction interrupt
> > when that descriptor is complete. It also results in special signaling protocol
> > that is used between the attached peripheral and the core using the DMA
> > controller. Clients will specify DMA_PREP_INTERRUPT to enable this flag.
> >
> > The NWD flag requests that the peripheral wait until the data has been fully
> > processed by the peripheral before moving on to the next descriptor. Clients
> > will specify DMA_PREP_FENCE to enable this flag.
>
> I am going to apply this, but pls send a follow up patch to add comments on the
> flags and their behaviour. I think it is required!
Will do.
<snip>
> > #define DESC_FLAG_EOT BIT(14)
> > #define DESC_FLAG_EOB BIT(13)
> > +#define DESC_FLAG_NWD BIT(12)
> explaining behvaiour will help..
In the followup, I'll put in a lengthy description of the INT/EOT/NWD and how
they are used in the signaling to/from the attached peripheral.
Thanks!
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-07-17 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 20:49 [PATCH] dmaengine: qcom_bam_dma: Add descriptor flags Andy Gross
2014-05-30 20:49 ` Andy Gross
2014-07-14 16:36 ` Vinod Koul
2014-07-14 16:36 ` Vinod Koul
2014-07-17 18:31 ` Andy Gross [this message]
2014-07-17 18:31 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717183110.GB17951@qualcomm.com \
--to=agross@codeaurora.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.