All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Vasily Tarasov <tarasov@vasily.name>
Cc: device-mapper development <dm-devel@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	ejt@redhat.com, Philip Shilane <philip.shilane@emc.com>,
	Sonam Mandal <sonam.dp42@gmail.com>,
	Erez Zadok <ezk@fsl.cs.sunysb.edu>,
	Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: [PATCH RFC 00/10] dm-dedup: device-mapper deduplication target
Date: Fri, 18 Jul 2014 10:44:23 -0400	[thread overview]
Message-ID: <20140718144423.GB4762@redhat.com> (raw)
In-Reply-To: <CAFTzLMNEuPHAp02CHwCfktyWcHdb-rYzSx4ekWHis8QQHvmxNw@mail.gmail.com>

On Fri, Jul 18 2014 at  7:59am -0400,
Vasily Tarasov <tarasov@vasily.name> wrote:

> Hi Mike,
> 
> Thanks for your initial reviewing steps! Here is what we plan to do:
> 
> 1) Address your current comments

Thanks, try to look at how the other DM targets have tables with
arguments that have a fixed position (less flexible than name=value but
tools like lvm2 benefit from the rigidity).
 
> 2) Few people mentioned that our documentation need to be formatted
> better and be more detailed. We'll address this.

Yes, it could be more comprehensive.  And it would be nice if it were
updated to have the same kind of sections/flow that other targets'
Documentation/device-mapper/ files have (e.g. cache.txt and
thin-provisioning.txt).

But overall the plan sounds great.

  parent reply	other threads:[~2014-07-18 14:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28 22:03 [PATCH RFC 00/10] dm-dedup: device-mapper deduplication target Vasily Tarasov
2014-04-29  6:23 ` Bart Van Assche
2014-04-29 13:26   ` Vasily Tarasov
2014-05-05 18:24 ` Mike Snitzer
2014-05-06 13:43   ` Vasily Tarasov
2014-05-06 14:23     ` Mike Snitzer
2014-07-18  2:43     ` Mike Snitzer
2014-07-18 11:59       ` Vasily Tarasov
2014-07-18 13:29         ` Joe Thornber
2014-07-18 14:44         ` Mike Snitzer [this message]
2015-03-06 18:37 ` Vivek Goyal
2015-03-06 23:31   ` Akira Hayakawa
2015-03-07 21:31     ` Vasily Tarasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140718144423.GB4762@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=ejt@redhat.com \
    --cc=ezk@fsl.cs.sunysb.edu \
    --cc=hch@infradead.org \
    --cc=mpatocka@redhat.com \
    --cc=philip.shilane@emc.com \
    --cc=sonam.dp42@gmail.com \
    --cc=tarasov@vasily.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.