All of lore.kernel.org
 help / color / mirror / Atom feed
* curious about libdrm-2.4.41 recipe from meta-ti layer
@ 2014-07-18 11:46 Robert P. J. Day
  2014-07-18 15:30 ` Maupin, Chase
  2014-07-18 15:37 ` Denys Dmytriyenko
  0 siblings, 2 replies; 4+ messages in thread
From: Robert P. J. Day @ 2014-07-18 11:46 UTC (permalink / raw)
  To: meta-ti mailing list


  i was perusing a number of yocto layers looking for cool examples to
use in an upcoming class and ran across this oddity in the meta-ti
layer:

recipes-graphics/drm/libdrm_2.4.41.bb:
  FILESEXTRAPATHS_append := ":${COREBASE}/meta/recipes-graphics/drm/libdrm"

  in all of the layers i've looked at, that is the only example of
*appending* to FILESEXTRAPATHS i've ever seen, so i thought i'd look
closer to see what was going on.

  even though oe-core defines a libdrm recipe file, the meta-ti layer
doesn't use a bbappend for its version. rather, it explicitly adds the
libdrm/ directory from oe-core using a reference to ${COREBASE}, then
adds its own files. that's valid, i guess, it just looks weird and is
the only time i've ever seen that.

  i'm also puzzled that the meta-ti recipe sets:

DEFAULT_PREFERENCE = "-1"

what's that for?  given that the oe-core layer already defines a
recipe for libdrm that has a higher version number, why would the
above line be necessary?

  just trying to understand the rationale behind this unusual
construction.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: curious about libdrm-2.4.41 recipe from meta-ti layer
  2014-07-18 11:46 curious about libdrm-2.4.41 recipe from meta-ti layer Robert P. J. Day
@ 2014-07-18 15:30 ` Maupin, Chase
  2014-07-18 15:44   ` Denys Dmytriyenko
  2014-07-18 15:37 ` Denys Dmytriyenko
  1 sibling, 1 reply; 4+ messages in thread
From: Maupin, Chase @ 2014-07-18 15:30 UTC (permalink / raw)
  To: Robert P. J. Day, meta-ti mailing list

>-----Original Message-----
>From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
>bounces@yoctoproject.org] On Behalf Of Robert P. J. Day
>Sent: Friday, July 18, 2014 6:47 AM
>To: meta-ti mailing list
>Subject: [meta-ti] curious about libdrm-2.4.41 recipe from meta-ti
>layer
>
>
>  i was perusing a number of yocto layers looking for cool
>examples to
>use in an upcoming class and ran across this oddity in the meta-ti
>layer:
>
>recipes-graphics/drm/libdrm_2.4.41.bb:
>  FILESEXTRAPATHS_append := ":${COREBASE}/meta/recipes-
>graphics/drm/libdrm"
>
>  in all of the layers i've looked at, that is the only example of
>*appending* to FILESEXTRAPATHS i've ever seen, so i thought i'd
>look
>closer to see what was going on.
>
>  even though oe-core defines a libdrm recipe file, the meta-ti
>layer
>doesn't use a bbappend for its version. rather, it explicitly adds
>the
>libdrm/ directory from oe-core using a reference to ${COREBASE},
>then
>adds its own files. that's valid, i guess, it just looks weird and
>is
>the only time i've ever seen that.

The recipe also defines using a TI version of libdrm (I don't like that but it is what we have been given from the component team doing this).  So the intent here is to:

1. Define a libdrm that uses the TI modified sources.
2. Use the recipe only for the omap-a15 devices and make that an explicit setting by setting default preference to -1.

This wasn't done as an append because we wanted this only for omap-a15 devices when explicitely set as the preferred version to use and not impact other devices using the later version from oe-core.

As for the reference to COREBASE it is to pick up the GNU_SOURCE_definition.patch file rather than overlaying that as well.

>
>  i'm also puzzled that the meta-ti recipe sets:
>
>DEFAULT_PREFERENCE = "-1"
>
>what's that for?  given that the oe-core layer already defines a
>recipe for libdrm that has a higher version number, why would the
>above line be necessary?
>
>  just trying to understand the rationale behind this unusual
>construction.
>
>rday
>
>--
>
>==================================================================
>======
>Robert P. J. Day                                 Ottawa, Ontario,
>CANADA
>                        http://crashcourse.ca
>
>Twitter:
>http://twitter.com/rpjday
>LinkedIn:
>http://ca.linkedin.com/in/rpjday
>==================================================================
>======
>
>--
>_______________________________________________
>meta-ti mailing list
>meta-ti@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: curious about libdrm-2.4.41 recipe from meta-ti layer
  2014-07-18 11:46 curious about libdrm-2.4.41 recipe from meta-ti layer Robert P. J. Day
  2014-07-18 15:30 ` Maupin, Chase
@ 2014-07-18 15:37 ` Denys Dmytriyenko
  1 sibling, 0 replies; 4+ messages in thread
From: Denys Dmytriyenko @ 2014-07-18 15:37 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: meta-ti mailing list

On Fri, Jul 18, 2014 at 07:46:36AM -0400, Robert P. J. Day wrote:
> 
>   i was perusing a number of yocto layers looking for cool examples to
> use in an upcoming class and ran across this oddity in the meta-ti
> layer:
> 
> recipes-graphics/drm/libdrm_2.4.41.bb:
>   FILESEXTRAPATHS_append := ":${COREBASE}/meta/recipes-graphics/drm/libdrm"
> 
>   in all of the layers i've looked at, that is the only example of
> *appending* to FILESEXTRAPATHS i've ever seen, so i thought i'd look
> closer to see what was going on.
> 
>   even though oe-core defines a libdrm recipe file, the meta-ti layer
> doesn't use a bbappend for its version. rather, it explicitly adds the
> libdrm/ directory from oe-core using a reference to ${COREBASE}, then
> adds its own files. that's valid, i guess, it just looks weird and is
> the only time i've ever seen that.
> 
>   i'm also puzzled that the meta-ti recipe sets:
> 
> DEFAULT_PREFERENCE = "-1"
> 
> what's that for?  given that the oe-core layer already defines a
> recipe for libdrm that has a higher version number, why would the
> above line be necessary?
> 
>   just trying to understand the rationale behind this unusual
> construction.

You missed line #11 with custom SRC_URI, which points to a forked and 
modified sources of a very specific version of libdrm for one platform.

That's why it sets COMPATIBLE_MACHINE and DEFAULT_PREFERENCE - it needs to be 
requested specifically and not selected automatically by accident. By default 
we want to use the latest upstream version from oe-core.

And it cannot be made as a bbappend - it provides a different version than 
oe-core. But it reuses GNU_SOURCE_definition.patch from oe-core, hence 
FILESEXTRAPATHS mangling.

Don't ask why it's done with forked git sources instead of patches though - 
not my decision :)

-- 
Denys


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: curious about libdrm-2.4.41 recipe from meta-ti layer
  2014-07-18 15:30 ` Maupin, Chase
@ 2014-07-18 15:44   ` Denys Dmytriyenko
  0 siblings, 0 replies; 4+ messages in thread
From: Denys Dmytriyenko @ 2014-07-18 15:44 UTC (permalink / raw)
  To: Maupin, Chase; +Cc: meta-ti mailing list

On Fri, Jul 18, 2014 at 03:30:57PM +0000, Maupin, Chase wrote:
> >-----Original Message-----
> >From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> >bounces@yoctoproject.org] On Behalf Of Robert P. J. Day
> >Sent: Friday, July 18, 2014 6:47 AM
> >To: meta-ti mailing list
> >Subject: [meta-ti] curious about libdrm-2.4.41 recipe from meta-ti
> >layer
> >
> >
> >  i was perusing a number of yocto layers looking for cool
> >examples to
> >use in an upcoming class and ran across this oddity in the meta-ti
> >layer:
> >
> >recipes-graphics/drm/libdrm_2.4.41.bb:
> >  FILESEXTRAPATHS_append := ":${COREBASE}/meta/recipes-
> >graphics/drm/libdrm"
> >
> >  in all of the layers i've looked at, that is the only example of
> >*appending* to FILESEXTRAPATHS i've ever seen, so i thought i'd
> >look
> >closer to see what was going on.
> >
> >  even though oe-core defines a libdrm recipe file, the meta-ti
> >layer
> >doesn't use a bbappend for its version. rather, it explicitly adds
> >the
> >libdrm/ directory from oe-core using a reference to ${COREBASE},
> >then
> >adds its own files. that's valid, i guess, it just looks weird and
> >is
> >the only time i've ever seen that.
> 
> The recipe also defines using a TI version of libdrm (I don't like that but 
> it is what we have been given from the component team doing this).  So the 
> intent here is to:
> 
> 1. Define a libdrm that uses the TI modified sources.
> 2. Use the recipe only for the omap-a15 devices and make that an explicit 
> setting by setting default preference to -1.
> 
> This wasn't done as an append because we wanted this only for omap-a15 
> devices when explicitely set as the preferred version to use and not impact 
> other devices using the later version from oe-core.
> 
> As for the reference to COREBASE it is to pick up the 
> GNU_SOURCE_definition.patch file rather than overlaying that as well.

Heh, if I knew you were already replying to this, I would have avoided 
duplicating the effort...


> >  i'm also puzzled that the meta-ti recipe sets:
> >
> >DEFAULT_PREFERENCE = "-1"
> >
> >what's that for?  given that the oe-core layer already defines a
> >recipe for libdrm that has a higher version number, why would the
> >above line be necessary?
> >
> >  just trying to understand the rationale behind this unusual
> >construction.
> >
> >rday
> >
> >--
> >
> >==================================================================
> >======
> >Robert P. J. Day                                 Ottawa, Ontario,
> >CANADA
> >                        http://crashcourse.ca
> >
> >Twitter:
> >http://twitter.com/rpjday
> >LinkedIn:
> >http://ca.linkedin.com/in/rpjday
> >==================================================================
> >======
> >
> >--
> >_______________________________________________
> >meta-ti mailing list
> >meta-ti@yoctoproject.org
> >https://lists.yoctoproject.org/listinfo/meta-ti
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-07-18 15:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-18 11:46 curious about libdrm-2.4.41 recipe from meta-ti layer Robert P. J. Day
2014-07-18 15:30 ` Maupin, Chase
2014-07-18 15:44   ` Denys Dmytriyenko
2014-07-18 15:37 ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.