From: richardcochran@gmail.com (Richard Cochran)
To: linux-arm-kernel@lists.infradead.org
Subject: FEC driver hangs hardware on i.MX6SX
Date: Sun, 20 Jul 2014 08:20:49 +0200 [thread overview]
Message-ID: <20140720062048.GB5686@netboy> (raw)
In-Reply-To: <20140720025732.GF8537@dragon>
On Sun, Jul 20, 2014 at 10:57:33AM +0800, Shawn Guo wrote:
>
> I think the cause is that PTP is still accessing registers after FEC
> driver calls fec_enet_clk_enable(ndev, false) to disable FEC clocks.
> Can you please try to provide a fix for this regression soon?
What do you mean by, "PTP is still accessing registers"?
The only access to any register is through the driver, and the driver
can and should make sure all register accesses are safe.
Thanks,
Richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Fugang Duan <B38611@freescale.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Frank Li <Frank.li@freescale.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: FEC driver hangs hardware on i.MX6SX
Date: Sun, 20 Jul 2014 08:20:49 +0200 [thread overview]
Message-ID: <20140720062048.GB5686@netboy> (raw)
In-Reply-To: <20140720025732.GF8537@dragon>
On Sun, Jul 20, 2014 at 10:57:33AM +0800, Shawn Guo wrote:
>
> I think the cause is that PTP is still accessing registers after FEC
> driver calls fec_enet_clk_enable(ndev, false) to disable FEC clocks.
> Can you please try to provide a fix for this regression soon?
What do you mean by, "PTP is still accessing registers"?
The only access to any register is through the driver, and the driver
can and should make sure all register accesses are safe.
Thanks,
Richard
next prev parent reply other threads:[~2014-07-20 6:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 2:57 FEC driver hangs hardware on i.MX6SX Shawn Guo
2014-07-20 2:57 ` Shawn Guo
2014-07-20 6:20 ` Richard Cochran [this message]
2014-07-20 6:20 ` Richard Cochran
2014-07-21 1:59 ` Shawn Guo
2014-07-21 1:59 ` Shawn Guo
2014-07-21 2:13 ` fugang.duan at freescale.com
2014-07-21 2:13 ` fugang.duan
2014-07-20 8:06 ` fugang.duan at freescale.com
2014-07-20 8:06 ` fugang.duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140720062048.GB5686@netboy \
--to=richardcochran@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.