All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: kernelnewbies@lists.kernelnewbies.org
Subject: Re: How to automate checkpatch && get_maintainers && git send-email of commits range?
Date: Sun, 20 Jul 2014 22:23:18 +0000	[thread overview]
Message-ID: <20140720222318.GL4453@dastard> (raw)
In-Reply-To: <CAJd=RBBqW-Nk62DnNW3XDERbmzwqROhw9dAu9avSXn2891m3dg@mail.gmail.com>

On Sat, Jul 19, 2014 at 11:35:45AM +0800, Hillf Danton wrote:
> On Sat, Jul 19, 2014 at 9:31 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Fri, Jul 18, 2014 at 06:22:15PM -0400, Theodore Ts'o wrote:
> >>
> >> And then think very hard about which patches people need to see in
> >> order to be able to evaluate a patch.  For example, if you have patch
> >> 1 out of a series which adds a new function, and then patches 2
> >> through 1000 modify a thousand different drivers to use that new
> >> function, if you use an automated get_maintainers.pl script to send
> >> each patch to just the maintainer, then the device driver maintainer
> >> might not see patch #1 which is critical context to understanding the
> >> patch that you want to make to his driver.  And then you will have
> >> several hundred very angry and annoyed developers wondering why you
> >> sent them patch 345/1000, with no other context, and wondering what
> >> the heck they are supposed to do with the email that you have just
> >> launched into their inbox.
> >
> > I'm still stuck in the old stone/quilt age, where I use quilt mail to
> > send my patch bombs. Although, I have scripts that pulls my patches out
> > from git with format-patch, and then creates a quilt queue from them.
> > I do this for that very reason that I want to review all patches before
> > I hit send, and quilt mail is very basic and sends what I tell it.
> > I still a bit gun shy from using git sendmail as I never got that to
> > work (note, the last time I tried, it was still doing the staircase
> > threads with patches by default).
> >
> > I'm still content with quilt, but the one thing I don't care about it
> > is that all Cc'd on the 0/1000 patch gets Cc'd on all patches. I wish
> > there was a way to tell quilt that they should only get Cc'd on the
> > cover patch and no more, unless the patch has them Cc'd. The reason this
> > bothers me is that I tend to do exactly what you stated above. I will
> > just Cc patch 345/1000 to someone with no context of what that patch
> > is.
> >
> > I figured people would do the same thing that I do when I get that 345th
> > patch. As I'm subscribed to LKML, I will just go into my lkml folder and
> > search for that patch and see how that thread applies to me with full
> > context. I'm assuming that's what others may do too.
> >
> Hi Steve
> 
> Why not share your quilt skills, say by adding a file in the Document directory?

guilt (quilt for git) already does all this scripting for you.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: david@fromorbit.com (Dave Chinner)
To: kernelnewbies@lists.kernelnewbies.org
Subject: How to automate checkpatch && get_maintainers && git send-email of commits range?
Date: Mon, 21 Jul 2014 08:23:18 +1000	[thread overview]
Message-ID: <20140720222318.GL4453@dastard> (raw)
In-Reply-To: <CAJd=RBBqW-Nk62DnNW3XDERbmzwqROhw9dAu9avSXn2891m3dg@mail.gmail.com>

On Sat, Jul 19, 2014 at 11:35:45AM +0800, Hillf Danton wrote:
> On Sat, Jul 19, 2014 at 9:31 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Fri, Jul 18, 2014 at 06:22:15PM -0400, Theodore Ts'o wrote:
> >>
> >> And then think very hard about which patches people need to see in
> >> order to be able to evaluate a patch.  For example, if you have patch
> >> 1 out of a series which adds a new function, and then patches 2
> >> through 1000 modify a thousand different drivers to use that new
> >> function, if you use an automated get_maintainers.pl script to send
> >> each patch to just the maintainer, then the device driver maintainer
> >> might not see patch #1 which is critical context to understanding the
> >> patch that you want to make to his driver.  And then you will have
> >> several hundred very angry and annoyed developers wondering why you
> >> sent them patch 345/1000, with no other context, and wondering what
> >> the heck they are supposed to do with the email that you have just
> >> launched into their inbox.
> >
> > I'm still stuck in the old stone/quilt age, where I use quilt mail to
> > send my patch bombs. Although, I have scripts that pulls my patches out
> > from git with format-patch, and then creates a quilt queue from them.
> > I do this for that very reason that I want to review all patches before
> > I hit send, and quilt mail is very basic and sends what I tell it.
> > I still a bit gun shy from using git sendmail as I never got that to
> > work (note, the last time I tried, it was still doing the staircase
> > threads with patches by default).
> >
> > I'm still content with quilt, but the one thing I don't care about it
> > is that all Cc'd on the 0/1000 patch gets Cc'd on all patches. I wish
> > there was a way to tell quilt that they should only get Cc'd on the
> > cover patch and no more, unless the patch has them Cc'd. The reason this
> > bothers me is that I tend to do exactly what you stated above. I will
> > just Cc patch 345/1000 to someone with no context of what that patch
> > is.
> >
> > I figured people would do the same thing that I do when I get that 345th
> > patch. As I'm subscribed to LKML, I will just go into my lkml folder and
> > search for that patch and see how that thread applies to me with full
> > context. I'm assuming that's what others may do too.
> >
> Hi Steve
> 
> Why not share your quilt skills, say by adding a file in the Document directory?

guilt (quilt for git) already does all this scripting for you.

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Andrey Utkin <andrey.krieger.utkin@gmail.com>,
	kernelnewbies@kernelnewbies.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: How to automate checkpatch && get_maintainers && git send-email of commits range?
Date: Mon, 21 Jul 2014 08:23:18 +1000	[thread overview]
Message-ID: <20140720222318.GL4453@dastard> (raw)
In-Reply-To: <CAJd=RBBqW-Nk62DnNW3XDERbmzwqROhw9dAu9avSXn2891m3dg@mail.gmail.com>

On Sat, Jul 19, 2014 at 11:35:45AM +0800, Hillf Danton wrote:
> On Sat, Jul 19, 2014 at 9:31 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Fri, Jul 18, 2014 at 06:22:15PM -0400, Theodore Ts'o wrote:
> >>
> >> And then think very hard about which patches people need to see in
> >> order to be able to evaluate a patch.  For example, if you have patch
> >> 1 out of a series which adds a new function, and then patches 2
> >> through 1000 modify a thousand different drivers to use that new
> >> function, if you use an automated get_maintainers.pl script to send
> >> each patch to just the maintainer, then the device driver maintainer
> >> might not see patch #1 which is critical context to understanding the
> >> patch that you want to make to his driver.  And then you will have
> >> several hundred very angry and annoyed developers wondering why you
> >> sent them patch 345/1000, with no other context, and wondering what
> >> the heck they are supposed to do with the email that you have just
> >> launched into their inbox.
> >
> > I'm still stuck in the old stone/quilt age, where I use quilt mail to
> > send my patch bombs. Although, I have scripts that pulls my patches out
> > from git with format-patch, and then creates a quilt queue from them.
> > I do this for that very reason that I want to review all patches before
> > I hit send, and quilt mail is very basic and sends what I tell it.
> > I still a bit gun shy from using git sendmail as I never got that to
> > work (note, the last time I tried, it was still doing the staircase
> > threads with patches by default).
> >
> > I'm still content with quilt, but the one thing I don't care about it
> > is that all Cc'd on the 0/1000 patch gets Cc'd on all patches. I wish
> > there was a way to tell quilt that they should only get Cc'd on the
> > cover patch and no more, unless the patch has them Cc'd. The reason this
> > bothers me is that I tend to do exactly what you stated above. I will
> > just Cc patch 345/1000 to someone with no context of what that patch
> > is.
> >
> > I figured people would do the same thing that I do when I get that 345th
> > patch. As I'm subscribed to LKML, I will just go into my lkml folder and
> > search for that patch and see how that thread applies to me with full
> > context. I'm assuming that's what others may do too.
> >
> Hi Steve
> 
> Why not share your quilt skills, say by adding a file in the Document directory?

guilt (quilt for git) already does all this scripting for you.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  parent reply	other threads:[~2014-07-20 22:23 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 14:38 How to automate checkpatch && get_maintainers && git send-email of commits range? Andrey Utkin
2014-07-18 14:38 ` Andrey Utkin
2014-07-18 14:38 ` Andrey Utkin
2014-07-18 14:46 ` Benoit Taine
2014-07-18 14:46   ` Benoit Taine
2014-07-18 15:24   ` Andrey Utkin
2014-07-18 15:24     ` Andrey Utkin
2014-07-18 15:24     ` Andrey Utkin
2014-07-18 20:40     ` Greg KH
2014-07-18 20:40       ` Greg KH
2014-07-18 20:40       ` Greg KH
2014-07-18 22:22 ` Theodore Ts'o
2014-07-18 22:22   ` Theodore Ts'o
2014-07-18 22:22   ` Theodore Ts'o
2014-07-18 22:47   ` Joe Perches
2014-07-18 22:47     ` Joe Perches
2014-07-18 22:47     ` Joe Perches
2014-07-18 22:50     ` Joe Perches
2014-07-18 22:50       ` Joe Perches
2014-07-18 22:50       ` Joe Perches
2014-07-19  1:31   ` Steven Rostedt
2014-07-19  1:31     ` Steven Rostedt
2014-07-19  1:31     ` Steven Rostedt
2014-07-19  3:35     ` Hillf Danton
2014-07-19  3:35       ` Hillf Danton
2014-07-19  3:35       ` Hillf Danton
2014-07-19  4:05       ` Nick Krause
2014-07-19  4:05         ` Nick Krause
2014-07-19  4:05         ` Nick Krause
2014-07-20 22:23       ` Dave Chinner [this message]
2014-07-20 22:23         ` Dave Chinner
2014-07-20 22:23         ` Dave Chinner
  -- strict thread matches above, loose matches on Subject: below --
2014-07-18 14:55 Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140720222318.GL4453@dastard \
    --to=david@fromorbit.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.