All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [SCSI] hpsa: Fix driver support flag initialisation on !x86
@ 2014-07-21  0:09 Ben Hutchings
  2014-07-21  0:42 ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2014-07-21  0:09 UTC (permalink / raw)
  To: Stephen M. Cameron; +Cc: linux-scsi

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

On !x86 we currently don't read the existing support flags:

/home/benh/linux-3.14.13/drivers/scsi/hpsa.c:4375:17: warning: 'driver_support' is used uninitialized in this function [-Wuninitialized]
  driver_support |= ENABLE_UNIT_ATTN;
                 ^

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Fixes: 28e134464734 ("[SCSI] hpsa: enable unit attention reporting")
Cc: <stable@vger.kernel.org> # 3.14+
---
Compile-tested only.

Ben.

 drivers/scsi/hpsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 9a6e4a2..7c3ff51 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -6350,9 +6350,9 @@ static inline void hpsa_set_driver_support_bits(struct ctlr_info *h)
 {
 	u32 driver_support;
 
+	driver_support = readl(&(h->cfgtable->driver_support));
 #ifdef CONFIG_X86
 	/* Need to enable prefetch in the SCSI core for 6400 in x86 */
-	driver_support = readl(&(h->cfgtable->driver_support));
 	driver_support |= ENABLE_SCSI_PREFETCH;
 #endif
 	driver_support |= ENABLE_UNIT_ATTN;

-- 
Ben Hutchings
Make three consecutive correct guesses and you will be considered an expert.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] [SCSI] hpsa: Fix driver support flag initialisation on !x86
  2014-07-21  0:09 [PATCH] [SCSI] hpsa: Fix driver support flag initialisation on !x86 Ben Hutchings
@ 2014-07-21  0:42 ` Christoph Hellwig
  2014-07-21  0:43   ` Ben Hutchings
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2014-07-21  0:42 UTC (permalink / raw)
  To: Ben Hutchings; +Cc: Stephen M. Cameron, linux-scsi

On Mon, Jul 21, 2014 at 01:09:17AM +0100, Ben Hutchings wrote:
> On !x86 we currently don't read the existing support flags:

Arnd already sent this and I've included it in the for-3.17 queue.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] [SCSI] hpsa: Fix driver support flag initialisation on !x86
  2014-07-21  0:42 ` Christoph Hellwig
@ 2014-07-21  0:43   ` Ben Hutchings
  0 siblings, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2014-07-21  0:43 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Stephen M. Cameron, linux-scsi

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

On Sun, 2014-07-20 at 17:42 -0700, Christoph Hellwig wrote:
> On Mon, Jul 21, 2014 at 01:09:17AM +0100, Ben Hutchings wrote:
> > On !x86 we currently don't read the existing support flags:
> 
> Arnd already sent this and I've included it in the for-3.17 queue.

Thanks.

Ben.

-- 
Ben Hutchings
Make three consecutive correct guesses and you will be considered an expert.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-07-21  0:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-21  0:09 [PATCH] [SCSI] hpsa: Fix driver support flag initialisation on !x86 Ben Hutchings
2014-07-21  0:42 ` Christoph Hellwig
2014-07-21  0:43   ` Ben Hutchings

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.