From: Thierry Reding <thierry.reding@gmail.com>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
linux-pwm@vger.kernel.org, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Andrew Victor <linux@maxim.org.za>,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, Bo Shen <voice.shen@atmel.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Robert Nelson <robertcnelson@gmail.com>,
Tim Niemeyer <tim.niemeyer@corscience>
Subject: Re: [RESEND PATCH v3 06/11] drm: add DT bindings documentation for atmel-hlcdc-dc driver
Date: Mon, 21 Jul 2014 10:59:12 +0200 [thread overview]
Message-ID: <20140721085908.GI8843@ulmo> (raw)
In-Reply-To: <20140718174334.209e99c1@bbrezillon>
[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]
On Fri, Jul 18, 2014 at 05:43:34PM +0200, Boris BREZILLON wrote:
[...]
> > > > > > + - atmel,panel: Should contain a phandle with 2 parameters.
> > > > > > + The first cell is a phandle to a DRM panel device
> > > > > > + The second cell encodes the RGB mode, which can take the following values:
> > > > > > + * 0: RGB444
> > > > > > + * 1: RGB565
> > > > > > + * 2: RGB666
> > > > > > + * 3: RGB888
> > > > >
> > > > > These are properties of the panel and should be obtained from the panel
> > > > > directly rather than an additional cell in this specifier.
> > > >
> > > > Okay.
> > > > What's the preferred way of doing this ?
> > > > What about defining an rgb-mode property in the panel node.
> > >
> > > There's .bpc in struct drm_display_info, I suspect that it could be used
> > > for this. Alternatively, maybe we could extend the list of color formats
> > > that go into drm_display_info.color_formats? RGB444 is already covered.
> >
>
> I forgot to ask about bpc meaning. If, as I think, it means "bits per
> color" then it cannot be used to encode RGB565 where green color is
> encoded on 6 bits and red and blue are encoded on 5 bits.
Yes, I agree that bps is not a good fit for what you need here.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v3 06/11] drm: add DT bindings documentation for atmel-hlcdc-dc driver
Date: Mon, 21 Jul 2014 10:59:12 +0200 [thread overview]
Message-ID: <20140721085908.GI8843@ulmo> (raw)
In-Reply-To: <20140718174334.209e99c1@bbrezillon>
On Fri, Jul 18, 2014 at 05:43:34PM +0200, Boris BREZILLON wrote:
[...]
> > > > > > + - atmel,panel: Should contain a phandle with 2 parameters.
> > > > > > + The first cell is a phandle to a DRM panel device
> > > > > > + The second cell encodes the RGB mode, which can take the following values:
> > > > > > + * 0: RGB444
> > > > > > + * 1: RGB565
> > > > > > + * 2: RGB666
> > > > > > + * 3: RGB888
> > > > >
> > > > > These are properties of the panel and should be obtained from the panel
> > > > > directly rather than an additional cell in this specifier.
> > > >
> > > > Okay.
> > > > What's the preferred way of doing this ?
> > > > What about defining an rgb-mode property in the panel node.
> > >
> > > There's .bpc in struct drm_display_info, I suspect that it could be used
> > > for this. Alternatively, maybe we could extend the list of color formats
> > > that go into drm_display_info.color_formats? RGB444 is already covered.
> >
>
> I forgot to ask about bpc meaning. If, as I think, it means "bits per
> color" then it cannot be used to encode RGB565 where green color is
> encoded on 6 bits and red and blue are encoded on 5 bits.
Yes, I agree that bps is not a good fit for what you need here.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140721/afb8110f/attachment-0001.sig>
next prev parent reply other threads:[~2014-07-21 8:59 UTC|newest]
Thread overview: 149+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 16:42 [RESEND PATCH v3 00/11] drm: add support for Atmel HLCDC Display Controller Boris BREZILLON
2014-07-07 16:42 ` Boris BREZILLON
2014-07-07 16:42 ` [RESEND PATCH v3 01/11] mfd: add atmel-hlcdc driver Boris BREZILLON
2014-07-07 16:42 ` Boris BREZILLON
2014-07-07 16:42 ` [RESEND PATCH v3 02/11] mfd: add documentation for atmel-hlcdc DT bindings Boris BREZILLON
2014-07-07 16:42 ` Boris BREZILLON
2014-07-07 16:42 ` [RESEND PATCH v3 03/11] pwm: add support for atmel-hlcdc-pwm device Boris BREZILLON
2014-07-07 16:42 ` Boris BREZILLON
2014-07-07 16:42 ` [RESEND PATCH v3 04/11] pwm: add DT bindings documentation for atmel-hlcdc-pwm driver Boris BREZILLON
2014-07-07 16:42 ` Boris BREZILLON
2014-07-07 16:42 ` [RESEND PATCH v3 05/11] drm: add Atmel HLCDC Display Controller support Boris BREZILLON
2014-07-07 16:42 ` Boris BREZILLON
2014-07-08 3:45 ` Rob Clark
2014-07-08 7:23 ` Boris BREZILLON
2014-07-08 7:23 ` Boris BREZILLON
2014-07-08 12:49 ` Rob Clark
2014-07-08 12:49 ` Rob Clark
2014-07-08 14:37 ` Boris BREZILLON
2014-07-08 14:37 ` Boris BREZILLON
2014-07-08 15:41 ` Rob Clark
2014-07-08 15:41 ` Rob Clark
2014-07-08 17:08 ` Boris BREZILLON
2014-07-08 17:08 ` Boris BREZILLON
2014-07-08 23:51 ` Matt Roper
2014-07-08 23:51 ` Matt Roper
2014-07-09 7:14 ` Boris BREZILLON
2014-07-09 7:14 ` Boris BREZILLON
2014-07-09 14:02 ` Daniel Vetter
2014-07-09 14:02 ` Daniel Vetter
2014-07-09 8:18 ` Boris BREZILLON
2014-07-09 8:18 ` Boris BREZILLON
2014-07-09 11:53 ` Rob Clark
2014-07-09 11:53 ` Rob Clark
2014-07-11 15:17 ` [RFC PATCH] drm: rework flip-work helpers to avoid calling func when the FIFO is full Boris BREZILLON
2014-07-11 15:41 ` Rob Clark
2014-07-11 15:47 ` Boris BREZILLON
2014-07-11 15:57 ` Boris BREZILLON
2014-07-11 16:05 ` Rob Clark
2014-07-12 18:16 ` [RESEND PATCH v3 05/11] drm: add Atmel HLCDC Display Controller support Boris BREZILLON
2014-07-12 18:16 ` Boris BREZILLON
2014-07-12 18:37 ` Rob Clark
2014-07-12 18:37 ` Rob Clark
2014-07-15 11:26 ` Boris BREZILLON
2014-07-15 11:26 ` Boris BREZILLON
2014-07-07 16:42 ` [RESEND PATCH v3 06/11] drm: add DT bindings documentation for atmel-hlcdc-dc driver Boris BREZILLON
2014-07-07 16:42 ` Boris BREZILLON
2014-07-10 11:16 ` Laurent Pinchart
2014-07-10 11:16 ` Laurent Pinchart
2014-07-10 12:56 ` Boris BREZILLON
2014-07-10 12:56 ` Boris BREZILLON
2014-07-11 10:37 ` Laurent Pinchart
2014-07-11 10:37 ` Laurent Pinchart
2014-07-11 12:00 ` Boris BREZILLON
2014-07-11 12:00 ` Boris BREZILLON
2014-07-11 12:19 ` Boris BREZILLON
2014-07-11 12:19 ` Boris BREZILLON
2014-07-14 10:18 ` Thierry Reding
2014-07-14 10:18 ` Thierry Reding
2014-07-15 11:45 ` Boris BREZILLON
2014-07-15 11:45 ` Boris BREZILLON
2014-07-14 10:05 ` Thierry Reding
2014-07-14 10:05 ` Thierry Reding
2014-07-15 10:06 ` Boris BREZILLON
2014-07-15 10:06 ` Boris BREZILLON
2014-07-15 10:20 ` Laurent Pinchart
2014-07-15 10:20 ` Laurent Pinchart
2014-07-15 10:37 ` Thierry Reding
2014-07-15 10:37 ` Thierry Reding
2014-07-15 10:43 ` Laurent Pinchart
2014-07-15 10:43 ` Laurent Pinchart
2014-07-15 10:52 ` Thierry Reding
2014-07-15 10:52 ` Thierry Reding
2014-07-15 11:07 ` Laurent Pinchart
2014-07-15 11:07 ` Laurent Pinchart
2014-07-16 13:05 ` Boris BREZILLON
2014-07-16 13:05 ` Boris BREZILLON
2014-07-16 13:20 ` Laurent Pinchart
2014-07-16 13:20 ` Laurent Pinchart
2014-07-16 13:20 ` Laurent Pinchart
2014-07-16 13:44 ` Boris BREZILLON
2014-07-16 13:44 ` Boris BREZILLON
2014-07-15 12:14 ` Boris BREZILLON
2014-07-15 12:14 ` Boris BREZILLON
2014-07-15 10:31 ` Thierry Reding
2014-07-15 10:31 ` Thierry Reding
2014-07-18 14:51 ` Boris BREZILLON
2014-07-18 14:51 ` Boris BREZILLON
2014-07-18 15:43 ` Boris BREZILLON
2014-07-18 15:43 ` Boris BREZILLON
2014-07-21 8:59 ` Thierry Reding [this message]
2014-07-21 8:59 ` Thierry Reding
2014-07-21 9:24 ` Boris BREZILLON
2014-07-21 9:24 ` Boris BREZILLON
2014-07-21 9:32 ` Laurent Pinchart
2014-07-21 9:32 ` Laurent Pinchart
2014-07-21 9:57 ` Boris BREZILLON
2014-07-21 9:57 ` Boris BREZILLON
2014-07-21 12:12 ` Thierry Reding
2014-07-21 12:12 ` Thierry Reding
2014-07-21 12:16 ` Laurent Pinchart
2014-07-21 12:16 ` Laurent Pinchart
2014-07-21 12:34 ` Boris BREZILLON
2014-07-21 12:34 ` Boris BREZILLON
2014-07-21 12:55 ` Thierry Reding
2014-07-21 12:55 ` Thierry Reding
2014-07-21 13:22 ` Laurent Pinchart
2014-07-21 13:22 ` Laurent Pinchart
2014-07-21 13:30 ` Thierry Reding
2014-07-21 13:30 ` Thierry Reding
2014-07-21 13:43 ` Boris BREZILLON
2014-07-21 13:43 ` Boris BREZILLON
2014-07-21 13:47 ` Laurent Pinchart
2014-07-21 13:47 ` Laurent Pinchart
2014-07-21 13:54 ` Thierry Reding
2014-07-21 13:54 ` Thierry Reding
2014-07-21 14:21 ` Boris BREZILLON
2014-07-21 14:21 ` Boris BREZILLON
2014-07-21 18:30 ` Laurent Pinchart
2014-07-21 18:30 ` Laurent Pinchart
2014-07-21 22:04 ` Thierry Reding
2014-07-21 22:04 ` Thierry Reding
2014-07-21 14:18 ` Boris BREZILLON
2014-07-21 14:18 ` Boris BREZILLON
2014-07-21 18:32 ` Laurent Pinchart
2014-07-21 18:32 ` Laurent Pinchart
2014-07-21 17:06 ` Russell King - ARM Linux
2014-07-21 17:06 ` Russell King - ARM Linux
2014-07-21 22:17 ` Thierry Reding
2014-07-21 22:17 ` Thierry Reding
2014-07-21 12:15 ` Thierry Reding
2014-07-21 12:15 ` Thierry Reding
2014-07-21 12:33 ` Boris BREZILLON
2014-07-21 12:33 ` Boris BREZILLON
2014-07-21 12:56 ` Thierry Reding
2014-07-21 12:56 ` Thierry Reding
2014-07-21 13:26 ` Laurent Pinchart
2014-07-21 13:26 ` Laurent Pinchart
2014-07-21 13:33 ` Thierry Reding
2014-07-21 13:33 ` Thierry Reding
2014-07-07 16:43 ` [RESEND PATCH v3 07/11] ARM: AT91/dt: split sama5d3 lcd pin definitions to match RGB mode configs Boris BREZILLON
2014-07-07 16:43 ` Boris BREZILLON
2014-07-07 16:43 ` [RESEND PATCH v3 08/11] ARM: AT91/dt: add alternative pin muxing for sama5d3 lcd pins Boris BREZILLON
2014-07-07 16:43 ` Boris BREZILLON
2014-07-07 16:43 ` [RESEND PATCH v3 09/11] ARM: at91/dt: define the HLCDC node available on sama5d3 SoCs Boris BREZILLON
2014-07-07 16:43 ` Boris BREZILLON
2014-07-07 16:43 ` [RESEND PATCH v3 10/11] ARM: at91/dt: add LCD panel description to sama5d3xdm.dtsi Boris BREZILLON
2014-07-07 16:43 ` Boris BREZILLON
2014-07-07 16:43 ` [RESEND PATCH v3 11/11] ARM: at91/dt: enable the LCD panel on sama5d3xek boards Boris BREZILLON
2014-07-07 16:43 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721085908.GI8843@ulmo \
--to=thierry.reding@gmail.com \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jjhiblot@traphandler.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tim.niemeyer@corscience \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.