All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	"Rajendra Nayak" <rnayak@ti.com>,
	"Paul Walmsley" <paul@pwsan.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org
Subject: Re: [RFC PATCH 3/7] ARM: OMAP4+: PRM: remove "wkup" event
Date: Mon, 21 Jul 2014 03:44:14 -0700	[thread overview]
Message-ID: <20140721104413.GT18374@atomide.com> (raw)
In-Reply-To: <1402025761-16831-4-git-send-email-nm@ti.com>

* Nishanth Menon <nm@ti.com> [140605 20:37]:
> "wkup" event at bit offset 0 exists only on OMAP3.
> OMAP4430/60 PRM_IRQSTATUS_A9, OMAP5/DRA7 PRM_IRQSTATUS_MPU
> 
> register bit 0 is DPLL_CORE_RECAL_ST not wakeup event like OMAP3.

Hmm so why was it added originally then?

Do the PRM_IRQSTATUS line and the following line belong together
or is it missing something?

Regards,

Tony
 
> The same applies to AM437x as well.
> 
> Remove the wrong definition.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm/mach-omap2/prm44xx.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
> index d4d745e..1ecf244 100644
> --- a/arch/arm/mach-omap2/prm44xx.c
> +++ b/arch/arm/mach-omap2/prm44xx.c
> @@ -32,7 +32,6 @@
>  /* Static data */
>  
>  static const struct omap_prcm_irq omap4_prcm_irqs[] = {
> -	OMAP_PRCM_IRQ("wkup",   0,      0),
>  	OMAP_PRCM_IRQ("io",     9,      1),
>  };
>  
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 3/7] ARM: OMAP4+: PRM: remove "wkup" event
Date: Mon, 21 Jul 2014 03:44:14 -0700	[thread overview]
Message-ID: <20140721104413.GT18374@atomide.com> (raw)
In-Reply-To: <1402025761-16831-4-git-send-email-nm@ti.com>

* Nishanth Menon <nm@ti.com> [140605 20:37]:
> "wkup" event at bit offset 0 exists only on OMAP3.
> OMAP4430/60 PRM_IRQSTATUS_A9, OMAP5/DRA7 PRM_IRQSTATUS_MPU
> 
> register bit 0 is DPLL_CORE_RECAL_ST not wakeup event like OMAP3.

Hmm so why was it added originally then?

Do the PRM_IRQSTATUS line and the following line belong together
or is it missing something?

Regards,

Tony
 
> The same applies to AM437x as well.
> 
> Remove the wrong definition.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm/mach-omap2/prm44xx.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
> index d4d745e..1ecf244 100644
> --- a/arch/arm/mach-omap2/prm44xx.c
> +++ b/arch/arm/mach-omap2/prm44xx.c
> @@ -32,7 +32,6 @@
>  /* Static data */
>  
>  static const struct omap_prcm_irq omap4_prcm_irqs[] = {
> -	OMAP_PRCM_IRQ("wkup",   0,      0),
>  	OMAP_PRCM_IRQ("io",     9,      1),
>  };
>  
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-07-21 10:45 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06  3:35 [RFC PATCH 0/7] ARM: OMAP4+: PRM: minor cleanups and dt support of interrupts Nishanth Menon
2014-06-06  3:35 ` Nishanth Menon
2014-06-06  3:35 ` [RFC PATCH 1/7] ARM: OMAP4+: prminst: provide function to find prm_dev instance offset Nishanth Menon
2014-06-06  3:35   ` Nishanth Menon
2014-06-06  3:35 ` [RFC PATCH 2/7] ARM: OMAP4: prm use the generic prm_inst to allow logic to be abstracted Nishanth Menon
2014-06-06  3:35   ` Nishanth Menon
2014-06-06  3:35 ` [RFC PATCH 3/7] ARM: OMAP4+: PRM: remove "wkup" event Nishanth Menon
2014-06-06  3:35   ` Nishanth Menon
2014-07-21 10:44   ` Tony Lindgren [this message]
2014-07-21 10:44     ` Tony Lindgren
2014-07-21 11:17     ` Nishanth Menon
2014-07-21 11:17       ` Nishanth Menon
     [not found] ` <1402025761-16831-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-06-06  3:35   ` [RFC PATCH 4/7] ARM: OMAP4+: PRM: register interrupt information from DT Nishanth Menon
2014-06-06  3:35     ` Nishanth Menon
2014-07-21 10:51     ` Tony Lindgren
2014-07-21 10:51       ` Tony Lindgren
2014-07-21 11:22       ` Nishanth Menon
2014-07-21 11:22         ` Nishanth Menon
2014-07-21 11:28         ` Tony Lindgren
2014-07-21 11:28           ` Tony Lindgren
2014-07-21 12:08           ` Nishanth Menon
2014-07-21 12:08             ` Nishanth Menon
2014-07-21 12:31             ` Tony Lindgren
2014-07-21 12:31               ` Tony Lindgren
2014-06-06  3:35 ` [RFC PATCH 5/7] ARM: dts: OMAP4: Add PRM interrupt Nishanth Menon
2014-06-06  3:35   ` Nishanth Menon
2014-06-06  3:36 ` [RFC PATCH 6/7] ARM: dts: OMAP5: add " Nishanth Menon
2014-06-06  3:36   ` Nishanth Menon
2014-06-06  3:36 ` [RFC PATCH 7/7] ARM: dts: DRA7: " Nishanth Menon
2014-06-06  3:36   ` Nishanth Menon
2014-06-17 15:38 ` [RFC PATCH 0/7] ARM: OMAP4+: PRM: minor cleanups and dt support of interrupts Nishanth Menon
2014-06-17 15:38   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140721104413.GT18374@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.