All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Borislav Petkov <bp@alien8.de>, Sam Ravnborg <sam@ravnborg.org>,
	pramod.gurav.etc@gmail.com, Jason Cooper <jason@lakedaemon.net>,
	Markus Mayer <markus.mayer@linaro.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] direct-io: fix uninitialized warning in do_direct_IO()
Date: Mon, 21 Jul 2014 04:36:53 -0700	[thread overview]
Message-ID: <20140721113653.GC2628@infradead.org> (raw)
In-Reply-To: <53CB8730.40607@plexistor.com>

Looks good to me,

Reviewed-by: Christoph Hellwig <hch@lst.de>

While it looks obvious, did you make sure it passes xfstests, which
has a lot of direct I/O tests?


  reply	other threads:[~2014-07-21 11:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04  5:43 [PATCH] fs/direct-io.c: Fix compilation warning for uninitialized variables pramod.gurav.etc
2014-07-04  5:43 ` pramod.gurav.etc
2014-07-13 11:50 ` Christoph Hellwig
2014-07-14  7:04   ` pramod gurav
2014-07-16 17:08   ` Boaz Harrosh
2014-07-16 17:08     ` Boaz Harrosh
2014-07-16 17:56     ` Jason Cooper
2014-07-16 17:58     ` Christoph Hellwig
2014-07-16 18:42       ` Paul Bolle
2014-07-17  9:37         ` direct-io: squelch maybe-uninitialized warning in do_direct_IO() Boaz Harrosh
2014-07-17  9:40           ` Boaz Harrosh
2014-07-17  9:54             ` Paul Bolle
2014-07-17  9:48           ` Paul Bolle
2014-07-17 11:00             ` Boaz Harrosh
2014-07-17 11:00               ` Boaz Harrosh
2014-07-17 11:11           ` [PATCH v2] " Boaz Harrosh
2014-07-17 11:11             ` Boaz Harrosh
2014-07-17 11:29             ` Paul Bolle
2014-07-20  9:09               ` [PATCH v3] direct-io: fix uninitialized " Boaz Harrosh
2014-07-20  9:09                 ` Boaz Harrosh
2014-07-21 11:36                 ` Christoph Hellwig [this message]
2014-07-22  9:03                   ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140721113653.GC2628@infradead.org \
    --to=hch@infradead.org \
    --cc=boaz@plexistor.com \
    --cc=bp@alien8.de \
    --cc=jason@lakedaemon.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.mayer@linaro.org \
    --cc=pebolle@tiscali.nl \
    --cc=pramod.gurav.etc@gmail.com \
    --cc=sam@ravnborg.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.