All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: Eryu Guan <eguan@redhat.com>, Boris Ranto <branto@redhat.com>,
	Eric Sandeen <esandeen@redhat.com>,
	fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: new case to test inode allocations in post-growfs disk space
Date: Tue, 22 Jul 2014 10:23:22 +1000	[thread overview]
Message-ID: <20140722002322.GN4453@dastard> (raw)
In-Reply-To: <20140721134638.GA45794@bfoster.bfoster>

On Mon, Jul 21, 2014 at 09:46:38AM -0400, Brian Foster wrote:
> On Thu, Jul 17, 2014 at 12:52:33AM +0800, Eryu Guan wrote:
> > Make sure inodes can be allocated in new space added by xfs_growfs.
> > 
> > Regression test for
> > xfs: allow inode allocations in post-growfs disk space
....
> > +# Create files to consume free inodes in background
> > +(
> > +	i=0
> > +	while [ $i -lt 1000 ]; do
> > +		mkdir $SCRATCH_MNT/testdir_$i
> > +		create_file $SCRATCH_MNT/testdir_$i &
> > +		let i=$i+1
> > +	done
> > +) >/dev/null 2>&1 &
> > +
> > +# Grow fs at the same time, at least x4
> > +# doubling or tripling the size couldn't reproduce
> > +$XFS_GROWFS_PROG -D $((dblocks * 4)) $SCRATCH_MNT >>$seqres.full
> > +
> 
> Even though this is still relatively small based on what people probably
> typically test, we're still making assumptions about the size of the
> scratch device.

_require_fs_space $SCRATCH_MNT <size>

solves that problem. And in places we require 10GB of space, so a
few hundred MB isn't an issue.


-Dave.
-- 
Dave Chinner
david@fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com,
	Eryu Guan <eguan@redhat.com>, Boris Ranto <branto@redhat.com>,
	Eric Sandeen <esandeen@redhat.com>
Subject: Re: [PATCH 1/2] xfs: new case to test inode allocations in post-growfs disk space
Date: Tue, 22 Jul 2014 10:23:22 +1000	[thread overview]
Message-ID: <20140722002322.GN4453@dastard> (raw)
In-Reply-To: <20140721134638.GA45794@bfoster.bfoster>

On Mon, Jul 21, 2014 at 09:46:38AM -0400, Brian Foster wrote:
> On Thu, Jul 17, 2014 at 12:52:33AM +0800, Eryu Guan wrote:
> > Make sure inodes can be allocated in new space added by xfs_growfs.
> > 
> > Regression test for
> > xfs: allow inode allocations in post-growfs disk space
....
> > +# Create files to consume free inodes in background
> > +(
> > +	i=0
> > +	while [ $i -lt 1000 ]; do
> > +		mkdir $SCRATCH_MNT/testdir_$i
> > +		create_file $SCRATCH_MNT/testdir_$i &
> > +		let i=$i+1
> > +	done
> > +) >/dev/null 2>&1 &
> > +
> > +# Grow fs at the same time, at least x4
> > +# doubling or tripling the size couldn't reproduce
> > +$XFS_GROWFS_PROG -D $((dblocks * 4)) $SCRATCH_MNT >>$seqres.full
> > +
> 
> Even though this is still relatively small based on what people probably
> typically test, we're still making assumptions about the size of the
> scratch device.

_require_fs_space $SCRATCH_MNT <size>

solves that problem. And in places we require 10GB of space, so a
few hundred MB isn't an issue.


-Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-07-22  0:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 16:52 [PATCH 1/2] xfs: new case to test inode allocations in post-growfs disk space Eryu Guan
2014-07-16 16:52 ` Eryu Guan
2014-07-21 13:46 ` Brian Foster
2014-07-21 13:46   ` Brian Foster
2014-07-22  0:23   ` Dave Chinner [this message]
2014-07-22  0:23     ` Dave Chinner
2014-07-24 10:36   ` Eryu Guan
2014-07-24 10:36     ` Eryu Guan
2014-07-24 13:06     ` Brian Foster
2014-07-24 13:06       ` Brian Foster
2014-07-31  3:32       ` Eryu Guan
2014-07-31  3:32         ` Eryu Guan
2014-07-31 11:45         ` Brian Foster
2014-07-31 11:45           ` Brian Foster
2014-07-31 12:42           ` Eryu Guan
2014-07-31 12:42             ` Eryu Guan
2014-07-24 10:51 ` [PATCH v2] " Eryu Guan
2014-07-24 10:51   ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140722002322.GN4453@dastard \
    --to=david@fromorbit.com \
    --cc=bfoster@redhat.com \
    --cc=branto@redhat.com \
    --cc=eguan@redhat.com \
    --cc=esandeen@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.