All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: s3c2410_ts: Move to clk_prepare_enable/clk_disable_unprepare
Date: Tue, 22 Jul 2014 23:09:14 -0700	[thread overview]
Message-ID: <20140723060913.GD25004@core.coreip.homeip.net> (raw)
In-Reply-To: <2138540.gOK28iFQ6r@vasilykh-desktop-i5>

Hi Vasily,

On Wed, Jul 09, 2014 at 12:13:41PM +0300, Vasily Khoruzhick wrote:
> On 8 July 2014 18:00:49 Dmitry Torokhov wrote:
> 
> Hi Dmitry,
> 
> > > 
> > > -	clk_disable(ts.clock);
> > > +	clk_disable_unprepare(ts.clock);
> > 
> > Do we really need to unprepare on suspend? Why simply disabling is not
> > enough here?
> 
> You're right, disabling should be enough here. I'll resend a patch after 
> testing on a hardware.

I ended up cutting out suspend/resume parts and applying.

Thanks.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Input: s3c2410_ts: Move to clk_prepare_enable/clk_disable_unprepare
Date: Tue, 22 Jul 2014 23:09:14 -0700	[thread overview]
Message-ID: <20140723060913.GD25004@core.coreip.homeip.net> (raw)
In-Reply-To: <2138540.gOK28iFQ6r@vasilykh-desktop-i5>

Hi Vasily,

On Wed, Jul 09, 2014 at 12:13:41PM +0300, Vasily Khoruzhick wrote:
> On 8 July 2014 18:00:49 Dmitry Torokhov wrote:
> 
> Hi Dmitry,
> 
> > > 
> > > -	clk_disable(ts.clock);
> > > +	clk_disable_unprepare(ts.clock);
> > 
> > Do we really need to unprepare on suspend? Why simply disabling is not
> > enough here?
> 
> You're right, disabling should be enough here. I'll resend a patch after 
> testing on a hardware.

I ended up cutting out suspend/resume parts and applying.

Thanks.

-- 
Dmitry

  reply	other threads:[~2014-07-23  6:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 19:09 [PATCH] Input: s3c2410_ts: Move to clk_prepare_enable/clk_disable_unprepare Vasily Khoruzhick
2014-06-30 19:09 ` Vasily Khoruzhick
2014-07-08 11:50 ` Tomasz Figa
2014-07-08 11:50   ` Tomasz Figa
2014-07-09  1:00 ` Dmitry Torokhov
2014-07-09  1:00   ` Dmitry Torokhov
2014-07-09  9:13   ` Vasily Khoruzhick
2014-07-09  9:13     ` Vasily Khoruzhick
2014-07-23  6:09     ` Dmitry Torokhov [this message]
2014-07-23  6:09       ` Dmitry Torokhov
2014-07-23  7:59       ` Vasily Khoruzhick
2014-07-23  7:59         ` Vasily Khoruzhick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140723060913.GD25004@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=anarsoul@gmail.com \
    --cc=ben-linux@fluff.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.