From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type
Date: Wed, 23 Jul 2014 13:33:32 -0500 [thread overview]
Message-ID: <20140723183332.GA21992@redhat.com> (raw)
In-Reply-To: <20140723141139.2cf90cb0@tlielax.poochiereds.net>
On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote:
> On Sun, 20 Jul 2014 11:23:43 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > op->info.rv is an s32, but it's only used as a u8.
> >
>
> I don't understand this patch. info.rv is s32 (and I assume that "rv"
> stands for "return value"). What I don't get is why you think it's just
> used as a u8. It seems to be used more like a bool than anything else,
Thank you, Jeff.
/* info.rv from userspace is 1 for conflict, 0 for no-conflict,
-ENOENT if there are no locks on the file */
rv = op->info.rv;
> and I'm not sure that "type" is really a good description for it. Maybe
> it should be a "bool" and named "conflict", given the comments in
> dlm_posix_get ?
type is not a good name.
Sorry Joe, I'm not a fan of your patches.
Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland@redhat.com>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
Christine Caulfield <ccaulfie@redhat.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type
Date: Wed, 23 Jul 2014 13:33:32 -0500 [thread overview]
Message-ID: <20140723183332.GA21992@redhat.com> (raw)
In-Reply-To: <20140723141139.2cf90cb0@tlielax.poochiereds.net>
On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote:
> On Sun, 20 Jul 2014 11:23:43 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > op->info.rv is an s32, but it's only used as a u8.
> >
>
> I don't understand this patch. info.rv is s32 (and I assume that "rv"
> stands for "return value"). What I don't get is why you think it's just
> used as a u8. It seems to be used more like a bool than anything else,
Thank you, Jeff.
/* info.rv from userspace is 1 for conflict, 0 for no-conflict,
-ENOENT if there are no locks on the file */
rv = op->info.rv;
> and I'm not sure that "type" is really a good description for it. Maybe
> it should be a "bool" and named "conflict", given the comments in
> dlm_posix_get ?
type is not a good name.
Sorry Joe, I'm not a fan of your patches.
Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>
Cc: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
Christine Caulfield
<ccaulfie-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
Trond Myklebust
<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>,
cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type
Date: Wed, 23 Jul 2014 13:33:32 -0500 [thread overview]
Message-ID: <20140723183332.GA21992@redhat.com> (raw)
In-Reply-To: <20140723141139.2cf90cb0-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote:
> On Sun, 20 Jul 2014 11:23:43 -0700
> Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> wrote:
>
> > op->info.rv is an s32, but it's only used as a u8.
> >
>
> I don't understand this patch. info.rv is s32 (and I assume that "rv"
> stands for "return value"). What I don't get is why you think it's just
> used as a u8. It seems to be used more like a bool than anything else,
Thank you, Jeff.
/* info.rv from userspace is 1 for conflict, 0 for no-conflict,
-ENOENT if there are no locks on the file */
rv = op->info.rv;
> and I'm not sure that "type" is really a good description for it. Maybe
> it should be a "bool" and named "conflict", given the comments in
> dlm_posix_get ?
type is not a good name.
Sorry Joe, I'm not a fan of your patches.
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-23 18:33 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 18:23 [Cluster-devel] [PATCH 0/9] fs.h/dlm: Neatening and argument removals Joe Perches
2014-07-20 18:23 ` Joe Perches
2014-07-20 18:23 ` [PATCH 1/9] fs.h: Remove unnecessary extern prototypes Joe Perches
2014-07-23 17:58 ` Jeff Layton
2014-07-20 18:23 ` [PATCH 2/9] fs.h: Whitespace neatening Joe Perches
2014-07-23 17:57 ` Jeff Layton
2014-07-20 18:23 ` [PATCH 3/9] fs.h: A few more whitespace neatenings Joe Perches
2014-07-23 18:12 ` Jeff Layton
2014-07-20 18:23 ` [PATCH 4/9] fs.h: Add argument names to struct file_lock_operations (*funcs) Joe Perches
2014-07-23 17:59 ` Jeff Layton
2014-07-20 18:23 ` [PATCH 5/9] fs.h: Add member argument descriptions to lock_manager_operations Joe Perches
2014-07-23 17:59 ` Jeff Layton
2014-07-20 18:23 ` [Cluster-devel] [PATCH 6/9] dlm: plock: Add argument descriptions to notify Joe Perches
2014-07-20 18:23 ` Joe Perches
2014-07-20 18:23 ` [Cluster-devel] [PATCH 7/9] dlm: fs: Remove unused conf from lm_grant Joe Perches
2014-07-20 18:23 ` Joe Perches
2014-07-23 18:00 ` [Cluster-devel] " Jeff Layton
2014-07-23 18:00 ` Jeff Layton
2014-07-23 18:00 ` Jeff Layton
2014-07-20 18:23 ` [Cluster-devel] [PATCH 8/9] dlm: plock: Reduce indentation by rearranging order Joe Perches
2014-07-20 18:23 ` Joe Perches
2014-07-23 18:01 ` [Cluster-devel] " Jeff Layton
2014-07-23 18:01 ` Jeff Layton
2014-07-20 18:23 ` [Cluster-devel] [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type Joe Perches
2014-07-20 18:23 ` Joe Perches
2014-07-20 18:23 ` Joe Perches
2014-07-23 18:11 ` [Cluster-devel] " Jeff Layton
2014-07-23 18:11 ` Jeff Layton
2014-07-23 18:11 ` Jeff Layton
2014-07-23 18:33 ` David Teigland [this message]
2014-07-23 18:33 ` David Teigland
2014-07-23 18:33 ` David Teigland
2014-07-24 3:53 ` [Cluster-devel] " Joe Perches
2014-07-24 3:53 ` Joe Perches
2014-07-24 16:24 ` [Cluster-devel] " Jeff Layton
2014-07-24 16:24 ` Jeff Layton
2014-07-24 16:24 ` Jeff Layton
2014-07-24 16:35 ` [Cluster-devel] " Joe Perches
2014-07-24 16:35 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723183332.GA21992@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.