All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Tuomas Tynkkynen <ttynkkynen@nvidia.com>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	Prashant Gaikwad <pgaikwad@nvidia.com>,
	Mike Turquette <mturquette@linaro.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Paul Walmsley <pwalmsley@nvidia.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 14/16] cpufreq: Add cpufreq driver for Tegra124
Date: Thu, 24 Jul 2014 11:10:04 +0200	[thread overview]
Message-ID: <20140724091002.GA3811@ulmo.nvidia.com> (raw)
In-Reply-To: <CAKohponsS8WJy4qBa=3em9AcxfpfLZR_mx4Ln8N3Q_gBaf52NA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

On Thu, Jul 24, 2014 at 05:43:40AM +0530, Viresh Kumar wrote:
> On 24 July 2014 00:47, Tuomas Tynkkynen <ttynkkynen@nvidia.com> wrote:
> > It's this:
> >
> > +static int tegra124_cpufreq_probe(struct platform_device *pdev)
> > +{
> > [...]
> > +
> > +       dfll_clk = of_clk_get_by_name(cpu_dev->of_node, "dfll");
> > +       if (IS_ERR(dfll_clk)) {
> > +               ret = PTR_ERR(dfll_clk);
> > +               goto out_put_cpu_clk;
> > +       }
> 
> This would search for clocks passed via DT, right? Why would we
> get EPROBE_DEFER for that? Sorry for the stupid question.

of_clk_get_by_name() can return -EPROBE_DEFER, which will happen if the
clock provider hasn't been registered yet.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 14/16] cpufreq: Add cpufreq driver for Tegra124
Date: Thu, 24 Jul 2014 11:10:04 +0200	[thread overview]
Message-ID: <20140724091002.GA3811@ulmo.nvidia.com> (raw)
In-Reply-To: <CAKohponsS8WJy4qBa=3em9AcxfpfLZR_mx4Ln8N3Q_gBaf52NA@mail.gmail.com>

On Thu, Jul 24, 2014 at 05:43:40AM +0530, Viresh Kumar wrote:
> On 24 July 2014 00:47, Tuomas Tynkkynen <ttynkkynen@nvidia.com> wrote:
> > It's this:
> >
> > +static int tegra124_cpufreq_probe(struct platform_device *pdev)
> > +{
> > [...]
> > +
> > +       dfll_clk = of_clk_get_by_name(cpu_dev->of_node, "dfll");
> > +       if (IS_ERR(dfll_clk)) {
> > +               ret = PTR_ERR(dfll_clk);
> > +               goto out_put_cpu_clk;
> > +       }
> 
> This would search for clocks passed via DT, right? Why would we
> get EPROBE_DEFER for that? Sorry for the stupid question.

of_clk_get_by_name() can return -EPROBE_DEFER, which will happen if the
clock provider hasn't been registered yet.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140724/4ff0a233/attachment.sig>

  reply	other threads:[~2014-07-24  9:10 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 15:38 [PATCH v2 00/16] Tegra124 CL-DVFS / DFLL clocksource, plus cpufreq Tuomas Tynkkynen
2014-07-21 15:38 ` Tuomas Tynkkynen
2014-07-21 15:38 ` Tuomas Tynkkynen
2014-07-21 15:38 ` [PATCH v2 01/16] regmap: Add regmap_get_device Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-25 17:34   ` Mark Brown
2014-07-25 17:34     ` Mark Brown
     [not found]   ` <1405957142-19416-2-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-25 17:43     ` Mark Brown
2014-07-25 17:43       ` Mark Brown
2014-07-25 17:43       ` Mark Brown
2014-07-21 15:38 ` [PATCH v2 02/16] regulator: Add helpers for low-level register access Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
     [not found]   ` <1405957142-19416-3-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-25 17:48     ` Mark Brown
2014-07-25 17:48       ` Mark Brown
2014-07-25 17:48       ` Mark Brown
2014-07-21 15:38 ` [PATCH v2 03/16] clk: tegra: Add binding for the Tegra124 DFLL clocksource Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38 ` [PATCH v2 04/16] clk: tegra: Add library for the DFLL clock source (open-loop mode) Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
     [not found]   ` <1405957142-19416-5-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-18  6:05     ` Vince Hsu
2014-08-18  6:05       ` Vince Hsu
2014-08-18  6:05       ` Vince Hsu
2014-07-21 15:38 ` [PATCH v2 05/16] clk: tegra: Add closed loop support for the DFLL Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
     [not found]   ` <1405957142-19416-6-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-18  6:08     ` Vince Hsu
2014-08-18  6:08       ` Vince Hsu
2014-08-18  6:08       ` Vince Hsu
2014-07-21 15:38 ` [PATCH v2 06/16] clk: tegra: Add functions for parsing CVB tables Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38 ` [PATCH v2 07/16] clk: tegra: Add DFLL DVCO reset control for Tegra124 Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38 ` [PATCH v2 08/16] clk: tegra: Add Tegra124 DFLL clocksource platform driver Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-08-12 10:37   ` Vince Hsu
2014-08-12 10:37     ` Vince Hsu
2014-07-21 15:38 ` [PATCH v2 09/16] clk: tegra: Save/restore CCLKG_BURST_POLICY on suspend Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38 ` [PATCH v2 10/16] clk: tegra: Add the DFLL as a possible parent of the cclk_g clock Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38 ` [PATCH v2 11/16] ARM: tegra: Add the DFLL to Tegra124 device tree Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38 ` [PATCH v2 12/16] ARM: tegra: Enable the DFLL on the Jetson TK1 Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38 ` [PATCH v2 13/16] cpufreq: tegra124: Add device tree bindings Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
2014-07-21 15:38   ` Tuomas Tynkkynen
     [not found] ` <1405957142-19416-1-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-21 15:39   ` [PATCH v2 14/16] cpufreq: Add cpufreq driver for Tegra124 Tuomas Tynkkynen
2014-07-21 15:39     ` Tuomas Tynkkynen
2014-07-21 15:39     ` Tuomas Tynkkynen
2014-07-22  0:49     ` Rafael J. Wysocki
2014-07-22  0:49       ` Rafael J. Wysocki
2014-07-22  0:49       ` Rafael J. Wysocki
2014-07-23  4:44     ` Viresh Kumar
2014-07-23  4:44       ` Viresh Kumar
2014-07-23  6:54       ` Thierry Reding
2014-07-23  6:54         ` Thierry Reding
     [not found]         ` <20140723065412.GA15759-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-07-23  6:58           ` Viresh Kumar
2014-07-23  6:58             ` Viresh Kumar
2014-07-23  6:58             ` Viresh Kumar
2014-07-23  7:24             ` Thierry Reding
2014-07-23  7:24               ` Thierry Reding
2014-07-23  8:25               ` Viresh Kumar
2014-07-23  8:25                 ` Viresh Kumar
     [not found]                 ` <CAKohponfKzuK+TnQvWcvaT8hRX8XZJWXWGMQw138DCwP=qcx+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-23 13:51                   ` Thierry Reding
2014-07-23 13:51                     ` Thierry Reding
2014-07-23 13:51                     ` Thierry Reding
     [not found]       ` <CAKohpomQthJ_XE-HhzW07Q4aVtxQVy97iaL0Vy6Q4Lhw22A=VA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-23 11:57         ` Tuomas Tynkkynen
2014-07-23 11:57           ` Tuomas Tynkkynen
2014-07-23 11:57           ` Tuomas Tynkkynen
2014-07-23 16:50           ` Viresh Kumar
2014-07-23 16:50             ` Viresh Kumar
2014-07-23 19:17             ` Tuomas Tynkkynen
2014-07-23 19:17               ` Tuomas Tynkkynen
     [not found]               ` <53D00A47.7050203-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-24  0:13                 ` Viresh Kumar
2014-07-24  0:13                   ` Viresh Kumar
2014-07-24  0:13                   ` Viresh Kumar
2014-07-24  9:10                   ` Thierry Reding [this message]
2014-07-24  9:10                     ` Thierry Reding
2014-07-23  7:09     ` Thierry Reding
2014-07-23  7:09       ` Thierry Reding
2014-07-23 12:35       ` Tuomas Tynkkynen
2014-07-23 12:35         ` Tuomas Tynkkynen
2014-07-23 13:59         ` Thierry Reding
2014-07-23 13:59           ` Thierry Reding
2014-07-23  7:21     ` pramod gurav
2014-07-23  7:21       ` pramod gurav
2014-07-21 15:39 ` [PATCH v2 15/16] ARM: tegra: Add entries for cpufreq on Tegra124 Tuomas Tynkkynen
2014-07-21 15:39   ` Tuomas Tynkkynen
2014-07-21 15:39   ` Tuomas Tynkkynen
2014-07-21 15:39 ` [PATCH v2 16/16] ARM: tegra: Update defconfig for tegra124-cpufreq Tuomas Tynkkynen
2014-07-21 15:39   ` Tuomas Tynkkynen
2014-07-21 15:39   ` Tuomas Tynkkynen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140724091002.GA3811@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=pwalmsley@nvidia.com \
    --cc=rjw@rjwysocki.net \
    --cc=swarren@wwwdotorg.org \
    --cc=ttynkkynen@nvidia.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.