All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: mathias.kretschmer@fokus.fraunhofer.de, kgiori@qca.qualcomm.com,
	linux-wireless@vger.kernel.org, sven@narfation.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature
Date: Thu, 24 Jul 2014 11:36:07 +0200	[thread overview]
Message-ID: <201407241136.08090.sw@simonwunderlich.de> (raw)
In-Reply-To: <871ttbrtp8.fsf@kamboji.qca.qualcomm.com>

> > +ath10k_core-$(CPTCFG_ATH10K_DEBUGFS) += spectral.o
> 
> This one still uses CPTCFG_ prefix, I'll fix those.
> 

Argh, OK, thanks!

> > @@ -800,8 +800,6 @@ int ath10k_core_start(struct ath10k *ar)
> > 
> >  	else
> >  	
> >  		ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1;
> > 
> > -	INIT_LIST_HEAD(&ar->arvifs);
> > -
> > 
> >  	if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) {
> >  	
> >  		ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n",
> >  		
> >  			    ar->hw_params.name,
> > 
> > @@ -1084,6 +1082,12 @@ struct ath10k *ath10k_core_create(void *hif_priv,
> > struct device *dev,
> > 
> >  	INIT_WORK(&ar->register_work, ath10k_core_register_work);
> >  	INIT_WORK(&ar->restart_work, ath10k_core_restart);
> > 
> > +	INIT_LIST_HEAD(&ar->arvifs);
> 
> I'm a bit suspicious about this, why is it needed?

ath10k_spectral_init() clears the spectral_enabled bit for each vif, and 
therefore needs the list to be initialized ... it is also called on firmware 
crash by ath10k_halt, where checking the list is more useful.

Thanks,
    Simon

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Simon Wunderlich <sw@simonwunderlich.de>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org,
	mathias.kretschmer@fokus.fraunhofer.de, kgiori@qca.qualcomm.com,
	linux-wireless@vger.kernel.org, sven@narfation.org
Subject: Re: [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature
Date: Thu, 24 Jul 2014 11:36:07 +0200	[thread overview]
Message-ID: <201407241136.08090.sw@simonwunderlich.de> (raw)
In-Reply-To: <871ttbrtp8.fsf@kamboji.qca.qualcomm.com>

> > +ath10k_core-$(CPTCFG_ATH10K_DEBUGFS) += spectral.o
> 
> This one still uses CPTCFG_ prefix, I'll fix those.
> 

Argh, OK, thanks!

> > @@ -800,8 +800,6 @@ int ath10k_core_start(struct ath10k *ar)
> > 
> >  	else
> >  	
> >  		ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1;
> > 
> > -	INIT_LIST_HEAD(&ar->arvifs);
> > -
> > 
> >  	if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) {
> >  	
> >  		ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n",
> >  		
> >  			    ar->hw_params.name,
> > 
> > @@ -1084,6 +1082,12 @@ struct ath10k *ath10k_core_create(void *hif_priv,
> > struct device *dev,
> > 
> >  	INIT_WORK(&ar->register_work, ath10k_core_register_work);
> >  	INIT_WORK(&ar->restart_work, ath10k_core_restart);
> > 
> > +	INIT_LIST_HEAD(&ar->arvifs);
> 
> I'm a bit suspicious about this, why is it needed?

ath10k_spectral_init() clears the spectral_enabled bit for each vif, and 
therefore needs the list to be initialized ... it is also called on firmware 
crash by ath10k_halt, where checking the list is more useful.

Thanks,
    Simon

  parent reply	other threads:[~2014-07-24  9:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 15:53 [PATCHv3 0/2] ath10k spectral scan support Simon Wunderlich
2014-07-23 15:53 ` Simon Wunderlich
2014-07-23 15:53 ` [PATCHv3 1/2] ath: Move spectral debugfs structs to shared header Simon Wunderlich
2014-07-23 15:53   ` Simon Wunderlich
2014-07-23 15:53 ` [PATCHv3 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-23 15:53   ` Simon Wunderlich
2014-07-23 17:14 ` [PATCHv3 0/2] ath10k spectral scan support Kalle Valo
2014-07-23 17:14   ` Kalle Valo
2014-07-23 17:32   ` [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-23 17:32     ` Simon Wunderlich
2014-07-24  9:29     ` Kalle Valo
2014-07-24  9:29       ` Kalle Valo
2014-07-24  9:34       ` Michal Kazior
2014-07-24  9:34         ` Michal Kazior
2014-07-24  9:45         ` Kalle Valo
2014-07-24  9:45           ` Kalle Valo
2014-07-24  9:36       ` Simon Wunderlich [this message]
2014-07-24  9:36         ` Simon Wunderlich
2014-07-24  9:40         ` Michal Kazior
2014-07-24  9:40           ` Michal Kazior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201407241136.08090.sw@simonwunderlich.de \
    --to=sw@simonwunderlich.de \
    --cc=ath10k@lists.infradead.org \
    --cc=kgiori@qca.qualcomm.com \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mathias.kretschmer@fokus.fraunhofer.de \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.